Asterisk
/
asterisk
mirror of https://github.com/asterisk/asterisk
1
0
Fork 0
Code Issues Releases Wiki Activity

res_pjsip_nat: Fix potential use of uninitialized transport details

Browse Source 
The ast_sip_request_transport_details must be zero initialized,
otherwise this could lead to a SEGV.

Resolves: #509
pull/532/head
Maximilian Fridrich 1 year ago committed by asterisk-org-access-app[bot]
parent 58b16a538d
commit 14bd1ceef6
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File

2
res/res_pjsip.c
Unescape View File

@ -605,7 +605,7 @@ struct ast_sip_transport_state *ast_sip_find_transport_state_in_use(struct ast_s
int ast_sip_rewrite_uri_to_local(pjsip_sip_uri *uri, pjsip_tx_data *tdata) { int ast_sip_rewrite_uri_to_local(pjsip_sip_uri *uri, pjsip_tx_data *tdata) {
RAII_VAR(struct ast_sip_transport *, transport, NULL, ao2_cleanup); RAII_VAR(struct ast_sip_transport *, transport, NULL, ao2_cleanup);
RAII_VAR(struct ast_sip_transport_state *, transport_state, NULL, ao2_cleanup); RAII_VAR(struct ast_sip_transport_state *, transport_state, NULL, ao2_cleanup);
struct ast_sip_request_transport_details details; struct ast_sip_request_transport_details details = { 0, };
pjsip_sip_uri *tmp_uri; pjsip_sip_uri *tmp_uri;
pjsip_dialog *dlg; pjsip_dialog *dlg;
struct ast_sockaddr addr = { { 0, } }; struct ast_sockaddr addr = { { 0, } };

2
res/res_pjsip_nat.c
Unescape View File

@ -319,8 +319,8 @@ static pj_status_t process_nat(pjsip_tx_data *tdata)
{ {
RAII_VAR(struct ast_sip_transport *, transport, NULL, ao2_cleanup); RAII_VAR(struct ast_sip_transport *, transport, NULL, ao2_cleanup);
RAII_VAR(struct ast_sip_transport_state *, transport_state, NULL, ao2_cleanup); RAII_VAR(struct ast_sip_transport_state *, transport_state, NULL, ao2_cleanup);
struct ast_sip_request_transport_details details = { 0, };
pjsip_via_hdr *via = NULL; pjsip_via_hdr *via = NULL;
struct ast_sip_request_transport_details details;
struct ast_sockaddr addr = { { 0, } }; struct ast_sockaddr addr = { { 0, } };
pjsip_sip_uri *uri = NULL; pjsip_sip_uri *uri = NULL;
RAII_VAR(struct ao2_container *, hooks, NULL, ao2_cleanup); RAII_VAR(struct ao2_container *, hooks, NULL, ao2_cleanup);

Write Preview
Loading…
Cancel
Save