diff --git a/debian/changelog b/debian/changelog index 1b02dff..a2aa819 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,19 @@ +ngcp-www-admin (3.4.1) unstable; urgency=low + + [ dtiefnig ] + * bilprof_edit.tt: use same locklevel texts as for subscriber lock + * subscriber.pm,subscriber_detail.tt: hide active lock level in subscriber lock drop-down + * admin.css: add some space above notifications + * admin.css,tt/: use
  • instead of
    for errors in lists + + [ agranig ] + * admin.conf,menu,tt/: Remove audiofile_feature config option. + * bans.pm,bans_ips.tt,bans_users.tt: Fix IP ban handling and add delete function. + * bans.pm: Fix syntax error. + * bans_ips.tt,bans_users.tt: Cosmetical fixes. + + -- Daniel Tiefnig Tue, 21 Aug 2012 17:14:08 +0200 + ngcp-www-admin (3.4.0) unstable; urgency=low * added trusted peers frontend diff --git a/etc/admin.conf b/etc/admin.conf index a34a6fd..37a8d0b 100644 --- a/etc/admin.conf +++ b/etc/admin.conf @@ -40,12 +40,10 @@ [- END -] stash->{banned_users} = $banned_users; } +sub unban_user : Chained('base') PathPart('unban_user') Args(0) { + my ($self, $c) = @_; + + my $user = $c->request->params->{'user'} || ''; + + $c->model('Provisioning')->call_prov( + $c, + 'voip', + 'unban_user', + { user => $user }, + undef, + ); + + $c->response->redirect("/bans/users"); +} + sub ips : Chained('base') PathPart('ips') Args(0) { my ($self, $c) = @_; @@ -58,5 +74,21 @@ sub ips : Chained('base') PathPart('ips') Args(0) { $c->stash->{banned_ips} = $banned_ips; } +sub unban_ip : Chained('base') PathPart('unban_ip') Args(0) { + my ($self, $c) = @_; + + my $ip = $c->request->params->{'ip'} || ''; + + $c->model('Provisioning')->call_prov( + $c, + 'voip', + 'unban_ip', + { ip => $ip }, + undef, + ); + + $c->response->redirect("/bans/ips"); +} + # Ends, some people will rob their mothers for the ends ... 1 diff --git a/lib/admin/Controller/subscriber.pm b/lib/admin/Controller/subscriber.pm index 7ef11e1..a0e4e63 100644 --- a/lib/admin/Controller/subscriber.pm +++ b/lib/admin/Controller/subscriber.pm @@ -169,6 +169,7 @@ sub detail : Local { config->{VARIABLES}{site_config}{language}, 'Web.Subscriber.Lock'.$$preferences{lock}) if $$preferences{lock}; + $c->stash->{subscriber}{lock} = $$preferences{lock} or 'none'; } else { $c->stash->{account_id} = $c->request->params->{account_id}; diff --git a/root/css/admin.css b/root/css/admin.css index d0b7b68..4f2f990 100644 --- a/root/css/admin.css +++ b/root/css/admin.css @@ -369,8 +369,14 @@ display:none; color:#fff; } -.success { - margin-top: 20px; +.error, .alert, .notice, .success, .info { + margin-top: 1em; +} + +/* this is just here to overrule "ul.cleanlist li" */ +ul li.error, ul li.alert, ul li.notice, ul li.success, ul li.info { + margin-top: 0.9em; + margin-bottom: 1em; } .content li.ui-state-quad { diff --git a/root/layout/menu b/root/layout/menu index 2fb9449..2e1abd8 100644 --- a/root/layout/menu +++ b/root/layout/menu @@ -39,10 +39,8 @@
  • SIP Peerings
  • [% END %]
  • Rewrite Rule Sets
  • - [% IF Catalyst.config.domain.audiofile_features %] -
  • Sound sets
  • - [% END %] -
  • Bans
  • +
  • Sound Sets
  • +
  • Security Bans
  • diff --git a/root/tt/account_detail.tt b/root/tt/account_detail.tt index a395d5e..359e2a0 100644 --- a/root/tt/account_detail.tt +++ b/root/tt/account_detail.tt @@ -159,7 +159,7 @@ [% END %] - [% IF messages.addcash %]
    [% messages.addcash %]
    [% END %] + [% IF messages.addcash %]
  • [% messages.addcash %]
  • [% END %]
  • Free time:
    [% account.balance.free_time_balance %] s
    @@ -172,7 +172,7 @@ [% END %]
  • - [% IF messages.addtime %]
    [% messages.addtime %]
    [% END %] + [% IF messages.addtime %]
  • [% messages.addtime %]
  • [% END %] [% IF edit_balance %]
    diff --git a/root/tt/admin_edit.tt b/root/tt/admin_edit.tt index 94d673e..b96b566 100644 --- a/root/tt/admin_edit.tt +++ b/root/tt/admin_edit.tt @@ -19,7 +19,7 @@ [% IF messages.elogin %] -
    [% messages.elogin %]
    +
  • [% messages.elogin %]
  • [% END %]
  • Password:
    @@ -27,14 +27,14 @@
  • [% IF messages.epass %] -
    [% messages.epass %]
    +
  • [% messages.epass %]
  • [% END %]
  • Repeat Password:
  • [% IF messages.epass2 %] -
    [% messages.epass2 %]
    +
  • [% messages.epass2 %]
  • [% END %]
  • Master:
    diff --git a/root/tt/bans_ips.tt b/root/tt/bans_ips.tt index fa04308..910293b 100644 --- a/root/tt/bans_ips.tt +++ b/root/tt/bans_ips.tt @@ -1,4 +1,4 @@ -

    Bans

    +

    Banned IP Addresses

    [% IF messages.ban_err %]
    [% messages.ban_err %]
    [% END %] [% IF messages.ban_msg %]
    [% messages.ban_msg %]
    [% END %] @@ -14,10 +14,20 @@ diff --git a/root/tt/bans_users.tt b/root/tt/bans_users.tt index 61047dd..8221b57 100644 --- a/root/tt/bans_users.tt +++ b/root/tt/bans_users.tt @@ -1,6 +1,6 @@ [% USE date %] -

    Bans

    +

    Banned Users

    [% IF messages.ban_err %]
    [% messages.ban_err %]
    [% END %] [% IF messages.ban_msg %]
    [% messages.ban_msg %]
    [% END %] @@ -17,15 +17,23 @@
  • Subscriber
    -
    Last auth
    -
    Auth count
    +
    Last Authentication
    +
    Attempts
  • [% FOREACH user IN banned_users %]
  • [% user.username %]
    -
    [% date.format (user.last_auth) %]
    -
    [% user.auth_count %]
    +
    [% date.format (user.last_auth) %]
    +
    [% user.auth_count %]
    + [% UNLESS Catalyst.session.admin.read_only %] +
    +
    + + +
    +
    + [% END %]
  • [% END %] diff --git a/root/tt/billing_fees.tt b/root/tt/billing_fees.tt index 69cb13c..bafb5b7 100644 --- a/root/tt/billing_fees.tt +++ b/root/tt/billing_fees.tt @@ -36,8 +36,8 @@ title="CSV field order: [% field_order %]" />
    + [% IF messages.feefileerr %]
  • [% messages.feefileerr %]
  • [% END %]
  • - [% IF messages.feefileerr %]
    [% messages.feefileerr %]
    [% END %]
    unique identifier string
    [% END %]
  • - [% IF messages.handle %]
    [% messages.handle %]
    [% END %] + [% IF messages.handle %]
  • [% messages.handle %]
  • [% END %]
  • Name:
    @@ -32,7 +32,7 @@ human readable profile name
  • - [% IF messages.name %]
    [% messages.name %]
    [% END %] + [% IF messages.name %]
  • [% messages.name %]
  • [% END %] [% IF Catalyst.config.prepaid_features %]
  • prepaid:
    @@ -53,7 +53,7 @@ base fee charged per billing interval
  • - [% IF messages.charge %]
    [% messages.charge %]
    [% END %] + [% IF messages.charge %]
  • [% messages.charge %]
  • [% END %]
  • Interval Free Time:
    @@ -64,7 +64,7 @@ included time per billing interval
  • - [% IF messages.free_time %]
    [% messages.free_time %]
    [% END %] + [% IF messages.free_time %]
  • [% messages.free_time %]
  • [% END %]
  • Interval Free Cash:
    @@ -75,7 +75,7 @@ included money per billing interval
  • - [% IF messages.free_cash %]
    [% messages.free_cash %]
    [% END %] + [% IF messages.free_cash %]
  • [% messages.free_cash %]
  • [% END %]
  • Fraud Limit:
    @@ -87,23 +87,23 @@ fraud detection threshold, per month
  • - [% IF messages.fraud_interval_limit %]
    [% messages.fraud_interval_limit %]
    [% END %] + [% IF messages.fraud_interval_limit %]
  • [% messages.fraud_interval_limit %]
  • [% END %]
  • Fraud Lock:
    lock accounts if the limit is exceeded
  • - [% IF messages.fraud_interval_lock %]
    [% messages.fraud_interval_lock %]
    [% END %] + [% IF messages.fraud_interval_lock %]
  • [% messages.fraud_interval_lock %]
  • [% END %]
  • Fraud Notify:
    @@ -114,7 +114,7 @@ where e-mail notifications are sent
  • - [% IF messages.fraud_interval_notify %]
    [% messages.fraud_interval_notify %]
    [% END %] + [% IF messages.fraud_interval_notify %]
  • [% messages.fraud_interval_notify %]
  • [% END %]
  • Currency:
    @@ -126,7 +126,7 @@ currency symbol or ISO code
  • - [% IF messages.currency %]
    [% messages.currency %]
    [% END %] + [% IF messages.currency %]
  • [% messages.currency %]
  • [% END %]
  • VAT Rate:
    @@ -137,7 +137,7 @@ %
  • - [% IF messages.vat_rate %]
    [% messages.vat_rate %]
    [% END %] + [% IF messages.vat_rate %]
  • [% messages.vat_rate %]
  • [% END %]
  • VAT Included:
    diff --git a/root/tt/domain.tt b/root/tt/domain.tt index 51a7dcb..7568573 100644 --- a/root/tt/domain.tt +++ b/root/tt/domain.tt @@ -13,8 +13,6 @@
    [% IF Catalyst.config.domain.preference_features %] [% domain.domain %] - [% ELSIF Catalyst.config.domain.audiofile_features %] - [% domain.domain %] [% ELSE %] [% domain.domain %] [% END %] diff --git a/root/tt/domain_preferences.tt b/root/tt/domain_preferences.tt index fb5ba6d..77f39b0 100644 --- a/root/tt/domain_preferences.tt +++ b/root/tt/domain_preferences.tt @@ -94,7 +94,7 @@ [% END %]
  • - [% IF preference.value.error %]
    [% preference.value.error %]
    [% END %] + [% IF preference.value.error %]
  • [% preference.value.error %]
  • [% END %] [% ELSIF preference.key == "ncos" || preference.key == "adm_ncos"%]
  • [% preference.key %]:
    @@ -139,24 +139,6 @@ [% END %]
  • - [% ELSIF preference.key == "sound_set" AND Catalyst.config.domain.audiofile_features %] -
  • -
    [% preference.key %]:
    -
    -
    - -
    -
  • [% ELSIF preference.data_type == "boolean" %]
  • [% preference.key %]:
    @@ -224,7 +206,7 @@
  • [% END %] - [% IF preference.error %]
    [% preference.error %]
    [% END %] + [% IF preference.error %]
  • [% preference.error %]
  • [% END %] [% END %] [% IF edit_preferences %] diff --git a/root/tt/fee_edit.tt b/root/tt/fee_edit.tt index 757becd..c61c406 100644 --- a/root/tt/fee_edit.tt +++ b/root/tt/fee_edit.tt @@ -28,7 +28,7 @@ [% END %] - [% IF messages.destination %]
    [% messages.destination %]
    [% END %] + [% IF messages.destination %]
  • [% messages.destination %]
  • [% END %]
  • Zone:
    @@ -40,7 +40,7 @@ existing or new zone name
  • - [% IF messages.zone %]
    [% messages.zone %]
    [% END %] + [% IF messages.zone %]
  • [% messages.zone %]
  • [% END %]
  • Zone Detail:
    @@ -51,7 +51,7 @@ existing or new zone detail
  • - [% IF messages.zone_detail %]
    [% messages.zone_detail %]
    [% END %] + [% IF messages.zone_detail %]
  • [% messages.zone_detail %]
  • [% END %]
  • Onpeak Init Rate:
    @@ -62,7 +62,7 @@ rate in cent per second
  • - [% IF messages.onpeak_init_rate %]
    [% messages.onpeak_init_rate %]
    [% END %] + [% IF messages.onpeak_init_rate %]
  • [% messages.onpeak_init_rate %]
  • [% END %]
  • Onpeak Init Interval:
    @@ -73,7 +73,7 @@ interval in seconds
  • - [% IF messages.onpeak_init_interval %]
    [% messages.onpeak_init_interval %]
    [% END %] + [% IF messages.onpeak_init_interval %]
  • [% messages.onpeak_init_interval %]
  • [% END %]
  • Onpeak Follow Rate:
    @@ -84,7 +84,7 @@ rate in cent per second
  • - [% IF messages.onpeak_follow_rate %]
    [% messages.onpeak_follow_rate %]
    [% END %] + [% IF messages.onpeak_follow_rate %]
  • [% messages.onpeak_follow_rate %]
  • [% END %]
  • Onpeak Follow Interval:
    @@ -95,7 +95,7 @@ interval in seconds
  • - [% IF messages.onpeak_follow_interval %]
    [% messages.onpeak_follow_interval %]
    [% END %] + [% IF messages.onpeak_follow_interval %]
  • [% messages.onpeak_follow_interval %]
  • [% END %]
  • Offpeak Init Rate:
    @@ -106,7 +106,7 @@ rate in cent per second
  • - [% IF messages.offpeak_init_rate %]
    [% messages.offpeak_init_rate %]
    [% END %] + [% IF messages.offpeak_init_rate %]
  • [% messages.offpeak_init_rate %]
  • [% END %]
  • Offpeak Init Interval:
    @@ -117,7 +117,7 @@ interval in seconds
  • - [% IF messages.offpeak_init_interval %]
    [% messages.offpeak_init_interval %]
    [% END %] + [% IF messages.offpeak_init_interval %]
  • [% messages.offpeak_init_interval %]
  • [% END %]
  • Offpeak Follow Rate:
    @@ -128,7 +128,7 @@ rate in cent per seconds
  • - [% IF messages.offpeak_follow_rate %]
    [% messages.offpeak_follow_rate %]
    [% END %] + [% IF messages.offpeak_follow_rate %]
  • [% messages.offpeak_follow_rate %]
  • [% END %]
  • Offpeak Follow Interval:
    @@ -139,7 +139,7 @@ interval in seconds
  • - [% IF messages.offpeak_follow_interval %]
    [% messages.offpeak_follow_interval %]
    [% END %] + [% IF messages.offpeak_follow_interval %]
  • [% messages.offpeak_follow_interval %]
  • [% END %]
  • Use Free Time:
    diff --git a/root/tt/peering_preferences.tt b/root/tt/peering_preferences.tt index 220f2f2..a2b32ef 100644 --- a/root/tt/peering_preferences.tt +++ b/root/tt/peering_preferences.tt @@ -97,7 +97,7 @@ [% END %]
  • - [% IF preference.value.error %]
    [% preference.value.error %]
    [% END %] + [% IF preference.value.error %]
  • [% preference.value.error %]
  • [% END %] [% ELSIF preference.key == "ncos" || preference.key == "adm_ncos"%]
  • [% preference.key %]:
    @@ -142,24 +142,6 @@ [% END %]
  • - [% ELSIF preference.key == "sound_set" AND Catalyst.config.domain.audiofile_features %] -
  • -
    [% preference.key %]:
    -
    -
    - -
    -
  • [% ELSIF preference.data_type == "boolean" %]
  • [% preference.key %]:
    @@ -227,7 +209,7 @@
  • [% END %] - [% IF preference.error %]
    [% preference.error %]
    [% END %] + [% IF preference.error %]
  • [% preference.error %]
  • [% END %] [% END %] [% IF edit_preferences %] diff --git a/root/tt/subscriber_detail.tt b/root/tt/subscriber_detail.tt index 616c36f..9bf128d 100644 --- a/root/tt/subscriber_detail.tt +++ b/root/tt/subscriber_detail.tt @@ -51,11 +51,21 @@ Lock - unlock
    - foreign calls
    - all outgoing calls
    - incoming and outgoing
    - global (including CSC)
    + [% UNLESS subscriber.lock == 'none' %] + unlock
    + [% END %] + [% UNLESS subscriber.lock == 'foreign' %] + foreign calls
    + [% END %] + [% UNLESS subscriber.lock == 'outgoing' %] + all outgoing calls
    + [% END %] + [% UNLESS subscriber.lock == 'incoming' %] + incoming and outgoing
    + [% END %] + [% UNLESS subscriber.lock == 'global' %] + global (including CSC)
    + [% END %]
    Terminate [% END %] @@ -97,7 +107,7 @@ [% END %] - [% IF messages.webusername %]
    [% messages.webusername %]
    [% END %] + [% IF messages.webusername %]
  • [% messages.webusername %]
  • [% END %]
  • Web Password:
    @@ -120,7 +130,7 @@ [% END %] [% END %]
  • - [% IF messages.webpassword %]
    [% messages.webpassword %]
    [% END %] + [% IF messages.webpassword %]
  • [% messages.webpassword %]
  • [% END %]
  • E.164 Number:
    [% IF edit_subscriber %] @@ -148,10 +158,10 @@ [% END %]
  • - [% IF messages.number %]
    [% messages.number %]
    [% END %] - [% IF messages.number_cc %]
    [% messages.number_cc %]
    [% END %] - [% IF messages.number_ac %]
    [% messages.number_ac %]
    [% END %] - [% IF messages.number_sn %]
    [% messages.number_sn %]
    [% END %] + [% IF messages.number %]
  • [% messages.number %]
  • [% END %] + [% IF messages.number_cc %]
  • [% messages.number_cc %]
  • [% END %] + [% IF messages.number_ac %]
  • [% messages.number_ac %]
  • [% END %] + [% IF messages.number_sn %]
  • [% messages.number_sn %]
  • [% END %]
  • Alias Numbers:
    @@ -217,7 +227,7 @@ [% END %] [% END %]
  • - [% IF messages.password %]
    [% messages.password %]
    [% END %] + [% IF messages.password %]
  • [% messages.password %]
  • [% END %]
  • Administrative:
    diff --git a/root/tt/subscriber_edit_aliases.tt b/root/tt/subscriber_edit_aliases.tt index 679a1e9..5537a13 100644 --- a/root/tt/subscriber_edit_aliases.tt +++ b/root/tt/subscriber_edit_aliases.tt @@ -50,11 +50,11 @@
  • [% IF messages.number_cc OR messages.number_ac OR messages.number_sn %] -
    +
  • [% messages.number_cc IF messages.number_cc %] [% messages.number_ac IF messages.number_ac %] [% messages.number_sn IF messages.number_sn %] -
  • + [% END %] diff --git a/root/tt/subscriber_edit_speeddial.tt b/root/tt/subscriber_edit_speeddial.tt index 6a8c5e3..7b2d41f 100755 --- a/root/tt/subscriber_edit_speeddial.tt +++ b/root/tt/subscriber_edit_speeddial.tt @@ -40,8 +40,8 @@ - [% IF sdentry.error %]
  • [% sdentry.error %]
    [% END %]
  • + [% IF sdentry.error %]
  • [% sdentry.error %]
  • [% END %] [% END %] [% END %] diff --git a/root/tt/subscriber_preferences.tt b/root/tt/subscriber_preferences.tt index e4da9e1..2c1f8c1 100644 --- a/root/tt/subscriber_preferences.tt +++ b/root/tt/subscriber_preferences.tt @@ -93,24 +93,6 @@ [% END %] - [% ELSIF preference.key == "sound_set" AND Catalyst.config.domain.audiofile_features %] -
  • -
    [% preference.key %]:
    -
    -
    - -
    -
  • [% ELSIF preference.data_type == "boolean" %]
  • [% preference.key %]:
    @@ -178,7 +160,7 @@
  • [% END %] - [% IF preference.error %]
    [% preference.error %]
    [% END %] + [% IF preference.error %]
  • [% preference.error %]
  • [% END %] [% END %] [% IF edit_preferences %] @@ -392,7 +374,7 @@ value="[% subscriber.voicebox_preferences.password %]" /> - [% IF messages.vpin %]
    [% messages.vpin %]
    [% END %] + [% IF messages.vpin %]
  • [% messages.vpin %]
  • [% END %]
  • E-Mail:
    @@ -401,7 +383,7 @@ value="[% subscriber.voicebox_preferences.email %]" />
  • - [% IF messages.vemail %]
    [% messages.vemail %]
    [% END %] + [% IF messages.vemail %]
  • [% messages.vemail %]
  • [% END %]
  • Attach WAV:
    @@ -452,7 +434,7 @@ value="[% subscriber.fax_preferences.name %]" />
  • - [% IF messages.faxname %]
  • [% messages.faxname %]
  • [% END %] + [% IF messages.faxname %]
  • [% messages.faxname %]
  • [% END %]
  • Password:
    @@ -478,7 +460,7 @@ [% END %]
  • - [% IF messages.faxpass %]
  • [% messages.faxpass %]
  • [% END %] + [% IF messages.faxpass %]
  • [% messages.faxpass %]
  • [% END %]
  • Active: