From 6ead5d0d98e701fcedec41c9cac809bf2be54530 Mon Sep 17 00:00:00 2001
From: Christian Veigl <cveigl@sipwise.com>
Date: Thu, 28 Jun 2012 12:44:04 +0000
Subject: [PATCH] obey percritic; minor and defandable
 ProhibitMutatingListFunctions

---
 lib/admin/Controller/billing.pm    | 2 +-
 lib/admin/Controller/subscriber.pm | 5 +++--
 lib/admin/Utils.pm                 | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/lib/admin/Controller/billing.pm b/lib/admin/Controller/billing.pm
index 879289b..8cb7e47 100644
--- a/lib/admin/Controller/billing.pm
+++ b/lib/admin/Controller/billing.pm
@@ -995,7 +995,7 @@ sub _normalize_destination : Private {
         $destination =~ s/\./\\./g;
         $destination = '^'. $destination .'$';
     } else {
-        return undef;
+        return;
     }
 
     return $destination;
diff --git a/lib/admin/Controller/subscriber.pm b/lib/admin/Controller/subscriber.pm
index 35879c4..1c0af69 100644
--- a/lib/admin/Controller/subscriber.pm
+++ b/lib/admin/Controller/subscriber.pm
@@ -720,7 +720,8 @@ sub preferences : Local {
     return unless $c->model('Provisioning')->call_prov( $c, 'voip', 'get_preferences',
                                                         undef, \$db_prefs
                                                       );
-    my $voip_preferences = [ grep { $$_{usr_pref} } @$db_prefs ] if eval { @$db_prefs };
+    my $voip_preferences;
+    $voip_preferences = [ grep { $$_{usr_pref} } @$db_prefs ] if eval { @$db_prefs };
 
     ### restore data entered by the user ###
 
@@ -808,7 +809,7 @@ sub preferences : Local {
         } elsif($$pref{preference} eq 'block_in_list' or $$pref{preference} eq 'block_out_list' or
                 $$pref{preference} eq 'adm_block_in_list' or $$pref{preference} eq 'adm_block_out_list')
         {
-          eval { @{$$preferences{$$pref{preference}}} = map { s/^([1-9])/+$1/; $_ } @{$$preferences{$$pref{preference}}} };
+          eval { @{$$preferences{$$pref{preference}}} = map { s/^([1-9])/+$1/; $_ } @{$$preferences{$$pref{preference}}} }; ## no critic ProhibitMutatingListFunctions
         }
         elsif ($$pref{data_type} eq 'enum') {
 
diff --git a/lib/admin/Utils.pm b/lib/admin/Utils.pm
index 442bdda..2eb636b 100644
--- a/lib/admin/Utils.pm
+++ b/lib/admin/Utils.pm
@@ -282,7 +282,7 @@ sub prepare_tt_prefs {
                                                             );
           $c->stash->{rewrite_rule_sets} = $rules if eval { @$rules };
         } elsif($$pref{preference} eq 'block_in_list' or $$pref{preference} eq 'block_out_list') {
-          eval { @{$$preferences{$$pref{preference}}} = map { s/^([1-9])/+$1/; $_ } @{$$preferences{$$pref{preference}}} };
+          eval { @{$$preferences{$$pref{preference}}} = map { s/^([1-9])/+$1/; $_ } @{$$preferences{$$pref{preference}}} }; ## no critic
         }
 
         push @stashprefs,