10 Commits (211c967d207360771988403fb9905c69e99648d8)

Author	SHA1	Message	Date
Alexander Lutay	99516d89af	TT#29356 Fix fe764620: fix help link inside t/tap-tests-docker/perlcriticrc ... The file t/tap-tests-docker/perlcriticrc has been moved from puppet-sipwise.git into the current system-tests.git repository in commit fe76462022. Unfortunately I forgot to update the help message inside the file. Fixed. Change-Id: Ia365ffa90c7a8c13f1590cc9970185499d20791f	6 years ago
Guillem Jover	c2f1493c0e	TT#50954 Force docker image regeneration ... This should pick up the updated perlcritic config. Change-Id: I41d29943f64223ab0a4b10cdd23c52af8fddcdd7	6 years ago
Guillem Jover	23dedd4b0c	TT#50954 Disable perlcritic's InputOutput::ProhibitExplicitStdin policy ... This policy is giving bad advice. The <> operator is security unsafe, as it interprets filenames as if passed to the two-form open function, which means it can do code injection via crafted filenames. While reading from <STDIN> directly might not always be correct, its consequences are far milder than the damage inflicted by the diamond operator. Change-Id: I0fdf097be3b5e2a3a483f2e5d80f4fdb1f17911b	6 years ago
Sergii Kipot	8ee8596bbf	TT#38005 Rebuild docker after perlcritic change ... Change-Id: I24791835f7365fe8790da49a792f16e99a6af13f	7 years ago
Guillem Jover	99b9b3e272	TT#38005 Allow includes within stringy eval in perlcritic ... Using stringy eval to handle conditional use is one of the few cases where it seems to be always legitimate to allow it. This is at least currently required for ngcp-panel. Change-Id: Id641b87609c916e6e60dfa76d95e996fa18eef7f	7 years ago
Alexander Lutay	96785fcf2c	TT#29621 Set LC_ALL=C.UTF-8 to fix shellcheck error: hGetContents: invalid argument ... shellcheck before version 0.4.7 has an error: > source/somefile: hGetContents: invalid argument (invalid byte sequence) The issue is reported and fixed here https://github.com/koalaman/shellcheck/issues/324 Since we are in Jessie and using version 0.3.4 we need to set locale properly. Change-Id: I92cf75dec4b40d32650375867b97dc7f4ee868a3	7 years ago
Alexander Lutay	fe76462022	TT#29356 Move perlcriticrc with all the history from puppet-sipwise.git to system-tests.git ... And use it into Docker-based env for TAP tests. Change-Id: I94496d0f910b01db8e2e4015970b1dd090423f45	7 years ago
Manuel Montecelo	edad916ef2	TT#29356 Improve the way to install checkbashisms from devscripts ... Use "dpkg" instead of "ar", and don't write the rest of the contents to disk. Change-Id: I42e19ec04613dfbee5809917bb01347d6e2aa726	7 years ago
Alexander Lutay	be85d77e0b	TT#29356 Use pep8 from jessie-backports as requested in TT#23863 ... Change-Id: I2e98ac581832512a9f498ff53e498813e8ceeff1	7 years ago
Alexander Lutay	6ed91972b1	TT#29356 Add Jessie based Dockerfile for Jenkins tap-tests ... It is a popular test, trying to keep the small Docker image size. The image will be used to migrate all Jenkins tap-tests to Docker. It will unblock the nodes "jenkins-slave*" migration to Debian stretch. Later we will be able to switch jenkins on "NGCP release specific Docker images" (using Docker tags like we do for all other Docker images) and then upgrade Docker image to Debian stretch in trunk (while we still be able to keep jessie for some Git repos in case of emergency). The script checkbashisms.pl extracted manually because the package "devscripts" has too big dependencies list which increases the Docker image size three times (till ~600Mb). Also we have to use "/code/source" while normally we have just "/code" because tap_tool_dispatcher from jenkins-debian-glue is strict to the folder name: > if ! [ -d source ] ; then > echo "Error: no source directory found, please run inside Jenkins." >&2 > exit 1 >fi Change-Id: I21fb5c088db3f2966b2e374647061059dda11329	7 years ago