6 Commits (mr10.5.7)

Author	SHA1	Message	Date
Mykola Malkov	2e815d012c	TT#139151 Remove hostname checking ... The code was switched to use ngcp_hostname so no need to check the actual hostname but check ngcp-hostname output. Change-Id: Ie7a74dfcff9d94c4839c49dac6a4d5dd64e32fcb	4 years ago
Michael Prokop	ae34398b3a	TT#119602 Properly handle trap also in case of errors in functions ... Quoting from "man bash" about `-E` (AKA errtrace): | If set, any trap on ERR is inherited by shell functions, command | substitutions, and commands executed in a subshell environment. | The ERR trap is normally not inherited in such cases. To demonstrate the problem see this short shell script: | % cat foo | set -eu -o pipefail | | bailout() { | echo "Bailing out because of error" >&2 | exit 1 | } | trap bailout 1 2 3 6 9 14 15 ERR | | foo() { | echo "Executing magic" | magic | } | | foo | echo end If "magic" can't be executed, then this fails as follows: | % bash ./foo | Executing magic | ./foo: line 11: magic: command not found But it doesn't invoke the bailout function via trap. When using `set -eE` (AKA errexit + errtrace), instead of only `set -e` (errexit), then it behaves as expected though: | % bash ./foo | Executing magic | ./foo: line 11: magic: command not found | Bailing out because of error Change-Id: I3feca2af2276cd64cd17f8768eb9bf130e170f92	4 years ago
Guillem Jover	21d7cbbce2	TT#56053 Make the node state a run-time variable ... Nowadays goss yml files are generated by ngcpcfg. But their content depends on whether the node is active or not, which can change dynamically during the lifetime of the generated files from the templates. Which will make the goss checks fail when the node state changes. Switch the node state into a run-time variable, and use go template support to parametrize this into the goss checks. For the Template Toolkit values that get instantiated within the go template conditionals, we need to make sure we always set a boolean value, as the Template Toolkit will return undef on false values, which would be considered a non-existining argument. Even though the has_role method will always return either 0 or 1, we still force a boolean value to make the code future-proof in case more logic is added on the same check, which would then turn it into a Template Toolkit boolean evaluation and possibly return nothing on false. Change-Id: I19c3ef48f09c8d2e79613ef118adc362399a6e78	5 years ago
Guillem Jover	38264e82c5	TT#56053 Switch from environment variables to a goss variables file ... The semantics of the environment variables are different, as they are always considered strings. The variables file makes it possible to specify types, given that it's a yaml file. So the SKIP variables will now be proper booleans. Change-Id: Ibbc02c047fd743b8bff9a9da52cffd76db5d7524	5 years ago
Alexander Lutay	1043fb0665	TT#72351 Fix 62a2332: allow '--help' option for ngcp-system-tests ... Otherwise: > root@web01a:~# ngcp-system-tests --help > ngcp-system-tests: unrecognized option '--help' > root@web01a:~# Change-Id: I464ee9be5b0311f27d0682756ebcb14f49ba82a2	5 years ago
Guillem Jover	62a2332662	TT#72351 Add a new helper program to run the tests ... This new program is a wrapper to make running the tests easier, and it will abstrat all necessary knowledge about the test runner. We also remove the results file generation support, and let our caller handle it as it simplifies the code overall. Change-Id: Iad884429b00a94d5f3c9c3b37db31a523ab3c701	5 years ago