We run the *-tap-test Jenkins jobs in a docker environment. To be able
to use jenkins-debian-glue from our own internal repository, we need to
enable the repository in apt's sources.list configuration.
Change-Id: Id9cccd0f7edd15ebffc1fc71e274d6943c77a2c3
Restoring back byllseye image for trunk. 'buster' one
was set temporary just in order to build missed docker image
for 'buster'
This reverts commit 94666c9714.
Change-Id: Ibb4f97d962987ddebdeee6fc38aadcb547af4b75
We still have some internal repos building 'buster' packages and
they will use 'buster' dockers for testing based on $distribution
option. So let's build also buster image for tap-tests.
Change-Id: Ibb3c021fa4ad7856564f02687df028833c5aa983
The package was updated to support pycodestyle in bullseye so we need
to rebuild the docker image now.
Change-Id: Id3b22ff1824225072e77dc1e4237acfd540e3c00
We use quite old pep8 v1.6.2 which in particular misses this
change https://github.com/PyCQA/pycodestyle/pull/502
Let's update Dockerfile to use pycodestyle(former pep8) from
bullseye.
Change-Id: Id29acd80be212cffa127550d9a4deb764a5b5b30
The file t/tap-tests-docker/perlcriticrc has been moved from puppet-sipwise.git
into the current system-tests.git repository in commit fe76462022.
Unfortunately I forgot to update the help message inside the file. Fixed.
Change-Id: Ia365ffa90c7a8c13f1590cc9970185499d20791f
This policy is giving bad advice. The <> operator is security unsafe, as
it interprets filenames as if passed to the two-form open function,
which means it can do code injection via crafted filenames.
While reading from <STDIN> directly might not always be correct, its
consequences are far milder than the damage inflicted by the diamond
operator.
Change-Id: I0fdf097be3b5e2a3a483f2e5d80f4fdb1f17911b
Using stringy eval to handle conditional use is one of the few cases
where it seems to be always legitimate to allow it. This is at least
currently required for ngcp-panel.
Change-Id: Id641b87609c916e6e60dfa76d95e996fa18eef7f
shellcheck before version 0.4.7 has an error:
> source/somefile: hGetContents: invalid argument (invalid byte sequence)
The issue is reported and fixed here https://github.com/koalaman/shellcheck/issues/324
Since we are in Jessie and using version 0.3.4 we need to set locale properly.
Change-Id: I92cf75dec4b40d32650375867b97dc7f4ee868a3
It is a popular test, trying to keep the small Docker image size.
The image will be used to migrate all Jenkins tap-tests to Docker.
It will unblock the nodes "jenkins-slave*" migration to Debian stretch.
Later we will be able to switch jenkins on "NGCP release specific Docker images"
(using Docker tags like we do for all other Docker images)
and then upgrade Docker image to Debian stretch in trunk
(while we still be able to keep jessie for some Git repos
in case of emergency).
The script checkbashisms.pl extracted manually
because the package "devscripts" has too big dependencies list which
increases the Docker image size three times (till ~600Mb).
Also we have to use "/code/source" while normally we have just "/code"
because tap_tool_dispatcher from jenkins-debian-glue is strict to the folder name:
> if ! [ -d source ] ; then
> echo "Error: no source directory found, please run inside Jenkins." >&2
> exit 1
>fi
Change-Id: I21fb5c088db3f2966b2e374647061059dda11329
Victor Seva
Michael Prokop
Mykola Malkov
Sergii Kipot
Guillem Jover
Alexander Lutay
Manuel Montecelo