sipwise/sems - sems - Forgejo: Beyond coding. We forge.

Commit Graph

Author	SHA1	Message	Date
Donat Zenichev	80d986e149	MT#57408 3745ff0778d6a55 causes seg.faults A fix-up for 3745ff0778d6a55. This must fix: Program terminated with signal SIGSEGV, Segmentation fault. "\302\3242R \204\vg\266f9\356\277[\252\336J\205\371\020Ŵ\313ٛ\v\231\214\360\355\243\034g\022\001\n\025") at ./core/sip/sip_parser_async.cpp:205 205 ./core/sip/sip_parser_async.cpp: No such file or directory. [Current thread is 1 (Thread 0x7f80c07ea6c0 (LWP 3928994))] (gdb) bt full "\302\3242R \204\vg\266f9\356\277[\252\336J\205\371\020Ŵ\313ٛ\v\231\214\360\355\243\034g\022\001\n\025") at ./core/sip/sip_parser_async.cpp:205 err = 0 c = @0x7f807c001390: 0x7f807c00140e "*\302\3242R \204\vg\266f9\356\277[\252\336J\205\371\020Ŵ\313ٛ\v\231\214\360\355\243\034g\022\001\n\025" st = @0x7f807c0013a4: 102 saved_st = @0x7f807c0013a8: 0 hdr = 0x0 Change-Id: Icde152783b9dc5a68dde9d29f96d1d87b36e0671	10 months ago
Donat Zenichev	678730d7b5	MT#57408 warning: clearing an object of non-trivial type This commit fixes this: In file included from sip_parser_async.cpp:1: sip_parser_async.h: In member function 'void parser_state::reset_hdr_parser()': sip_parser_async.h:32:37: warning: 'void* memset(void, int, size_t)' clearing an object of non-trivial type 'struct sip_header'; use assignment or value-initialization instead [-Wclass-memaccess] 32 \| memset(&hdr,0,sizeof(sip_header)); \| ^ In file included from sip_parser_async.h:4, from sip_parser_async.cpp:1: parse_header.h:44:8: note: 'struct sip_header' declared here 44 \| struct sip_header \| ^~~~~~~~~~ sip_parser_async.cpp: In function 'int parse_headers_async(parser_state, char)': sip_parser_async.cpp:215:36: warning: 'void memset(void*, int, size_t)' clearing an object of non-trivial type 'struct sip_header'; use assignment or value-initialization instead [-Wclass-memaccess] 215 \| memset(hdr,0,sizeof(sip_header)); \| ^ In file included from sip_parser_async.h:4, from sip_parser_async.cpp:1: parse_header.h:44:8: note: 'struct sip_header' declared here 44 \| struct sip_header \| ^~~~~~~~~~ In general, using `var1 = {};` approach to initialize/clear a struct is equivalent to using `memset(var1, 0, sizeof(MyOwnStruct1));`. So there shouldn't be any big risks associated with swapping one for the other. The `memset()` may be slightly more efficient in terms of performance, especially when dealing with array of structures, but in this situation we are dealing with quite a small struct, which represents: a type, a name and a value. As long as `var1 = {};` approach is supported by our compiler and we don't need to initialize a large array of structures (in our case it isn't), there shouldn't be any big risks associated with swapping one for the other. Change-Id: I10570b628d3e5a634d764b83f7558d38ecc6a757	3 years ago
Victor Seva	ff47897962	Imported Upstream version 1.6.0~20140516~eaa616	12 years ago

Author

SHA1

Message

Date

Donat Zenichev

80d986e149

MT#57408 3745ff0778d6a55 causes seg.faults

A fix-up for 3745ff0778d6a55.

This must fix:

Program terminated with signal SIGSEGV, Segmentation fault.
   "*\302\3242R \204\vg\266f9\356\277[\252\336J\205\371\020Ŵ\313ٛ\v\231\214\360\355\243\034g\022\001\n\025")
    at ./core/sip/sip_parser_async.cpp:205
205	./core/sip/sip_parser_async.cpp: No such file or directory.
[Current thread is 1 (Thread 0x7f80c07ea6c0 (LWP 3928994))]
(gdb) bt full
    "*\302\3242R \204\vg\266f9\356\277[\252\336J\205\371\020Ŵ\313ٛ\v\231\214\360\355\243\034g\022\001\n\025")
    at ./core/sip/sip_parser_async.cpp:205
        err = 0
        c = @0x7f807c001390: 0x7f807c00140e "*\302\3242R \204\vg\266f9\356\277[\252\336J\205\371\020Ŵ\313ٛ\v\231\214\360\355\243\034g\022\001\n\025"
        st = @0x7f807c0013a4: 102
        saved_st = @0x7f807c0013a8: 0
        hdr = 0x0

Change-Id: Icde152783b9dc5a68dde9d29f96d1d87b36e0671

Donat Zenichev

678730d7b5

MT#57408 warning: clearing an object of non-trivial type

This commit fixes this:

     In file included from sip_parser_async.cpp:1:
     sip_parser_async.h: In member function 'void parser_state::reset_hdr_parser()':
     sip_parser_async.h:32:37: warning: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type 'struct sip_header'; use assignment or value-initialization instead [-Wclass-memaccess]
        32 |     memset(&hdr,0,sizeof(sip_header));
           |                                     ^
     In file included from sip_parser_async.h:4,
                      from sip_parser_async.cpp:1:
     parse_header.h:44:8: note: 'struct sip_header' declared here
        44 | struct sip_header
           |        ^~~~~~~~~~

     sip_parser_async.cpp: In function 'int parse_headers_async(parser_state*, char*)':
     sip_parser_async.cpp:215:36: warning: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type 'struct sip_header'; use assignment or value-initialization instead [-Wclass-memaccess]
       215 |     memset(hdr,0,sizeof(sip_header));
           |                                    ^
     In file included from sip_parser_async.h:4,
                      from sip_parser_async.cpp:1:
     parse_header.h:44:8: note: 'struct sip_header' declared here
        44 | struct sip_header
           |        ^~~~~~~~~~

In general, using `var1 = {};` approach to initialize/clear a struct is
equivalent to using `memset(var1, 0, sizeof(MyOwnStruct1));`.
So there shouldn't be any big risks associated with swapping one for the other.

The `memset()` may be slightly more efficient in terms of performance,
especially when dealing with array of structures, but in this situation
we are dealing with quite a small struct, which represents: a type, a name and a value.

As long as `var1 = {};` approach is supported by our compiler and
we don't need to initialize a large array of structures (in our case it isn't),
there shouldn't be any big risks associated with swapping one for the other.

Change-Id: I10570b628d3e5a634d764b83f7558d38ecc6a757

Victor Seva

ff47897962

Imported Upstream version 1.6.0~20140516~eaa616

3 Commits (775eaeb420578cbac18eae2f4dbf2b94f3183fbc)