1 Commits (master)

Author	SHA1	Message	Date
Bit-Savva Mikhail	3e7d80f2b7	MT#64326 don't echo back the remote RTCP port when relaying media ... When SEMS is the media endpoint - on a CloudPBX call that happens when it plays music on hold - AmB2BMedia::replaceConnectionAddress() puts its own port into m=audio, but leaves the a=rtcp taken over from the received SDP untouched. AmSdp::print() prints that attribute back out verbatim, so the offer SEMS sends towards the other leg pairs its own RTP port with the RTCP port of the party the SDP came from: m=audio 15000 RTP/AVP 8 101 a=rtcp:34505 RFC 3605 expects a=rtcp to carry the RTCP port of whoever sends the SDP, so the attribute describes the wrong endpoint. Its value is also the port rtpengine listens on towards SEMS, which is thereby told to send RTCP to itself. State our own RTCP port whenever the media port is replaced, no matter whether the remote party advertised one. AmRtpSocketPair binds the RTCP socket to RTP+1 and gives up rather than fall back to another port, so the advertised value cannot disagree with the socket we listen on. Only relayed media is affected. Pass-through SDP does not have its port replaced and keeps the attribute as received. Change-Id: I4b06236eea9d5ac26bbdfa12c4b34ed9f2562e2e	2 weeks ago