13 Commits (master)

Author	SHA1	Message	Date
Bit-Savva Mikhail	3e7d80f2b7	MT#64326 don't echo back the remote RTCP port when relaying media ... When SEMS is the media endpoint - on a CloudPBX call that happens when it plays music on hold - AmB2BMedia::replaceConnectionAddress() puts its own port into m=audio, but leaves the a=rtcp taken over from the received SDP untouched. AmSdp::print() prints that attribute back out verbatim, so the offer SEMS sends towards the other leg pairs its own RTP port with the RTCP port of the party the SDP came from: m=audio 15000 RTP/AVP 8 101 a=rtcp:34505 RFC 3605 expects a=rtcp to carry the RTCP port of whoever sends the SDP, so the attribute describes the wrong endpoint. Its value is also the port rtpengine listens on towards SEMS, which is thereby told to send RTCP to itself. State our own RTCP port whenever the media port is replaced, no matter whether the remote party advertised one. AmRtpSocketPair binds the RTCP socket to RTP+1 and gives up rather than fall back to another port, so the advertised value cannot disagree with the socket we listen on. Only relayed media is affected. Pass-through SDP does not have its port replaced and keeps the attribute as received. Change-Id: I4b06236eea9d5ac26bbdfa12c4b34ed9f2562e2e	2 weeks ago
Bit-Savva Mikhail	f8b7339c95	MT#66037 t: wait for the very ACK instead of draining blind ... A test answering one of SEMS' INVITEs later than T1 finds a timer-A retransmission of it in front of the ACK, and the blind drain took that for the ACK. The next in-dialog re-INVITE then went out right behind our 2xx, got read by another UDP receiver thread first and was rightly 491'd as glare (RFC 3261 14.2). Wait for the ACK with the INVITE's CSeq instead, skipping its retransmissions. The 491 the glare test provokes was never ACKed, so SEMS kept resending it (timer G) and a copy could be read in place of the relayed 200 OK. ACK it (RFC 3261 17.1.1.3). Fake 200s keep being resent for a while even after we have ACKed them, so read final replies by CSeq rather than taking whatever comes next, and answer INFOs relayed by DSM that show up meanwhile (late copies, or ones an earlier read missed). The renegotiation following the fake 200 to collide1 was waited for one second only and then given up on; when it came later, collide2 met it still pending and got 491'd at the dialog layer - the "491 instead of 200" on collide2. SEMS always sends it, so wait for it for real. Change-Id: I0f28734ee384cb3ca9e900051e30c208f053c567	3 weeks ago
Donat Zenichev	618c15d95b	MT#65603 option: tests covering parser ... For the cases with option tags are being added/removed from the headers (e.g. Require, Supported), we have to cover corner cases. Introduce according tests into existing core tests covering headers, as well as python framework part of it. Change-Id: Iad15add88473f9d64cc6a3d27fc6e996e4a81abf	4 months ago
Donat Zenichev	fcdb4d89d9	MT#59962 test suite: add test for WebRTC like media ... Add a test that covers `UDP/TLS/RTP/SAVPF` transport and particularly focuses on ICE and DTLS related attrs: - `a=fingerprint` - `a=setup` - `a=tls-id` - `a=ice-ufrag` - `a=ice-pwd` - `a=candidate` Send the original INVITE with `UDP/TLS/RTP/SAVPF` SDP, including those attrs, and then assert that the B-leg INVITE still has them. Also improtve the ` _make_invite()` so that it can accept an optional SDP body so the new case can reuse existing INVITE builder. Change-Id: Ib3ff54bec50f364b79e189bd8e61bd42bb3f6503	4 months ago
Bit-Savva Mikhail	f9051c4986	MT#65396 fix B2B updates racing a pending re-INVITE being 491d/dropped ... Mirrors the sems-pbx fix for the shared apps/sbc and core code. When a mid-transfer call is picked up (BLF), SEMS sends a re-INVITE with the picker's media towards the caller while another re-INVITE is still pending on that leg. It used to answer 491 and drop the update, so the call connects with no audio on either side. The P-Force-491: 0 marker exists to prevent exactly this: it tells the receiving leg to queue the update instead of 491ing it. But onB2BEvent() read the marker from the relayed request hdrs - which SBCCallLeg::relayEvent() has already run the profile's header filter over. Whitelist profiles don't list the header, so it was stripped and the 491 fired anyway. Read the marker earlier, in AmB2BSession::onSipRequest() while the hdrs are still unfiltered, and carry it as a skip_491 flag on the event. The queued update is replayed once the pending transaction ends, as before. This CE codebase has no call_transfer module, so t/test-xdsm-race.py reproduces the race with generic sbc.putOnHold/sbc.resumeHeld DSM actions over the same CallLeg.cpp path: the basic race, two stacked self-updates ahead of a collision, a plain unmarked glare that must still get 491, and the marker surviving the whitelist filter. Each collision carries the marker like the real pickup does, so the tests 491 on unpatched code. Also make the tests robust on a loaded CI: recvB2BINVITE() skips in-dialog INVITEs (those with a To-tag), and the queued updates are read by CSeq freshness, so timer-A retransmissions of earlier re-INVITEs piling up in the socket buffer aren't mistaken for the awaited update. Change-Id: Ie55f0a2f33a0dde5e2c3dd8dd2fb2c82c67a06c4	4 months ago
Bit-Savva Mikhail	46f04ef6af	MT#64955 test-b2b: skip retransmitted B2B INVITEs from previous dialogs ... recvB2BINVITE now tracks the Call-ID of every completed dialog in a class-level set (_stale_b2b_cids) and skips any INVITE whose Call-ID appears in that set. tearDown populates the set from _current_b2b_cid, which recvB2BINVITE sets on each successful return. This closes the narrow race window left by the setUp non-blocking drain: a retransmission that arrives between setUp and the recvB2BINVITE call can no longer poison b2b_cid for the current test, regardless of timing. Change-Id: I206ff35e0c04f80d4bcd12eaa4a7dd56acb08152	4 months ago
Bit-Savva Mikhail	04065d00f6	MT#64955 test-b2b: guard against stale _uas_sock messages on loaded CI ... On a heavily loaded CI host the SIP T1 retransmit timer (500 ms) fires before the test framework processes responses, leaving extra datagrams in the shared _uas_sock that survive tearDown. Additionally, SEMS generates its own Call-ID for B-leg dialogs, so messages from different tests mix on the same socket. Changes: t/sems_tester.py: recvB2BINVITE(): new helper — reads from shared UAS socket skipping any non-INVITE datagrams (stale BYE/ACK from previous tests) recvSIPForCall(sock, b2b_cid): new helper — reads from shared UAS socket discarding messages whose Call-ID doesn't match the current B2B dialog t/test-b2b.py: tearDown: increase drain timeout 0.5 s → 1.5 s (covers up to 3×T1) All recvFromSIP(_uas_sock) INVITE reads replaced with recvB2BINVITE() + b2b_cid = _hdr(…, "Call-ID") All subsequent recvSIP(_uas_sock) reads replaced with recvSIPForCall(_uas_sock, b2b_cid) to discard stale datagrams testInviteRetransmission: "must NOT forward" block filters by Call-ID testEarlyCancelRace / testRtpDirectionHold: BYE/CANCEL acceptance conditions extended with `and b2b_cid in msg` testConcurrentCalls: setup_call() uses recvB2BINVITE + recvSIPForCall, BYE waits keyed on per-call b2b_call_id Change-Id: Id8987d3594c487d8b78c38ed3b9f580544a83693	5 months ago
Bit-Savva Mikhail	954bd66303	MT#64955 add B2B SBC integration test suite ... add B2B SBC integration test suite (port from sems-pbx) Port the 20-test B2B suite from sems-pbx. CE-specific differences: - sip_port=5062 (avoids conflict with orphaned sockets on :5060) - default_bl_ttl=0 in t/b2b.conf (disables destination blacklisting so a 503 response in one test does not block subsequent tests) - no g729 in load_plugins (codec not present in CE) - plugin_config_path requires trailing slash - 100 response matched as "100 [^\r]+" (CE sends "100 Connecting" instead of "100 Trying") sems_tester.py: add makeUACSocket/makeUASSocket, recvSIP, recvFromSIP, sendToSIP, assertSIP helpers; create t/run/ in setUpClass; clean up PID file in tearDownClass; skip testPreload when rtpe-preload.so is not loaded. testEarlyCancelRace: use 10 s socket timeout with inner try/except so the test passes on loaded CI machines where BYE may arrive late. Change-Id: Iecb563dee6a27cf46b9883c42154a4486b3f6429	5 months ago
Guillem Jover	7fc80ae2f2	MT#62763 Fix pycodestyle issues ... - Add pyproject.toml and tox.ini with consistent black and pycodestyle settings. + Fix all errors >= E300. - Place unconditional imports at the beginning of the file. - Do not import more than one module at the same time. - Do not use blackslash at EOL within brackets. - Do not use bare except. - Do not end statement with semicolon. - Do not place multiple statements in the same line. - Use «is» and «is not» instead of «==» and «!=» for None. - Disambiguate short variable name by giving it a better longer name. - Remove trailing whitespace. - Fix expected number of blank lines. Change-Id: I02a29887a1267f5b843822e0ff05b7dca4416554	8 months ago
Richard Fuchs	6245e8d659	MT#62181 fix basic test ... Change-Id: Ia04f434559298493d8183e1965978b6b1a0318d4	1 year ago
Richard Fuchs	c85a2a593c	MT#62181 support valgrind leak check ... Change-Id: I76b48bc232c0c267fc26c428aa601b850d2475a9	1 year ago
Richard Fuchs	adf2332617	MT#62181 support testing under valgrind ... Change-Id: I796fce5508e406cc5e897ae07427929f8c7fddf0	1 year ago
Richard Fuchs	4856e6537f	MT#62181 add testing framework ... Only some very basic tests included for now Change-Id: I84c3c9dc73c23e4b1aa486fd0fa10ea80bea9bb6	1 year ago