9 Commits (master)

Author	SHA1	Message	Date
Donat Zenichev	0bb32831c7	MT#59962 Rework AmMimeBody payload to be string ... Rework the payload to be a string instead of the raw char array. This eliminates cases when we actually need to track that this char array is indeed null-terminated and deprives us from doing other tricks to properly maintain this char array. Also no need to return const of payload anymore, because simply copied during return. Data protection ensured by not giving a reference to the payload, modifiable still during the first time setting this payload. Rework also other users, such as nested call into AmSdp provided `parse()`. Now `parse()` takes a string, and already in a local scope handles a char array copy of this given string. This is only because the `parse_sdp_line_ex()` still requires a refactor to be working with strings instead of char array. Additionally: move parser helpers of AmSdp to const char pointers, instead of working on a plain char pointer. This is because the SDP body parser has been moved from the referenced pointer `char *&` to the `const char *` pointer. This allows to not have additionally heap allocated SDP body C-string for parsing purposes. No functional change. Change-Id: Ic3ee6c349b62e7e5e0cd4de722f9ed923862a7cb	6 months ago
Donat Zenichev	a7a66c7fcb	MT#59962 Rework AmSdp parsing and func users accordingly ... Preamble: no functional changes. AmSdp::parse() mixes int values with bool, what makes the behavior not really clear, not defined and can lead to the unpredicted result (even though the compiler *should* actually fix that, but one ought to not rely on this). Hence make the parse method only be working with bool values. Then, reverse the return value so that it's clear that wrongly parsed is `false`, and good parsed is `true`. Refactor all users accordingly. Also rework those users, who indeed need `int` value be returned, e.g. when having -1. Do the same thing with the `parse_sdp_line_ex()` helper, whereas parse() is the only user of it. And also reverse the interpretation of true/false. Then, make `parse()` working with a plain `char*`, so not a const. Because doing a tricks like: cast `char*` to const (user level) -> cast `const char*` to non-const in a function (in a old C-like manner), has really no sense. Refactor everything accordingly. Other than that, refactor AmMimeBody: Refactor it to work with a plain `char *` pointer instead of working with `unsigned char *`, which nowadays has really no sense and rather is a rudiment of C-like code base coming from the past. Convert `payload` from `unsigned char*` to `char *` accordingly. Refactor everything in AmMimeBody implementation accordingly. Remove rudiment C-like casting everywhere, where possible. Update `parseMultipart()` to work with a plain `const char *` instead of `const unsigned char*` P.S.: leave a list of TODO's for further rework, which is not directly related to this scope of rework. Change-Id: Ie1e132429245e0d2cc740d5b1c1fc17cf037a820	6 months ago
Donat Zenichev	357b2045d6	MT#59962 ModSbc: use move instead of copy for mf ... Instead of copying the FilterEntry mf, do the move. Fixes defect: 329 vector<string> elems = explode(value, ","); 330 for (vector<string>::iterator it=elems.begin(); it != elems.end(); it++) 331 { 332 mf.filter_list.insert(*it); 333 } 334 mf.filter_type = Undefined; >>> CID 550235: Performance inefficiencies (COPY_INSTEAD_OF_MOVE) >>> "mf" is copied and then passed-by-reference as parameter to STL insertion function "std::vector<FilterEntry, std::allocator<FilterEntry> >::push_back( std::vector<FilterEntry, std::allocator<FilterEntry> >::value_type const &)", when it could be moved instead. 335 profile->messagefilter.push_back(mf); 336 DBG("message_list set to '%s'\n", value.c_str()); 337 EXEC_ACTION_STOP; 338 } 339 340 } Change-Id: If6d04432f7004993fb1c70a0a026799805ed2a1a	9 months ago
Donat Zenichev	8211e8ca55	MT#59962 ModSbc: FilterEntry define type before using ... Fixes: CID 542433: (#1 of 1): Uninitialized scalar variable (UNINIT) 34. uninit_use_in_call: Using uninitialized value mf. Field mf.filter_type is uninitialized when calling push_back. Change-Id: Ia5c2c2ebb08f1632f973ef0d08d4dca0c5b8934b	9 months ago
Donat Zenichev	d63305fb82	MT#59962 ModSbc: `profile_param` can be only one ... Don't do an extra job many times checking what is the `profile_param`, just catch this once. Hence conditions must be self-excluding. Change-Id: I6d98a082e50777c995538fd6303eb0fe527b301b	9 months ago
Donat Zenichev	23a917d5ad	MT#57434 invalid suffix on literal; C++11 requires a space ... This commit fixes this: ModSbc.cpp:611:11: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] 611 | ERROR("Could not find "DSM_AVAR_REQUEST" avar for request"); | ^ ModSbc.cpp:616:11: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] 616 | ERROR("Could not find "DSM_AVAR_REQUEST" avar as pointer"); | ^ ModSbc.cpp:622:11: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] 622 | ERROR("Could not find "DSM_AVAR_REQUEST" avar as request"); | ^ ModSbc.cpp:634:11: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] 634 | ERROR("Could not find "DSM_AVAR_REPLY" avar for reply"); | ^ ModSbc.cpp:639:11: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] 639 | ERROR("Could not find "DSM_AVAR_REPLY" avar as pointer"); | ^ ModSbc.cpp:645:11: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] 645 | ERROR("Could not find "DSM_AVAR_REPLY" avar as reply"); | ^ Change-Id: I68fe83180b39c34ec365000208527ddc2eff15d4	3 years ago
Victor Seva	2bf464e5cb	Imported Upstream version 1.6.0~20150612~a2d214df36	11 years ago
Victor Seva	be6b7d527c	Imported Upstream version 1.6.0~20140819~0b6d12	12 years ago
Victor Seva	df9992620d	Imported Upstream version 1.6.0~20140516~eaa616	12 years ago