7 Commits (master)

Author	SHA1	Message	Date
Donat Zenichev	5523520c87	MT#59962 DRedisConnection: handle empty context case ... In case no context allocated, then consider it as a connection error. Change-Id: I35975dbd713ee1757c95acebbe4d07e5cf812e49	9 months ago
Donat Zenichev	8f95edc9c4	MT#59962 DRedisConnection: ensure redis_context isn't NULL ... When dereferencing it (after creating a new context before) make sure it's not NULL even when just checking for a connection error, as it might still be NULL and hence will just seg.fault in this case. Fixes: Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking this->redis_context suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Change-Id: I67f88f1dfccef66751298b1c26e85efba0458c1f	9 months ago
Donat Zenichev	6dfc04d3cc	MT#59962 DRedisConnection: size_t is always >= 0 ... size_t will always be true against `>=` because it's a typedef for unsigned long. Makes no sense to check it, just log what it is. Fixes: Unsigned compared against 0 (NO_EFFECT) unsigned_compare: This greater-than-or-equal-to-zero comparison of an unsigned value is always true. reply->len >= 0UL. Change-Id: I75803cbe0760a1b5c4a0d056af86bc992ea0a110	9 months ago
Donat Zenichev	305d860a36	MT#59962 DRedisConnection: no reply means something went wrong ... Add a default case for `handle_redis_reply()`. Fixes: Dereference after null check (FORWARD_NULL) 4. var_deref_op: Dereferencing null pointer reply. Change-Id: I22edbc3cb14f7e8662efe4c607e1502fbb8c56b6	9 months ago
Donat Zenichev	f0efd813e1	MT#57254 dsm/mod_redis: print ephemeral TCP port (connect/disconnect) ... The hiredis library does not provide a direct way to retrieve the allocated port number. We hav to retrieve the socket file descriptor (redis_context->fd) from the `redisContext` structure and using the `getsockname()` get the local address associated with that socket. Then the `sin_port` field of the resulting `sockaddr_in` structure will contain the allocated ephemeral port. By using `ntohs()`, just convert the port number from network byte order to host byte order for printing. However make an additional on-the-go type casting into the `unsigned int` also, to be able to print. (unsigned int is guaranteed to be at least 16 bits, so this is not a lossy conversion). Change-Id: Id2a8e9ee4fad6f28db099323fb68fd2db0bfafc2	3 years ago
Donat Zenichev	020a164915	MT#57432 field precision specifier '.*' expects argument of type 'int' ... We have to manually cast the `->len` of type `size_t` to the `int` type, when it's used for the printing of logs. Change-Id: I7e116425aecf5ee7e39d8df868edc05b33581014	3 years ago
Victor Seva	2bf464e5cb	Imported Upstream version 1.6.0~20150612~a2d214df36	11 years ago