From b95a9dd5e189e77f8853baf0f5d1ce0f182988b5 Mon Sep 17 00:00:00 2001 From: Richard Fuchs Date: Wed, 7 May 2025 10:29:15 -0400 Subject: [PATCH] MT#62181 trans_layer: fix NULL dereference `tt->_t` is always NULL. Use `p_msg` instead. Change-Id: Id2c9f31cdb1a8f43339119eab97bc9f1bb0d7a65 Warned-by: Coverity --- core/sip/trans_layer.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/core/sip/trans_layer.cpp b/core/sip/trans_layer.cpp index 51a4222c..33c8bea5 100644 --- a/core/sip/trans_layer.cpp +++ b/core/sip/trans_layer.cpp @@ -1310,13 +1310,14 @@ int _trans_layer::send_request(sip_msg* msg, trans_ticket* tt, if(err < 0){ ERROR("Error from transport layer\n"); - delete p_msg; - p_msg = NULL; - if(default_bl_ttl) { - tr_blacklist::instance()->insert(&tt->_t->msg->remote_ip, + tr_blacklist::instance()->insert(&p_msg->remote_ip, default_bl_ttl,"503"); } + + delete p_msg; + p_msg = NULL; + tt->_bucket->unlock(); goto try_next_dest; }