From 659a2e91b2e6d480a10cdfbd88535bf9ecd8d59b Mon Sep 17 00:00:00 2001 From: Donat Zenichev Date: Fri, 14 Mar 2025 10:05:59 +0100 Subject: [PATCH] MT#59962 DSMStateEngine: initialize current_diag to NULL Fixes: Uninitialized pointer field (UNINIT_CTOR) Non-static class member current_diag is not initialized in this constructor nor in any functions that it calls. Change-Id: I80fd5175edb68079e7b7da7a336bcc7f0e882016 --- apps/dsm/DSMStateEngine.cpp | 8 -------- apps/dsm/DSMStateEngine.h | 4 ++-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/apps/dsm/DSMStateEngine.cpp b/apps/dsm/DSMStateEngine.cpp index edbc5f2e..eb10f28f 100644 --- a/apps/dsm/DSMStateEngine.cpp +++ b/apps/dsm/DSMStateEngine.cpp @@ -275,14 +275,6 @@ bool DSMStateDiagram::checkHangupHandled(string& report) { return res; } - -DSMStateEngine::DSMStateEngine() - : current(NULL) { -} - -DSMStateEngine::~DSMStateEngine() { -} - bool DSMStateEngine::onInvite(const AmSipRequest& req, DSMSession* sess) { bool res = true; for (vector::iterator it = diff --git a/apps/dsm/DSMStateEngine.h b/apps/dsm/DSMStateEngine.h index 44194d72..7d9c9a37 100644 --- a/apps/dsm/DSMStateEngine.h +++ b/apps/dsm/DSMStateEngine.h @@ -320,8 +320,8 @@ class DSMStateEngine { vector mods; public: - DSMStateEngine(); - ~DSMStateEngine(); + DSMStateEngine() : current(NULL), current_diag(NULL) {}; + ~DSMStateEngine() {}; void addDiagram(DSMStateDiagram* diag); void addModules(vector modules);