You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Donat Zenichev 011d616431 MT#58636 Fix a defect detected by Coverity Scan ... ** CID 1574844: Null pointer dereferences (FORWARD_NULL) /daemon/call.c: 2416 in codecs_offer() *** CID 1574844: Null pointer dereferences (FORWARD_NULL) /daemon/call.c: 2416 in codecs_offer() 2410 2411 if (update_answerer) { 2412 // update/create answer/receiver side 2413 ilogs(codec, LOG_DEBUG, "Updating offer codecs for answerer " STR_FORMAT " #%u", 2414 STR_FMT(&media->monologue->tag), 2415 media->index); >>> CID 1574844: Null pointer dereferences (FORWARD_NULL) >>> Dereferencing null pointer "flags". 2416 if (flags->static_codecs && media->codecs.codec_prefs.length) 2417 ilogs(codec, LOG_DEBUG, "Leaving answerer codecs alone"); 2418 else if (flags && flags->reuse_codec) 2419 codec_store_populate_reuse(&media->codecs, &sp->codecs, 2420 .merge_cs = &sp->codecs); 2421 else ** CID 1574843: Null pointer dereferences (REVERSE_INULL) /daemon/call.c: 2418 in codecs_offer() *** CID 1574843: Null pointer dereferences (REVERSE_INULL) /daemon/call.c: 2418 in codecs_offer() 2412 // update/create answer/receiver side 2413 ilogs(codec, LOG_DEBUG, "Updating offer codecs for answerer " STR_FORMAT " #%u", 2414 STR_FMT(&media->monologue->tag), 2415 media->index); 2416 if (flags->static_codecs && media->codecs.codec_prefs.length) 2417 ilogs(codec, LOG_DEBUG, "Leaving answerer codecs alone"); >>> CID 1574843: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "flags" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 2418 else if (flags && flags->reuse_codec) 2419 codec_store_populate_reuse(&media->codecs, &sp->codecs, 2420 .merge_cs = &sp->codecs); 2421 else 2422 codec_store_populate(&media->codecs, &sp->codecs, 2423 .allow_asymmetric = !!(flags && flags->allow_asymmetric_codecs), Change-Id: Ife9ad5fdf9481fb74bbc4e7c5ac5a784bb564d4b (cherry picked from commit acd303cd56)		2 years ago
..
.gitignore	MT#56374 move poller to lib/	3 years ago
.ycm_extra_conf.py	MT#54294 update to codec-chain framework	2 years ago
Makefile	MT#54294 update to codec-chain framework	2 years ago
audio_player.c	MT#56471 fix mem leak	3 years ago
bencode.c	MT#55283 Rename aux -> helpers	3 years ago
call.c	MT#58636 Fix a defect detected by Coverity Scan	2 years ago
call_interfaces.c	MT#58636 add new option 'static codecs'	2 years ago
cdr.c	MT#56447 change ml->medias to GPtrArray	3 years ago
cli.c	MT#57977 convert call flags to uint bit field	2 years ago
codec.c	MT#58636 add new option 'static codecs'	2 years ago
control_ng.c	MT#57977 use symmetric UDP	2 years ago
control_tcp.c	MT#55283 switch to pcre2	2 years ago
control_udp.c	MT#57977 use symmetric UDP	2 years ago
cookie_cache.c	MT#55283 Rename aux -> helpers	3 years ago
crypto.c	MT#55283 Rename aux -> helpers	3 years ago
dtls.c	MT#55283 leave SRTP keys in place after DTLS shut	2 years ago
dtmf.c	MT#55283 Allow dtmf injection when also using a delay buffer	2 years ago
graphite.c	MT#56750 Deprecate unused objects of `media_socket.port_pool`	3 years ago
helpers.c	MT#55283 switch to pcre2	2 years ago
homer.c	MT#55283 switch to anonymous unions	2 years ago
ice.c	MT#55283 check DTLS src/dst addressses	2 years ago
iptables.c	MT#55283 switch to anonymous unions	2 years ago
janus.c	MT#57977 fix save/restore of "foreign" call flag	2 years ago
jitter_buffer.c	MT#55283 move declarations to eliminate shadowing	3 years ago
kernel.c	MT#55283 Rename aux -> helpers	3 years ago
load.c	MT#55283 Rename aux -> helpers	3 years ago
log.c	MT#57977 convert call flags to uint bit field	2 years ago
log.h	MT#55283 switch to anonymous unions	2 years ago
log_funcs.h	MT#55283 switch to anonymous unions	2 years ago
loglevels.h	TT#124273 fix typos detected by lintian	4 years ago
main.c	MT#57977 support multiple listen sockets	2 years ago
media_player.c	MT#55283 add missing send_timer locks	2 years ago
media_socket.c	MT#55283 check DTLS src/dst addressses	2 years ago
mqtt.c	MT#55283 move declarations to eliminate shadowing	3 years ago
recording.c	MT#57977 convert call flags to uint bit field	2 years ago
redis.c	MT#55283 fix media array building	2 years ago
rtcp.c	MT#55283 fix possible NULL dereferences	2 years ago
rtp.c	TT#146201 support RTCP encryption in kernel	3 years ago
sdp.c	MT#58441 Declare attrs in `sdp_attribute` separately	2 years ago
ssrc.c	MT#55283 Rename aux -> helpers	3 years ago
statistics.c	MT#57977 convert call flags to uint bit field	2 years ago
stun.c	MT#55283 switch to anonymous unions	2 years ago
t38.c	MT#56374 add convenience macros for string creation	3 years ago
tcp_listener.c	MT#56374 obsolete non-global pollers	3 years ago
timerthread.c	MT#55283 Rename aux -> helpers	3 years ago
udp_listener.c	MT#55283 enable PKTINFO for UDP listeners	2 years ago
websocket.c	MT#57977 use symmetric UDP	2 years ago