commit 26478c1dcfafab68fe29e9828934f0d8672ec3ed
Merge: aeb0b7bcfc265e0b
Author: Richard Fuchs <rfuchs@sipwise.com>
Date: Wed Jun 23 14:45:32 2021 -0400
Merge branch 'el-systemd' of https://github.com/khorsmann/rtpengine into khorsmann-el-systemd
Change-Id: Ide2e93d5baa1ecba97d256a48c53c106c084f9fd
commit fc265e0b3d
Merge: 41a9a8ae1d845c21
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Wed Jun 23 19:25:09 2021 +0200
Merge branch 'sipwise:master' into el-systemd
commit 41a9a8ae6e
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Wed Jun 23 19:22:09 2021 +0200
iptables in ExecStart/ExecStopPost needs root privleges. Correct copy-paste error.
commit 0f991f6666
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Wed Jun 23 17:57:55 2021 +0200
readd User/Group and switch back to forking cause CentOS7 systemd is very old
commit 11290d48b6
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Tue Jun 22 12:18:38 2021 +0200
if ngcp-virt-identify not there should not break the script
commit b7040ad992
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Tue Jun 22 12:05:04 2021 +0200
add iptables helper for el systemd to spec file
commit 6d67dc3b3a
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Tue Jun 22 11:21:34 2021 +0200
* add also ngcp-rtpengine-iptables-setup. So iptables rules will created like the debian packages did that.
closes#1292
Change-Id: I6f31608c70b069b3584ad240b7eda10e59c94e4b
Systemd complains about 755 rights of EL service files.
"systemd[1]: Configuration file /usr/lib/systemd/system/rtpengine.service is marked executable. Please remove executable permission bits. Proceeding anyway."
shellcheck v0.7.1 complains about a bunch of issues:
SC2154: status is referenced but not assigned.
SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
SC2235: Use { ..; } instead of (..) to avoid subshell overhead.
SC2236: Use -n instead of ! -z.
The "$status" variable disappeared in d4763aba14.
The init scripts of ngcp-rtpengine-daemon and
ngcp-rtpengine-recording-daemon had a logic bug, where a failing stop
action didn't properly return, but continued execution of the following
firewalling code (ngcp-rtpengine-iptables-setup). Thanks to Guillem
Gover for spotting this one. While at it, no longer execute under
'set -e'.
Change-Id: Ia50e76f615564a288627e6e42ec8f7eb082de74c
`exit -1` is out of range in shell scripts and returning
with 255, while init scripts are supposed to be exit with `1`
and similar on errors.
We're following
http://refspecs.linuxbase.org/LSB_3.0.0/LSB-PDA/LSB-PDA/iniscrptact.html
and returning with exit code 6 for configuration issues.
Change-Id: I8eda8e059c4ea10b9ddbddd1306627894073b034
Otherwise we might end up with empty "$TABLE", while we're
trying to execute:
echo "del $TABLE" > /proc/rtpengine/control
This will fail with `echo: write error: Invalid argument` error then.
Instead set TABLE by default to '0'. Users can
customize this via /etc/sysconfig/rtpengine,
and the file is sourced after we set the default.
Closes#696
Change-Id: I2f9bb810757507bcc01509ce02676af0d711f515
If you don't need to use transcoding and recording, so you don't need
to install ffmpeg libraries. Just change with_transcoding to 0.
Also some changes according directory name inside tar.gz archive
* warning: cachefile appears unused. Verify it or export it. [SC2034]
* warning: Double quote to prevent globbing and word splitting. [SC2086]
* removed unnecessary space
Change-Id: I71276ca08d1a5599bf1034403d2973ef78d8079e
- Add missing quotes.
- Switch some problematic usages to use bash arrays.
- Override shellcheck errors (these might need fixing in the future).
Change-Id: Id451ff9f4c5d5ef9b3826544908d64e9c08c5797
fix typo and error:
./rtpengine.init: line 111: syntax error in conditional expression
./rtpengine.init: line 111: syntax error near `-a'
./rtpengine.init: line 111: ` if [[ -n "$REDIS" -a -n "$REDIS_DB" ]]'
which is before the conntrack stuff in the INPUT tables. We then create
our temporary rtpengine chain from that.
Also brought in some of the IPv6 stuff from the standard Centos init script
Just a cosmetic actually. Earlier we created user,group anyway and
suppress error message if user or group already exists.
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Fix %post/%preun directives. Because of incorrect service name (%{name} == ngcp-rtpengine, service name == rtpengine) there are errors when install or delete RPM.
Im Moment wurden die sessions ja nach 30 sekunden hardcoded abgeräumt.
Dieser patch macht das konfigurabel.
ersetzt den letzten patch "added_delete_delay_for_memory_cleanup.patch".
Author: Frederic-Philippe Metz <Frederic.Metz@1und1.de>
Ein Commandline interface, wo man von der console and der rtpengine
bestimme Dinge abfragen kann.
Author: Frederic-Philippe Metz <Frederic.Metz@1und1.de>
It's generally considered a good practice to follow the consistent macro naming
scheme. So we shouldn't mix RPM_BUILD_ROOT and buildroot although they have the
same value. At least this helps to avoid confusion for beginners.
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Using /use/share/doc/something isn't a good choice since the entire directory
/usr/share/doc could be empty due to system settings.
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>