29 Commits (ffa048ba5aa32e71491bf71c162115804356ff15)

Author	SHA1	Message	Date
Daniel Donoghue	8ca3f8fc81	MT#55283 add rollback NG message ... Add an opt-in rollback message to the NG protocol. It lets a signalling application undo an SDP offer that rtpengine has applied but the remote endpoint subsequently rejects, without deleting the established call. A client enables checkpointing with track-state on an offer. rtpengine snapshots the affected dialogue before applying it; an answer commits the exchange and discards the snapshot, and rollback restores and consumes it. A dialogue holds at most one outstanding checkpoint, so offers arriving before an exchange completes keep the existing snapshot and a rollback returns to the last completed offer/answer. A checkpoint holds a snapshot in the call record format the Redis encoder already produces, so there is one definition of what a call's state looks like and no second encoder to keep in step. Decoding a snapshot needs the field readers the Redis restore path already had, so those are shared rather than duplicated; json_restore_call() reads the same fields, in the same order, with the same strict-return behaviour. Applying a snapshot copies negotiated state back onto the live objects, matched by unique id. The objects are never recreated, so local sockets and ports survive. State a rejected offer introduced is removed as well as overwritten: a field the encoder writes only when set is absent from a snapshot taken before it existed, and that absence clears it. ICE and DTLS reconverge rather than being rewound, since applying the offer has already reset the agent and shut down the DTLS association. Restoring the accepted credentials and candidates lets connectivity checks rebuild ICE state, and restoring the fingerprint, TLS id and setup permits a fresh handshake. Outstanding checkpoints are stored in the Redis call record so they survive takeover. Checkpoint data is auxiliary: one that cannot be read is discarded in full while the call itself is restored without rollback capability. The preload shims no longer inherit the sanitizer options from CFLAGS. They are loaded by the harness into the test scripts' own interpreter, where a sanitizer runtime crashed the daemon tests on aarch64 during library initialisation. Everything else in CFLAGS, the Debian hardening flags included, still applies to them. The Redis tests no longer assume the record length is four digits, and read the record across as many reads as it takes. Squashed: commit ad49459152 Author: Daniel Donoghue <oneofsomany@hotmail.com> Date: Fri Aug 28 13:33:17 2026 +0200 MT#55283 address review comments Snapshots are now bencode, GLib macros are used throughout, and keys and offsets are built with the existing helpers rather than by hand. New tests cover the snapshot format and the state that exists only inside a snapshot. commit ff47944ad5 Author: Daniel Donoghue <oneofsomany@hotmail.com> Date: Fri Aug 28 15:24:56 2026 +0200 MT#55283 scope snapshots to the dialogue A snapshot now holds only the two monologues being checkpointed, and only the entries the decoder reads: the socket and endpoint map pools, sinks, subscriptions and aliases are left out. The from-tag check in the rollback handler is dropped, since call_get_monologue() is keyed on the tag. commit 3bb19f2804 Author: Daniel Donoghue <oneofsomany@hotmail.com> Date: Mon Aug 31 08:41:08 2026 +0200 MT#55283 give each monologue its own checkpoint The checkpoint moves from a list on the call to a pointer on the monologue, and its snapshot covers only that monologue. Checkpoints are stored in the call record as checkpoint-<monologue id>; num_checkpoints and the offerer and answerer ids are gone. A monologue is shared between the branches of a forked call, so rolling one branch back no longer reinstates what rolling another back had undone. The call-level json dict is no longer written into snapshots, since nothing reads it back. commit 0c986a81e2 Author: Daniel Donoghue <oneofsomany@hotmail.com> Date: Mon Aug 31 10:01:54 2026 +0200 MT#55283 do not report a rollback that did not happen call_merge() renumbers every unique id, and a snapshot is keyed on them, so a checkpoint taken before a merge no longer describes anything. It is dropped with the ids it refers to, and rollback reports none outstanding rather than a success that restored nothing. Both sides of a dialogue are checkpointed together. A monologue is shared between the branches of a forked call, so one side could already hold a checkpoint while the other had never been tracked, leaving a rollback to restore half a dialogue and still report success. Each fix has a test that fails without it. commit dfe7a72aff Author: Daniel Donoghue <oneofsomany@hotmail.com> Date: Mon Aug 31 10:41:50 2026 +0200 MT#55283 document that merging a call drops its checkpoints Merging renumbers the state a snapshot refers to, so an outstanding checkpoint is discarded and a later rollback reports none. Closes #2159 Change-Id: Ie773e2cd4a39fc1c8f39fafe959784e269c0c80e	1 week ago
Richard Fuchs	032bd398b9	MT#55283 combine DTLS= and DTLS-reverse= ... Forcing the DTLS role to passive only makes sense for the backwards (torwards the offerer) direction anyway, as towards the answerer (in an offer) it's not allowed by the RFC, and in an answer it's not possible as the active DTLS connection would already be in progress. Convert DTLS= processing into a list as multiple flags might be required. Change-Id: I54239280460e1bbce1966bc17a384489eb978618 Amends: 78ee0451 / Ib1d07831 Related: #2156 Related: #2145	4 weeks ago
Richard Fuchs	8a62497fc3	MT#65570 support ICE2 flag ... Change-Id: Ie813564d94ada66b79f8b68e6f454de6b849da2c	2 months ago
Richard Fuchs	be90f1b246	MT#65570 allow trickle option in ICE= list ... Change-Id: Ibf842774a51c494b603cd708bd441b1cd1ff7638	2 months ago
Richard Fuchs	1a91c53e4f	MT#65570 allow ICE-lite options in ICE= list ... Change-Id: Ie758a5dacbe5c43fd725a4deb7c388740decdc8c	2 months ago
Richard Fuchs	5a42837cd5	MT#65570 convert ICE= to list ... Change-Id: I202fb4a3350a63b367cac165b7fbe173b9e4e2ac	2 months ago
Richard Fuchs	78ee045188	MT#55283 ignore incorrect use of DTLS=passive ... Change-Id: Ib1d078318fa2263eea27e879a01ca051fb06f8b5	2 months ago
Richard Fuchs	6391c6bf95	MT#65392 add "fast" flag for delete processing ... Change-Id: I16d4cdd9ecc8dbe612eac2ff002283b606f0f082	3 months ago
Donat Zenichev	d1aa03507d	MT#61856 call_flags: drop support of replace `session-connection` ... We indeed already didn't support it, just silently ignored. Now just completely drop support even in flags parsing. In the documentation it was removed already a long while ago. Accordingly update tests and utils. Change-Id: I2de8ad24b77aa5f43270640559bf809ed1c565bc	4 months ago
Donat Zenichev	d651b4cf8f	MT#61856 call_flags: code comment typos ... Just some typos and more correct sentencing. Change-Id: Ib14e0dc97f33be6e418dd163cde39a5a0c0cd01e	4 months ago
Donat Zenichev	98512e0152	MT#61856 call_flags: reorder guards in `ng_sdp_attr_manipulations_iter()` ... First check if the given `command_action` is a dict, and only then allocate manipulation object. Because otherwise it still creates an object, but then if the `command_action` isn't a dict, it just returns. So useless. Hence re-order them. Change-Id: I50bd334d8b945a5dd5177202168ef21cf2915458	4 months ago
Donat Zenichev	a7b24c955c	MT#61856 call_flags: improve styling in `call_ng_flags_prefix()` ... The nested if-statement is correctly written, but visually is fragile. Simple curly braces will prevent anyone in the future introducing a dangling-if style mistake. Change-Id: I3632702390f046c317eac4e5fef76bc7db707081	4 months ago
Donat Zenichev	a5e1a839ba	MT#61856 call_flags: return actual error ... In the list of functions return actual err string. And pass it up to the flags parser, which will return the actual error if given. This also will be used by call-backs. Change-Id: I0d65508afb35763bb0673219d711df22f874b98f	4 months ago
Donat Zenichev	e87cdabf75	MT#61856 call_flags: `call_ng_flags_str_pair_ht()` might return error ... If in the future `call_ng_flags_str_pair_ht()` starts returning an error as string, pass it up to the caller's caller, in this case `call_ng_flags_sdp_attr_helper_subst()`. Change-Id: I59cd988bc30f62c2de159e614a195f8c1182814c	4 months ago
Donat Zenichev	08e8fe7d08	MT#61856 call_flags: log wrong type used in sdp media remove ... As other methods around (e.g. attr manipulations) log in case the wrong type is used, do the same for sdp media removal. Change-Id: I576763c698431637aa5647b955178c3a25485806	4 months ago
Donat Zenichev	89e126af29	MT#61856 call_flags: attr manipulations, return if unsupported ... If the type is wrong, just return. This make it consistent with the rest of attr manipulations helpers around. Change-Id: I4fa8aba6ef8fa382e36b2042e60b51df7ad10494	4 months ago
Donat Zenichev	7102c97120	MT#55283 rtpp flags parsing, use the semi-colon once ... Fixes: *** CID 1671239: Control flow issues (MISSING_BREAK) /daemon/call_flags.c: 1902 in call_ng_main_flags() 1896 case CSH_LOOKUP("rtcp-mux"): 1897 case CSH_LOOKUP("RTCP-mux"): 1898 case CSH_LOOKUP("rtcp mux"): 1899 case CSH_LOOKUP("RTCP mux"): 1900 return call_ng_flags_str_list(parser, value, call_ng_flags_rtcp_mux, out); 1901 case CSH_LOOKUP("rtpp-flags"): >>> CID 1671239: Control flow issues (MISSING_BREAK) >>> The case for value "164" is not terminated by a "break" statement. 1902 case CSH_LOOKUP("rtpp_flags"):; 1903 case CSH_LOOKUP("rtpp flags"):; 1904 /* s - list of rtpp flags */ 1905 out->rtpp_flags = true; 1906 parse_rtpp_flags(&s, out); 1907 break; Change-Id: I1d8c41ad08c5f090fe58ab0b5c03308b9a1155bb	4 months ago
Richard Fuchs	fe09e74acb	MT#55283 support alternative key name ... Change-Id: Ie4674ec7dbdb6a0bd493d4d73979c20238c0ccf8	4 months ago
Richard Fuchs	33e242b250	MT#55283 support blob64 ... Change-Id: I18246c941f96761be5134538d0a7032b24b12e84	4 months ago
Richard Fuchs	4bf3644e1d	MT#55283 add mesh method ... Change-Id: I66aa4cd2e519f707b76b4b1c2004a45c748c5c16	5 months ago
Richard Fuchs	45be1f5212	MT#55283 honour errors returns from parse ... Change-Id: Iabc7477c38e3e7a8c533ea36fa64bf5ef87431d3	5 months ago
Richard Fuchs	7058e2a504	MT#55283 dict_iter can return error message ... Change-Id: I93e4b70e8bece0dc0481454dd2f13035dbf4d7b2	5 months ago
Richard Fuchs	24bf817b3f	MT#55283 allow returning error from list_iter ... Change-Id: I66b28463d794abff91272fc3cb3657ecc21cf492	5 months ago
Richard Fuchs	b91f58292f	MT#55283 allow list iteration to return errors ... Change-Id: Ic394f0fa4af09f2db6526f49d4e5e3fd4fdb04c5	5 months ago
Richard Fuchs	b2554a0be3	MT#55283 move inject flags into struct ... Change-Id: Ib7b42091db3a2d8d20fd04a7d1db38c4f8e3abed	5 months ago
Richard Fuchs	235c47a5a3	MT#55283 reorder case labels ... Change-Id: I24ee8b0bebb75ebe58995dbe9179e16b058184d0	5 months ago
Richard Fuchs	1fc0f1df6b	MT#55283 move cleanup functions ... Change-Id: Ia1e33f3467af641cf5162e512d36d026aaf26536	5 months ago
Richard Fuchs	f40bd1619a	MT#55283 add some alternative spellings ... Change-Id: I892a546e964cdc8493d138ed1b00af4cc0feb8f9	5 months ago
Richard Fuchs	c70c8b44e4	MT#55283 move flags processing to new file ... Change-Id: I9058f18573993f193a61b82d038b2d08af81856c	5 months ago