rtpengine

Author SHA1 Message Date

Author	SHA1	Message	Date
Michael Prokop	9a5e02535c	TT#137760 Fix shellcheck issues Fixes: \| In debian/ngcp-rtpengine-iptables-setup line 15: \| TABLE=$(/usr/libexec/rtpengine/rtpengine-get-table --config-file=$CONFIG_FILE) \| ^----------^ SC2086: Double quote to prevent globbing and word splitting. \| \| In el/rtpengine.init line 36: \| configfile=${CONFIG_FILE-/etc/rtpengine/rtpengine.conf} \| ^--------^ SC2034: configfile appears unused. Verify use (or export if used externally). \| \| In el/rtpengine.init line 38: \| TABLE=$(/usr/libexec/rtpengine/rtpengine-get-table --config-file=$CONFIG_FILE) \| ^----------^ SC2086: Double quote to prevent globbing and word splitting. Those went unnoticed in commit `111b0a769c`, but are failing in github actions with shellcheck v0.7.2. While at it, ensure that /etc/rtpengine/rtpengine.conf is used as fallback, if CONFIG_FILE isn't defined. Change-Id: I1c1948245a907bd6d299b242a9faff960d0608bc	5 years ago
Guillem Jover	111b0a769c	TT#137760 Refactor table fetching into a new helper tool This centralizes the table setting into the respective config files instead of keeping copies all over the place, that can easily get out of sync. Change-Id: I12f3fa172f34861365c31c8d8718b3fae8a9de5b	5 years ago
Karsten Horsmann	82c741d88c	TT#14008 Squashed commit of the following: commit 26478c1dcfafab68fe29e9828934f0d8672ec3ed Merge: `aeb0b7bc` `fc265e0b` Author: Richard Fuchs <rfuchs@sipwise.com> Date: Wed Jun 23 14:45:32 2021 -0400 Merge branch 'el-systemd' of https://github.com/khorsmann/rtpengine into khorsmann-el-systemd Change-Id: Ide2e93d5baa1ecba97d256a48c53c106c084f9fd commit `fc265e0b3d` Merge: `41a9a8ae` `1d845c21` Author: Karsten Horsmann <khorsmann@gmail.com> Date: Wed Jun 23 19:25:09 2021 +0200 Merge branch 'sipwise:master' into el-systemd commit `41a9a8ae6e` Author: Karsten Horsmann <khorsmann@gmail.com> Date: Wed Jun 23 19:22:09 2021 +0200 iptables in ExecStart/ExecStopPost needs root privleges. Correct copy-paste error. commit `0f991f6666` Author: Karsten Horsmann <khorsmann@gmail.com> Date: Wed Jun 23 17:57:55 2021 +0200 readd User/Group and switch back to forking cause CentOS7 systemd is very old commit `11290d48b6` Author: Karsten Horsmann <khorsmann@gmail.com> Date: Tue Jun 22 12:18:38 2021 +0200 if ngcp-virt-identify not there should not break the script commit `b7040ad992` Author: Karsten Horsmann <khorsmann@gmail.com> Date: Tue Jun 22 12:05:04 2021 +0200 add iptables helper for el systemd to spec file commit `6d67dc3b3a` Author: Karsten Horsmann <khorsmann@gmail.com> Date: Tue Jun 22 11:21:34 2021 +0200 * add also ngcp-rtpengine-iptables-setup. So iptables rules will created like the debian packages did that. closes #1292 Change-Id: I6f31608c70b069b3584ad240b7eda10e59c94e4b	5 years ago

Michael Prokop

TT#137760 Fix shellcheck issues

Fixes:

| In debian/ngcp-rtpengine-iptables-setup line 15:
| TABLE=$(/usr/libexec/rtpengine/rtpengine-get-table --config-file=$CONFIG_FILE)
|                                                                  ^----------^ SC2086: Double quote to prevent globbing and word splitting.
|
| In el/rtpengine.init line 36:
| configfile=${CONFIG_FILE-/etc/rtpengine/rtpengine.conf}
| ^--------^ SC2034: configfile appears unused. Verify use (or export if used externally).
|
| In el/rtpengine.init line 38:
| TABLE=$(/usr/libexec/rtpengine/rtpengine-get-table --config-file=$CONFIG_FILE)
|                                                                  ^----------^ SC2086: Double quote to prevent globbing and word splitting.

Those went unnoticed in commit 111b0a769c, but are failing
in github actions with shellcheck v0.7.2.

While at it, ensure that /etc/rtpengine/rtpengine.conf
is used as fallback, if CONFIG_FILE isn't defined.

Change-Id: I1c1948245a907bd6d299b242a9faff960d0608bc

Guillem Jover

111b0a769c

TT#137760 Refactor table fetching into a new helper tool

This centralizes the table setting into the respective config files
instead of keeping copies all over the place, that can easily get out
of sync.

Change-Id: I12f3fa172f34861365c31c8d8718b3fae8a9de5b

Karsten Horsmann

82c741d88c

TT#14008 Squashed commit of the following:

commit 26478c1dcfafab68fe29e9828934f0d8672ec3ed
Merge: aeb0b7bc fc265e0b
Author: Richard Fuchs <rfuchs@sipwise.com>
Date:   Wed Jun 23 14:45:32 2021 -0400

    Merge branch 'el-systemd' of https://github.com/khorsmann/rtpengine into khorsmann-el-systemd

    Change-Id: Ide2e93d5baa1ecba97d256a48c53c106c084f9fd

commit fc265e0b3d
Merge: 41a9a8ae 1d845c21
Author: Karsten Horsmann <khorsmann@gmail.com>
Date:   Wed Jun 23 19:25:09 2021 +0200

    Merge branch 'sipwise:master' into el-systemd

commit 41a9a8ae6e
Author: Karsten Horsmann <khorsmann@gmail.com>
Date:   Wed Jun 23 19:22:09 2021 +0200

    iptables in ExecStart/ExecStopPost needs root privleges. Correct copy-paste error.

commit 0f991f6666
Author: Karsten Horsmann <khorsmann@gmail.com>
Date:   Wed Jun 23 17:57:55 2021 +0200

    readd User/Group and switch back to forking cause CentOS7 systemd is very old

commit 11290d48b6
Author: Karsten Horsmann <khorsmann@gmail.com>
Date:   Tue Jun 22 12:18:38 2021 +0200

    if ngcp-virt-identify not there should not break the script

commit b7040ad992
Author: Karsten Horsmann <khorsmann@gmail.com>
Date:   Tue Jun 22 12:05:04 2021 +0200

    add iptables helper for el systemd to spec file

commit 6d67dc3b3a
Author: Karsten Horsmann <khorsmann@gmail.com>
Date:   Tue Jun 22 11:21:34 2021 +0200

    * add also ngcp-rtpengine-iptables-setup. So iptables rules will created like the debian packages did that.

closes #1292

Change-Id: I6f31608c70b069b3584ad240b7eda10e59c94e4b

3 Commits (fca62fb2eebbff71a71b4f748825c7f3569a5daf)