491 Commits (f5852c78dc214720c58a669a03fb3df0930068e8)

Author	SHA1	Message	Date
Richard Fuchs	1925ab925f	MT#55283 use obj_release ... Change-Id: I06434bb580d30025ab793f9eb0e8622577103f16	9 months ago
Richard Fuchs	82f5158775	MT#63317 add sink_handler_set_generic ... Change-Id: Ibef8d6a6b3c868c2b4f844c3bf1e095be23cae30	9 months ago
Richard Fuchs	acb0e47a1a	MT#63317 rename determine_sink_handler ... and annotate some functions Change-Id: I26cfe17f9bb93c1cc87b8365b3eed10fc03956f4	9 months ago
Richard Fuchs	64d3c7646c	MT#63317 parse out RTP header extensions ... Stub function for now. Change-Id: I7ad2a203f42fb118e50273a57772cac4fbd1738f	9 months ago
Richard Fuchs	c525cb9e09	MT#63317 remove duplicate header parsing ... Pass down RTP/RTCP header to crypto functions so that they don't need to parse it out again. Change-Id: I551ab6a668cc99c903cde8807f6f9c10fc0cf6d5	9 months ago
Richard Fuchs	2f52fb2511	MT#63317 return RTP extensions from rtp_payload ... Change-Id: If7451e3d32ba39cab40f6f09488cd75ccbefa1cc	9 months ago
Richard Fuchs	8795e92fab	MT#63317 refactor RTP parsing code ... Split up demuxing, parsing, stats, and the setting of ingress and egress streams. Change-Id: I1ed736024b3df8c3f24b68dc9bb8ef3e886712be	9 months ago
Richard Fuchs	eddff91357	MT#63317 annotate rtcp_payload ... Change-Id: I2a08441c0c7e262d3d7a43e8fabc0a5766de7c7f	9 months ago
Richard Fuchs	3540a8334f	MT#63317 annotate rtp_payload ... Change-Id: Ib8ba5e2002c75ec711c2f8e04b4e98b9a5fc8e0a	9 months ago
Richard Fuchs	529a701f49	MT#55283 use an intrusive list for ports release ... Save some allocations Change-Id: Ie78e370168a038fccfa2ee33258f674792fc178c	10 months ago
Richard Fuchs	b85e007ff1	MT#55283 add extra dtls_connection_cleanup ... To release any references early Change-Id: Ib4417301e4f02fbc7d9f4d77d78cb827bb481726	10 months ago
Richard Fuchs	7cf0b86240	MT#55283 move kernelize_state into scope ... That gives us the benefit of not needing the manual cleanup. Change-Id: Ia5681d0bcb60c887a4174adddd5076eb324105bf	10 months ago
Richard Fuchs	08239c9510	MT#55283 clarify _destroy_ptr ... Change-Id: Ib453648d21e907bffd7120a9c9b50275f7bf0846	10 months ago
Richard Fuchs	e03f814855	MT#55283 combine in/out_lock ... With selected_sfd being protected by in_lock, we pretty much have to hold at least in_lock everywhere, and end up requiring both locks in many places. The distinction has become pointless. Change-Id: Ic0ad976c2d68d9639b9434da7f0e6e9c0d84c185	10 months ago
John Burke	afce798034	MT#55283 early exit heuristic endpoint learning if endpoint matches SDP ... Closes #1987 Change-Id: I906a8b1538d75356ea1b0f43d9b0ff5b37dbda52	10 months ago
Orgad Shaneh	fa7b4667d0	MT#55283 respect pause recording command ... The command was accepted, but recording continued as usual. Closes #1981 Change-Id: I994a9ebf75bc2d0d0ce5c601c29843c4bc0e9d0d	11 months ago
Richard Fuchs	052f16da56	MT#55283 allow allocation of out-of-pool ports ... Different instances of rtpengine may be configured with different port ranges. If HA requests usage of a port not part of our pool, allow it. Change-Id: Ib4ace6c4facac35ea44948720fa46bcbdaf441d3	11 months ago
Richard Fuchs	589bf0b22d	MT#55283 split up reserve_port ... Use different function to get a port from a pool and return it, and reserve a port in a pool permanently during startup. Change-Id: I030dc2ebbe30c9b47252669717f235177f15219d	11 months ago
Richard Fuchs	215500bf4a	MT#55283 add port_is_in_range helper ... Change-Id: I65ff5f7efdb67ce4db447d3c4cfdc4ccd3613143	11 months ago
Richard Fuchs	3118b1e258	MT#55283 update function to bool ... Change-Id: I290fc3b803db4ac0b5d95ef9609c158dff303af5	11 months ago
Richard Fuchs	ffc539c0d8	MT#55283 locking updates ... Protect selected_sfd with in_lock. Protect RTCP sending with in_lock and out_lock as appropriate. Has the odd side effect of RTCP reports expected in tests to be sent one packet later than before. Closes #1966 Probably fixes #1927 Change-Id: I225b43dff8e8fbb938d3be6aad50249997615d77	11 months ago
Richard Fuchs	1b077c300a	MT#55283 use auto lock in a few more places ... Change-Id: Ibf34fa6e8cdcbf122e548475ba086101a6757a66	11 months ago
Richard Fuchs	a2c9d5c7a1	MT#55283 add media PUBLIC flag ... A simple mechanism to track whether a given media endpoint has been advertised to the public. If it hasn't, then any media received on it is considered suspicious, and source addresses are ignored for learning purposes. Change-Id: I76a08e3f442f263dad192ff496a5d734a9349d26	1 year ago
Richard Fuchs	dd8450518c	MT#55283 fix log message format ... Change-Id: Ib294200c9a55f59f60c9add9096fa0476d188707	1 year ago
Richard Fuchs	21b0df222c	MT#55283 update asymmetric handling ... Better distinction between endpoint-learning=off and asymmetric mode Change-Id: I100d0d0476b312ddfee21d09a4e5c79f2e18ed60	1 year ago
Richard Fuchs	5132e74a41	MT#62735 honour strict-source during learning ... Change-Id: Ic4eb9ebf20020bfea1840102e542d3ec5b9adcf2	1 year ago
Richard Fuchs	1a382b9a3b	MT#55283 use endpoint_print_buf ... Change-Id: If688e85a3a51ebcd80a7c42d7b77f75413855954	1 year ago
Richard Fuchs	8a1b420af3	MT#62735 add `recrypt` flag ... Change-Id: Ia2779bf51c155df473e523d30bd018ce54bea900	1 year ago
Richard Fuchs	88cb8abf51	MT#62735 pull up SRTP decryption ... Decrypt SRTP (and possibly discard packet) first, before doing source address checking/learning. Change-Id: I2a2cdd94768e93d58e0cdd4614b8ac53ea680724	1 year ago
Richard Fuchs	9068638a4d	MT#62735 fix heuristic learning mode ... Change-Id: I2bfd09eefaf6a13f1c7435efa2e07c9ccecfa964	1 year ago
Richard Fuchs	c8dd521e33	MT#55283 obsolete SSRC tracking ... Change-Id: Ic0a3c7826180e1e1f4a783dcc6d775c92fe38d1f	1 year ago
Richard Fuchs	cf22d82932	MT#55283 eliminate input/output combination SSRC ... Change-Id: I94636b7f6fb6fb31cd3bf332fffe0203e17f6c16	1 year ago
Richard Fuchs	19af8034a4	MT#55283 split SSRC hash into in and out ... Change-Id: Ie1d378ee455e6fadb39a16f4c1d86f604870c536	1 year ago
Richard Fuchs	ad65c9096f	MT#55283 convert call structs to int64_t ... Change-Id: If1a077d206d96914651b3e4624e7fc09f239ed09	1 year ago
Richard Fuchs	952429aa89	MT#55283 convert last_packet to int64_t ... Change-Id: I21aec3c852a213c433b3a6c62d8b039303ec0f01	1 year ago
Richard Fuchs	e92f260e7a	MT#55283 convert daemon/ to int64_t ... Change-Id: Ie557204821fddfa5af0be96cc8f0ff2dd093fc7c	1 year ago
Richard Fuchs	165c42fb8e	MT#55283 convert calls to int64_t ... Change-Id: I7c9a2229ba3eea418e009bb04def336476d2ec25	1 year ago
Richard Fuchs	f34786dade	MT#55283 convert media_packet to int64_t ... Change-Id: I4b1da113cf01d34473027987d4ee60215655fdec	1 year ago
Richard Fuchs	c70510303a	MT#55283 convert rtpe_now to int64_t ... First step in converting (almost) all timeval uses to int64_t Change-Id: If20fd749c61c278273c535b68287df7e6f042808	1 year ago
Richard Fuchs	238dc9d5be	MT#55283 integrate ssrc_hash into upper objects ... Change-Id: Ib8f78ef6bc3028fc342fe07253ebe628af322e55	1 year ago
Richard Fuchs	954bac923b	MT#55283 move SSRC hash from monologue to media ... Change-Id: Id03603982692e9f6aef3b96d2a04514459eb30a7	1 year ago
Richard Fuchs	9f9aaa5332	MT#55283 remove unused argument ... Change-Id: I79893f756c89cfec65b56b927b98c0c818ed2d98	1 year ago
Richard Fuchs	0b61f4f067	MT#55283 use embedded list link ... Avoids repeated calls to allocator Change-Id: Ibbf1324996e723dc36639885de0916a9ad82e367	1 year ago
Richard Fuchs	4d8156bf91	MT#55283 remove remnants of g_slice ... The GLib slice allocator has been obsoleted. Having a mixture of two allocators can lead to hidden issues on systems that use different implementations. Take the leap and replace everything with g_new/g_free. Change-Id: I025c8383ef47b2c2472573360407fd6a6ca339b3	1 year ago
Richard Fuchs	78d7d93acd	MT#55283 fix array indexing ... Entries can be removed within the loop Change-Id: I173849591edd36ee3eac50087a5768966af98000	1 year ago
Richard Fuchs	ab3113bff7	MT#61625 support "blackhole" codec handler ... Special codec handler to support not forwarding (nor any processing whatsoever) of particular payload types at all. Support this in the kernel module as well. Change-Id: If10227affa54307e1e9b448eadd0bf2bfc5774ba	1 year ago
Richard Fuchs	ee707993f4	MT#61625 restrict decision to codec handler ... Only use the codec handler's "kernelize" flag to determine whether a particular payload type can be handled by the kernel or not. It's supposed to be a reliable indicator, making checking the other flags unnecessary. Change-Id: I5fe58eded55ea973ed555e4376ee8200f112d162	1 year ago
Richard Fuchs	a47d848bee	MT#55283 streamline kernelize function ... Further separate out logic that relates to ingress from egress Change-Id: Ifde5bbb5d306b3fdbdbc8cf4d358217b0582f3b6	1 year ago
Richard Fuchs	ef2e31b69d	MT#55283 split up kernelize_one ... Split function into one part handling the "target" (i.e. ingress) portion of the forwarding chain, and one function handling just the outputs. Change-Id: I3766da3c4bc5caee4eb6bae8978f177a83cc231a	1 year ago
Richard Fuchs	490b5af6f5	MT#55283 use typed GQueue for r*_destination_info ... Also switch allocator to g_new/g_free as the slice allocator is obsolete. Change-Id: I2f243d8b24aa8a79dc9d6131a34969313067d05f	1 year ago
Richard Fuchs	d68688540e	MT#55283 introduce kernelize_state struct ... First step to refactoring the kernelize* functions. Keep all state in a central struct that is passed to all functions. Requires an auxiliary bool to facilitate a case distinction in kernelize_one, which can be removed once refactoring is complete. Change-Id: I5de8404d55d5b320ef5cb8cd27d5b684802fa7e7	1 year ago
Richard Fuchs	605b497108	MT#55283 unconditionally demux RTCP ... This seems to be an acceptable and reliable way to detect RTCP multiplexed with RTP, even if `a=rtcp-mux` wasn't advertised in the SDP. Take the opportunity to clean up __streams_set_sinks() a bit by giving the variables better names. Change-Id: I0cdc5e4a544641591fc2aabca12fb11bab3453f7	1 year ago
Richard Fuchs	798904edeb	MT#55283 use _ht_destroy_ptr in a few more places ... Change-Id: I98e088e5f6fe23532ca06a0592e73dac3b3024c3	1 year ago
Richard Fuchs	4a03cbd996	MT#55283 fix g_ptr_array_sort usage ... The compare function receives pointers to pointers as arguments. Change-Id: I93abaa635f94207de826deb6523d8c847bef0860	1 year ago
Richard Fuchs	1ad61d90bb	MT#55283 split up __get_consecutive_ports ... Separate out the two distinct use cases of requesting a specific port, and requesting (one or more) random ports. Change-Id: Ifbe7725d8638d49f620c9f4b9445342d180c8770	1 year ago
Richard Fuchs	de8bc15ea7	MT#55283 split out socket open logic ... Change-Id: I7fc0784fec800008c91a87e227f5f69d182a9e1e	1 year ago
Richard Fuchs	7a4675c776	MT#55283 add helpers for reserve_port ... Add helper functions wrapping around reserve_port which directly return a socket_port_link object. This allows us to rework __get_consecutive_ports and release_reserved_port to eliminate mixing different port numbers in the same list, which makes for cleaner code. Change-Id: Ia9808f71c854f6efd0e93ce8df4527c4aea311bd	1 year ago
Richard Fuchs	923fecd242	MT#55283 split up reserve_port ... Change-Id: I194f9661c890a3fe4f4814fc84c747baa2ba0f11	1 year ago
Richard Fuchs	806d272f89	MT#55283 use bool for get_consecutive_ports ... Change-Id: Ic4bfcaf2fe64874c5b108dda2c774bc7a46cd212	1 year ago
Richard Fuchs	084982735d	MT#55283 fix missing PT processing ... Turns out that g_ptr_array_new_full or g_ptr_array_new_sized only preallocates array members, but doesn't set the length. Change-Id: I722e29a13c415f2a5ff62830dce60205f273b445	1 year ago
Richard Fuchs	0da49000ba	MT#61404 always update egress RTP index ... Add a simple function that acts as an encryption callback to just update the ext_seq (index) of the egress SSRC context. The kernel module already does this, but the daemon only did it when SRTP was involved. This now tracks egress packet indexes in all cases. Change-Id: I9460744de55ead4b05aceb322fd8482442ff2b41	1 year ago
Richard Fuchs	a19bed611c	MT#61404 remove unused RTP/non-RTP distinction ... Change-Id: Ia43e1eb373c893df6693032a14eb631f16593094	1 year ago
Richard Fuchs	eeeb2d8641	MT#55283 move socket_port_link into stream_fd ... This allows us to simplify some function signatures Change-Id: I58f65735ba84ec7a536b1b170d1ef90e266308f5	1 year ago
Richard Fuchs	08e382540e	MT#55283 add link to port_pool in socket_port_link ... Change-Id: I43400175271b089a368f731bd55acb05ccab7141	1 year ago
Richard Fuchs	c99a4691b4	MT#55283 use GPOINTER_TO_UINT ... Change-Id: I5e8ee279aa193c1b7f71a01c42fa3482856b9b30	1 year ago
Richard Fuchs	4c9343b8c6	MT#55283 used typed hash table for rtp_stats ... Change-Id: I015a931d7e726815d2a7d06fa4d74a1418dfec0b	1 year ago
Richard Fuchs	7599e5c375	MT#55283 convert close_socket to bool ... Change-Id: I290012391ba1fa2c6c550614e054181de6e0b94e	1 year ago
Richard Fuchs	c2ba54e615	MT#55283 convert open_socket to bool ... Change-Id: I715afc937f6b1cbc124ff14a0428f781f58cd050	1 year ago
Richard Fuchs	416ca38d25	MT#55283 allow overlapping port ranges ... Change-Id: I6df35b8cc0687567d7c3c0fd6d44979345dca364	1 year ago
Richard Fuchs	1b7077152f	MT#55283 change reserve_port semantics ... Change-Id: I162fbf8f167b1c47e060128dcb4f8773c8fbf3a7	1 year ago
Richard Fuchs	3c6108e072	MT#55283 move mutex locking into function ... Change-Id: Ie01aa986887f2d0e709aae725b0a50ca833d84b6	1 year ago
Richard Fuchs	347c21fc7e	MT#55283 use typed GQueue ... Change-Id: Iea5a5e988ea23a17a5b2da5f02cd972afae2db87	1 year ago
Richard Fuchs	9d93762053	MT#62053 add exclude-ports option ... Change-Id: Ibf319f5ae00e120490610c695a326f5397412155	1 year ago
Richard Fuchs	aec1a0940c	MT#62053 add safeguard against broken port ranges ... Change-Id: I5e4fa46b5d75253129e887da8ddbba4fc60702f5	1 year ago
Richard Fuchs	2d8f5616e4	MT#62053 exclude ports only from applicable interface ... Change-Id: I9daf5fee91007e025b526e197191d98bdb54cc06	1 year ago
Richard Fuchs	6276b37cd2	MT#55283 use list pointer ops for port pool ... Avoid repeated calls to the memory allocated for port pool list management by picking out the list elements without freeing them, storing them in the stream_fd object, and then returning them to the list when the port is released. Change-Id: I67cd5039e62e4d2965e85d7ba7f0454f08f40494	1 year ago
Richard Fuchs	b9972e481e	MT#55283 use bool type ... Change-Id: I75aa1a4091ecc91d4937dfc0bdceb18551a9c879	1 year ago
Richard Fuchs	8e9afe626b	MT#55283 (some) type safety for ports free list ... Change-Id: I79e47f9e6dbfa29c738f75efd2c3d3322e4cb6e1	1 year ago
Richard Fuchs	4e53f06fe6	MT#55283 directly pass port_pool to functions ... Change-Id: Ifd68dc1b5bd53f4d5e9b74883f84104a02e86c18	1 year ago
Richard Fuchs	3fd2586d31	MT#55283 save some memory by using an offset ... Change-Id: Ic53fd60bc2780d0890905c14acfbc39d8cf89861	1 year ago
Richard Fuchs	267d244cb4	MT#55283 use array instead of hash table ... Change-Id: Ie510523724d14d8c76bb9647ee184ea3756be06c	1 year ago
Richard Fuchs	4279ed6750	MT#55283 fix for older compilers ... Change-Id: I05e8d3bd5c4b9608f4896aecab189c8c344fb139	1 year ago
Richard Fuchs	28802073fe	MT#55283 use typed objects for interfaces ... Change-Id: I57aaf64dbf1bb51e8ea9616ae483b14f470e9751	1 year ago
Richard Fuchs	ad6fb06b13	MT#55283 type safety for uid_alloc ... Change-Id: I4b5975d22f2713b66edba128f0749461578f9cde	1 year ago
Richard Fuchs	3ea365ef60	MT#55283 use typed hash table for rr_spec ... Change-Id: I99a4c334e182e5cb568cd8241b4f81340066dee2	1 year ago
Richard Fuchs	02bccee56b	MT#55283 use typed queue for local_intf ... Change-Id: Id7bf3804ab029bdf60d010b05e057bb7851645cd	1 year ago
Richard Fuchs	15fa36df30	MT#55283 use link manipulation ... Change-Id: Ib5c6984f100ac589b51f668737d5b72f6cd8d394	1 year ago
Richard Fuchs	964d6b0b8c	MT#55283 use typed queue for logical_intf ... Change-Id: I16fb597d6a30e7b4396493fa31f29a346db84e7c	1 year ago
Richard Fuchs	5b7bc82bbb	MT#55283 warn about mismatched port ranges ... Change-Id: I229056084844702e88867f4c9a17fe3b311d1036	1 year ago
Richard Fuchs	ad8ce3541d	MT#61822 add RWLOCK_STATIC_INIT ... Change-Id: I6718df967b70554a32c3caddcb4e29af4fb6d7f0	1 year ago
Richard Fuchs	2ce79f9bb4	MT#61822 add type safety to obj_alloc ... Make the macro return the appropriate pointer type, and make sure the free function takes an argument of the same type. This also eliminates some boilerplate type-casting code. Change-Id: I3094271fa2c53ec93b9ff9f837d461cf422e0f12	1 year ago
Peter Pulham	8e04c44b86	MT#55283 media_socket.c: check for NULL payload_types passed to kernelize_one ... under normal circumstances, the rtp sink enters this function first and updates the reti->local.family var to AF_INET so that when the function is called for an rtcp sink, it exits the function early. However, if media is being blocked the rtcp sink is the first to enter the function and does so with a NULL payload type. this NULL check is therefore required to prevent a sefgault on the call to `assert`. closes #1876 Change-Id: Id95cbbc9ae388f50dd51417c351f4a9ba09eb5f0	2 years ago
Richard Fuchs	38985b96df	MT#55283 always use full-struct initialisation ... Avoids uninitialised values. Closes #1873 Identified by Alexandru Pirvulescu <alex@tcnbroadcasting.com> Change-Id: Ie7019c2f762b6f163d6d27c519513f6898e1571c Ref: https://github.com/sipwise/rtpengine/pull/1873 Thanks: Alexandru Pirvulescu <alex@tcnbroadcasting.com>	2 years ago
Richard Fuchs	f60ee917c9	MT#55283 unify types used for sequence numbers ... We use int or unsigned int everywhere, except in a few leftover places. Unify to (unsigned) int. Change-Id: I0896b2f177957c17b30a3d0cb6b3fb2beb4bd684	2 years ago
Richard Fuchs	201c15489c	MT#55283 initialise str objects with macros ... Use provided macros for initrialise str objects everywhere instead of manually setting .s and .len. This allows for flexibility to extend str objects. Change-Id: I5ebca0bc82b348301c2c8e94b974c7acbf249b82	2 years ago
Richard Fuchs	7b1557cc1e	MT#55283 rekernelize after DTLS connect ... Change-Id: I468b6c07df96111ee49a85e36382a692dbeec82b	2 years ago
Richard Fuchs	a0b705eef9	MT#55283 trigger rekernel for SSRC-less streams ... If a stream has been pushed to the kernel from anything other than RTP, even though RTP is expected, we get a forwarding entries without any SSRCs. This is valid, but once actual RTP is received, it needs to be passed on to user space, so that SSRC contexts can be set up. Possible fix for #1855 Change-Id: I51b82d3cf79cf66780fdde154bebe56e0f43174b	2 years ago
Richard Fuchs	a2ee38ac44	MT#55283 rename STR_CONST_INIT... ... ... to STR_CONST...() for consistency no-op Change-Id: I68da3d1a80b9d6db69adba1091e58cc4909305ca	2 years ago
Richard Fuchs	a2059a2449	MT#55283 modernise STR_INIT_LEN() et al ... Obsolete str_init_len() and replace with macro. Rename STR_INIT_LEN() to just STR_LEN() no-op Change-Id: I09dc91dedd57a5b5ca791be4e6f158aecbf339ed	2 years ago
Richard Fuchs	a008e27a45	MT#55283 support interface aliases ... Change-Id: Ifd85bc49201bab1ab89a8d240ee682a6d1655868	2 years ago