rtpengine

Commit Graph

Author	SHA1	Message	Date
Michael Prokop	6515067836	MT#56190 Adjust init scripts for shellcheck v0.9.0 Fix SC2086 issues ("Double quote to prevent globbing and word splitting", see https://www.shellcheck.net/wiki/SC2086) in debian/ngcp-rtpengine-daemon.init and debian/ngcp-rtpengine-recording-daemon.init, as reported by new shellcheck version 0.9.0 (see https://github.com/koalaman/shellcheck/blob/master/CHANGELOG.md). Change-Id: I97fe61d70dfddc420b8d0a7a9299a63b7a3061d7	2 years ago
Guillem Jover	51c71f0035	TT#137760 Remove RUN_RTPENGINE* variables If the user wants to disable the sysvinit service they should use update-rc.d disable instead. Change-Id: Ibbd4ba374d310fea9fcd906d79ef224cbef15b74	4 years ago
Michael Prokop	0bf07827df	TT#82051 Shellcheck fixes + fix failure handling of init scripts shellcheck v0.7.1 complains about a bunch of issues: SC2154: status is referenced but not assigned. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2235: Use { ..; } instead of (..) to avoid subshell overhead. SC2236: Use -n instead of ! -z. The "$status" variable disappeared in `d4763aba14`. The init scripts of ngcp-rtpengine-daemon and ngcp-rtpengine-recording-daemon had a logic bug, where a failing stop action didn't properly return, but continued execution of the following firewalling code (ngcp-rtpengine-iptables-setup). Thanks to Guillem Gover for spotting this one. While at it, no longer execute under 'set -e'. Change-Id: Ia50e76f615564a288627e6e42ec8f7eb082de74c	5 years ago
Guillem Jover	96d62c79b3	TT#49106 Switch from /var/run to the modern /run Change-Id: I612a90a0c7fc39156a486085f0026c31d333d88c Warned-by: lintian	7 years ago
Guillem Jover	9b3226f42e	TT#49106 Do not use absolute paths for commands This makes it difficult to interpose local scripts to override local behavior, for testing purposes for example. Warned-by: lintian Change-Id: I5e1feda02a26f482728f5404496c5870ec93d8aa	7 years ago
Guillem Jover	d4763aba14	TT#36351 Use modern ngcp-check-active Change-Id: I88da19e2d474071f34ea7b23da9a60daf4fd2cbf	7 years ago
Guillem Jover	79807a9c2e	TT#26264 Use better systemd native units While still not the ideal implementation, this is certainly better than the sysvinit script wrapper. We then will "only" need to move the setup scripts into proper service files later on. Change-Id: I990d6847117a4b91a8365a5e307fd96cf5b1899f	7 years ago
Guillem Jover	2ebe76d535	TT#33306 Add dependencies on $network and $local_fs to init scripts These daemons require these facilities to be setup. Previously this was implied and shadowed by the sshd dependency, but once removed the implicit dependencies disappeared, make them explicit now. Change-Id: I13b9b797da0d69636c0f87d92d80a9af46c0726c	7 years ago
Alexander Lutay	86dcf34aa0	TT#33276 Remove sysv init script dependency on sshd It is not necessary with systemd (all services start in parallel). Change-Id: Id2c0976a3cf65cfafc8b9a41f44d78dd3e271af1	7 years ago
Guillem Jover	708231858f	TT#26513 Pass --retry=5 to start-stop-daemon and avoid sleeping Change-Id: I8221d1b48b9d3d76f1421f47f6dc02c509b4d7bb	8 years ago
Guillem Jover	0d3e69387c	TT#26513 Improve sysvinit output messages Change-Id: I57162bba42a84a99cd47fe94abdd92b33436c286	8 years ago
Guillem Jover	a456e201cf	TT#26513 Remove unused modprobe variables Change-Id: Ic52f2e4fc4bca1f76d67178be9d553b0321a8160	8 years ago
Guillem Jover	53b3c36939	TT#24097 Fix shell quoting - Add missing quotes. - Switch some problematic usages to use bash arrays. - Override shellcheck errors (these might need fixing in the future). Change-Id: Id451ff9f4c5d5ef9b3826544908d64e9c08c5797	8 years ago
Guillem Jover	376df64d80	TT#24097 Use «grep -E» instead of deprecated egrep Change-Id: Ia4d51ece3aba31777f62c92897d4e7c207e6d07c	8 years ago
Guillem Jover	747661ff0d	TT#24097 Do not use bash builtin names in sh scripts Even though this is a false-positive, it confuses checkbashisms. So let's rename the variables to something else, even more descriptive, to avoid the check error. Change-Id: Ife79bf76121bb4e3c120525ffe5a0eca871936f6	8 years ago
Guillem Jover	33518213c0	TT#24097 Remove unused shell variables Change-Id: I529a493b2c8d3573d1b848c3fffa951bb8fc60c9	8 years ago
Richard Fuchs	305fbeddee	TT#12789 add defaults file item for NFS mount options Change-Id: I9ab9d6883c7452de442c8921997ee3f0c33ade1d	8 years ago
Richard Fuchs	76ba5872fd	TT#13000 add init.d setuid/setgid capability refuse startup when pid file cannot be written Change-Id: I755dd6fef6cf468b1f96608ab8f804c4c5144ace	8 years ago
Richard Fuchs	8b18bc5d23	TT#10155 split recording daemon into separate debian package Change-Id: Iadbc629b8aa9e241fee3348bd957b4e0d4057fce	8 years ago

19 Commits (e234e11c98e5d91a1ae204096b255c799ce2e15c)