22 Commits (ddbf1d4c8637e163b55ee62c8363ac5d4dfdcfd2)

Author	SHA1	Message	Date
Daniel Donoghue	8ca3f8fc81	MT#55283 add rollback NG message ... Add an opt-in rollback message to the NG protocol. It lets a signalling application undo an SDP offer that rtpengine has applied but the remote endpoint subsequently rejects, without deleting the established call. A client enables checkpointing with track-state on an offer. rtpengine snapshots the affected dialogue before applying it; an answer commits the exchange and discards the snapshot, and rollback restores and consumes it. A dialogue holds at most one outstanding checkpoint, so offers arriving before an exchange completes keep the existing snapshot and a rollback returns to the last completed offer/answer. A checkpoint holds a snapshot in the call record format the Redis encoder already produces, so there is one definition of what a call's state looks like and no second encoder to keep in step. Decoding a snapshot needs the field readers the Redis restore path already had, so those are shared rather than duplicated; json_restore_call() reads the same fields, in the same order, with the same strict-return behaviour. Applying a snapshot copies negotiated state back onto the live objects, matched by unique id. The objects are never recreated, so local sockets and ports survive. State a rejected offer introduced is removed as well as overwritten: a field the encoder writes only when set is absent from a snapshot taken before it existed, and that absence clears it. ICE and DTLS reconverge rather than being rewound, since applying the offer has already reset the agent and shut down the DTLS association. Restoring the accepted credentials and candidates lets connectivity checks rebuild ICE state, and restoring the fingerprint, TLS id and setup permits a fresh handshake. Outstanding checkpoints are stored in the Redis call record so they survive takeover. Checkpoint data is auxiliary: one that cannot be read is discarded in full while the call itself is restored without rollback capability. The preload shims no longer inherit the sanitizer options from CFLAGS. They are loaded by the harness into the test scripts' own interpreter, where a sanitizer runtime crashed the daemon tests on aarch64 during library initialisation. Everything else in CFLAGS, the Debian hardening flags included, still applies to them. The Redis tests no longer assume the record length is four digits, and read the record across as many reads as it takes. Squashed: commit ad49459152 Author: Daniel Donoghue <oneofsomany@hotmail.com> Date: Fri Aug 28 13:33:17 2026 +0200 MT#55283 address review comments Snapshots are now bencode, GLib macros are used throughout, and keys and offsets are built with the existing helpers rather than by hand. New tests cover the snapshot format and the state that exists only inside a snapshot. commit ff47944ad5 Author: Daniel Donoghue <oneofsomany@hotmail.com> Date: Fri Aug 28 15:24:56 2026 +0200 MT#55283 scope snapshots to the dialogue A snapshot now holds only the two monologues being checkpointed, and only the entries the decoder reads: the socket and endpoint map pools, sinks, subscriptions and aliases are left out. The from-tag check in the rollback handler is dropped, since call_get_monologue() is keyed on the tag. commit 3bb19f2804 Author: Daniel Donoghue <oneofsomany@hotmail.com> Date: Mon Aug 31 08:41:08 2026 +0200 MT#55283 give each monologue its own checkpoint The checkpoint moves from a list on the call to a pointer on the monologue, and its snapshot covers only that monologue. Checkpoints are stored in the call record as checkpoint-<monologue id>; num_checkpoints and the offerer and answerer ids are gone. A monologue is shared between the branches of a forked call, so rolling one branch back no longer reinstates what rolling another back had undone. The call-level json dict is no longer written into snapshots, since nothing reads it back. commit 0c986a81e2 Author: Daniel Donoghue <oneofsomany@hotmail.com> Date: Mon Aug 31 10:01:54 2026 +0200 MT#55283 do not report a rollback that did not happen call_merge() renumbers every unique id, and a snapshot is keyed on them, so a checkpoint taken before a merge no longer describes anything. It is dropped with the ids it refers to, and rollback reports none outstanding rather than a success that restored nothing. Both sides of a dialogue are checkpointed together. A monologue is shared between the branches of a forked call, so one side could already hold a checkpoint while the other had never been tracked, leaving a rollback to restore half a dialogue and still report success. Each fix has a test that fails without it. commit dfe7a72aff Author: Daniel Donoghue <oneofsomany@hotmail.com> Date: Mon Aug 31 10:41:50 2026 +0200 MT#55283 document that merging a call drops its checkpoints Merging renumbers the state a snapshot refers to, so an outstanding checkpoint is discarded and a later rollback reports none. Closes #2159 Change-Id: Ie773e2cd4a39fc1c8f39fafe959784e269c0c80e	1 week ago
Richard Fuchs	6a72ce30db	MT#55283 move Redis macros ... These are private to redis.c Change-Id: I19da8eec6cb5625375906d1eae047b43850dd591	1 year ago
Richard Fuchs	206e7db48b	MT#55283 scale redis timeouts ... Change-Id: I7594f38da85a61c3846f8c5eb41ee01b63de36ac	1 year ago
Richard Fuchs	f35881548d	MT#55283 convert async_last to int64_t ... Change-Id: I86284e3b6c0dc9c52be0e2ee54bf63a0490cece1	1 year ago
Richard Fuchs	0050ac5998	MT#55283 convert redis to int64_t ... Change-Id: I5238eaf821512b21dac33716fb9c5109c9e0955c	1 year ago
Richard Fuchs	e92f260e7a	MT#55283 convert daemon/ to int64_t ... Change-Id: Ie557204821fddfa5af0be96cc8f0ff2dd093fc7c	1 year ago
Donat Zenichev	1eb0c5e13e	MT#61556 redis: re-resolve when re-connecting ... When re-connecting to the remote redis server try to re-resolve if the redist hostname was an FQDN and not IP address. Change-Id: Ie80e1d1a1ea76811c54123201ad4fe8cb64fc748	2 years ago
Donat Zenichev	423d7bf824	MT#59086 Unify header files. ... In the header files follow the rules: 1. Firstly goes ifndef/define construction, then one empty row. 2. Secondly go system headers, so in angle-brackets, then one empty row. 3. If there are important pre-processor definitions, which affect the following custom file headers, they are added next, then one empty row. 4. Thirdly custom header files, so in double quotes, then at least one empty row. 5. If there is "xt_RTPENGINE.h", it's mentioned next, but separately, then one empty row. 6. Then pre-processor definitions, and one empty row before the code. In some situations it's allowed to step aside from the rules, when inclusions are dependent on each other, so on specific sequence, and also possibly on some inline objects definitions. But, if possible to follow the rules, it should be done. Change-Id: I6bec69b508653947c04e7785775373d21112eb58	3 years ago
Richard Fuchs	2975b2131d	MT#55283 convert struct call to typedef ... Change-Id: I1f01fdf74d6d3952413ebc02dfdb9770b324481c	3 years ago
Richard Fuchs	e58d36fb84	MT#56374 update glib dependency to >= 2.40 ... and remove related version test macros. Change-Id: I4eca21f4bf146ad8d13e775a5cd512ab1a190999	3 years ago
Orgad Shaneh	1a28b73a2d	MT#55283 Rename aux -> helpers ... Windows doesn't allow a file to be named aux, so checkout fails. closes #1686 Change-Id: I4667561f430ec8d4767d2313890839754be77322	3 years ago
Stefan Mititelu	983d91d19e	Add command to disable/enable redis write ... closes #1623 Change-Id: I3ff139b0e1b219be72566afe5b3b426ad555d9da	4 years ago
Richard Fuchs	83912f7502	MT#55283 remove non existing function from .h ... Change-Id: I3b82f180e9cececbdbd63998c2dbd32dca45dbfe	4 years ago
Richard Fuchs	19c8d1e01a	TT#14008 change Redis restore order ... To prevent a race condition that might miss updates about call info, set up the Redis keyspace notifications first and then run loop to restore calls from the existing data. closes #1503 Change-Id: I6afa4c50fe0a34c602063fc2f45b2ee38133cf1e	4 years ago
Richard Fuchs	765b1e3bca	TT#89352 use bool type for foreign call functions ... Change-Id: If8d5e28db534e6aeaaffb885e732e2bdd7338831	5 years ago
Richard Fuchs	1ec517c2f4	TT#14008 restore foreign calls from the appropriate DB ... closes #1257 Change-Id: I299475a01470cc9d4910d9d304bdda9bbbee6e83	5 years ago
Richard Fuchs	30621846ab	TT#14008 keep track of selected Redis DB ... This avoids unnecessary SELECT calls. Change-Id: I916889cbd4490045fdbacd85138d631ed6f7bd88	5 years ago
Richard Fuchs	a8d5076065	TT#119502 correctly restore calls from both Redis instances ... Change-Id: I713d7e8ba0a7d14f5ef9016d33619df91ce6ec32	5 years ago
Stefan Mititelu	2ebf5a1526	Add redis async delete	6 years ago
Stefan Mititelu	a6d2f92962	Solve Valgrind "possibly lost" for redis and dtls	6 years ago
Richard Fuchs	e1b2532fe8	eliminate (re)connected redis state duplication ... closes #982 Change-Id: I9c559ff98000a577f511648b01f67f13528bc7e8	6 years ago
Richard Fuchs	d64c888a0e	TT#36301 transcoding unit tests ... Change-Id: If48e5afe5a343b557183b6e87441f52424dd2c6a	8 years ago