rtpengine

Commit Graph

Author	SHA1	Message	Date
Guillem Jover	7dbe24e4e5	MT#61993 build: Rework to use a config.mk generated during the build These are potentially computed from inside each subdir, and in addition due to what appears to be a regression in GNU make 4.4, where it is reevaluating variables that contain $(shell) functions, many times (in the order of thousands, this was slowing down the build, were on the Debian amd64 build daemons it went from 5m with GNU make 4.3 to 2h40m with GNU make 4.4. Although the bulk of the slow down has been fixed with previous commits, the remaining optimizations are only to avoid this potentially happening again in the future, and to reduce useless duplicate work. Instead of trying to cache the values from within make itself, where programming this there is extremely painful, and does not seem to be able to greatly reduce the number of calls, because the build system is going to be called multiple times for different targets. Simply externalize the generation into several shell scripts, that we call to generate a make fragment that then we include from the various Makefiles. For a Debian build with GNU make 4.3, this reduces the amount of total pkg-config calls from around ~1600 to 128, for dpkg-buildflags from ~1100 down to 6, and for dpkg-parsechangelog from ~56 to 17, but the slow down is not as significant there anyway. For a Debian build with GNU make 4.4, this reduces the amount of total pkg-config calls from around ~2600 to 128, for dpkg-buildflags from ~2800 down to 6, and for dpkg-parsechangelog from ~350 to 21. For a Debian build with GNU make 4.4, this reduces the build time on this system from 2m10s to ~ 1m30s. Change-Id: I427d0ea5106dc6ed1ff9e664ccdba2fa0725b7d0	2 years ago
Richard Fuchs	7f07a5d24b	MT#55283 move stats struct defs to kernel module These will be shared between userspace and kernel space and so the definitions must be part of the kernel includes. Change-Id: Iabf7a4ecff3638ea1765a6d7341bb24e9955b509	2 years ago
Michael Prokop	427615d45b	MT#56627 debian: switch to usage with dh-sequence-dkms Since Debian/bookworm dh-dkms (debhelper addon for the Dynamic Kernel Module System (DKMS)) is available with its virtual dh-sequence-dkms package. This allows us to get rid of manual packaging work in maintainer scripts and debian/rules. Adjust backport scripts accordingly as dh-sequence-dkms and its dh-dkms are available only as of Debian bookworm + Ubuntu kinetic and newer. Ship debian/source/lintian-overrides to ignore lintian's: E: ngcp-rtpengine source: missing-build-dependency-for-dh_-command dh_dkms => dkms This dh-sequence-dkms vs dkms issue is only supported as of lintian versions >=2.105.0, while current Debian/stable AKA bullseye provides lintian v2.104.0, see https://bugs.debian.org/982834. Closes: https://bugs.debian.org/1030227 Thanks: Andreas Beckmann <anbe@debian.org> for the bug report + initial patch Change-Id: Ife1e976c88fbbe796bbd40225f682f0e5360a6d7	4 years ago

Author

SHA1

Message

Date

Guillem Jover

7dbe24e4e5

MT#61993 build: Rework to use a config.mk generated during the build

These are potentially computed from inside each subdir, and in addition
due to what appears to be a regression in GNU make 4.4, where it is
reevaluating variables that contain $(shell) functions, many times (in
the order of thousands, this was slowing down the build, were on the
Debian amd64 build daemons it went from 5m with GNU make 4.3 to 2h40m
with GNU make 4.4. Although the bulk of the slow down has been fixed
with previous commits, the remaining optimizations are only to avoid
this potentially happening again in the future, and to reduce useless
duplicate work.

Instead of trying to cache the values from within make itself, where
programming this there is extremely painful, and does not seem to be
able to greatly reduce the number of calls, because the build system
is going to be called multiple times for different targets. Simply
externalize the generation into several shell scripts, that we call
to generate a make fragment that then we include from the various
Makefiles.

For a Debian build with GNU make 4.3, this reduces the amount of total
pkg-config calls from around ~1600 to 128, for dpkg-buildflags from
~1100 down to 6, and for dpkg-parsechangelog from ~56 to 17, but the
slow down is not as significant there anyway.

For a Debian build with GNU make 4.4, this reduces the amount of total
pkg-config calls from around ~2600 to 128, for dpkg-buildflags from
~2800 down to 6, and for dpkg-parsechangelog from ~350 to 21.

For a Debian build with GNU make 4.4, this reduces the build time
on this system from 2m10s to ~ 1m30s.

Change-Id: I427d0ea5106dc6ed1ff9e664ccdba2fa0725b7d0

Richard Fuchs

7f07a5d24b

MT#55283 move stats struct defs to kernel module

These will be shared between userspace and kernel space and so the
definitions must be part of the kernel includes.

Change-Id: Iabf7a4ecff3638ea1765a6d7341bb24e9955b509

Michael Prokop

427615d45b

MT#56627 debian: switch to usage with dh-sequence-dkms

Since Debian/bookworm dh-dkms (debhelper addon for the Dynamic Kernel
Module System (DKMS)) is available with its virtual dh-sequence-dkms
package. This allows us to get rid of manual packaging work in
maintainer scripts and debian/rules.

Adjust backport scripts accordingly as dh-sequence-dkms and its dh-dkms
are available only as of Debian bookworm + Ubuntu kinetic and newer.

Ship debian/source/lintian-overrides to ignore lintian's:

  E: ngcp-rtpengine source: missing-build-dependency-for-dh_-command dh_dkms => dkms

This dh-sequence-dkms vs dkms issue is only supported as of lintian
versions >=2.105.0, while current Debian/stable AKA bullseye provides
lintian v2.104.0, see https://bugs.debian.org/982834.

Closes: https://bugs.debian.org/1030227
Thanks: Andreas Beckmann <anbe@debian.org> for the bug report + initial patch

Change-Id: Ife1e976c88fbbe796bbd40225f682f0e5360a6d7

3 Commits (2e414fcb20bc8de2ad2b45d4db2b8c6b8bbb18a3)