11 Commits (172afb6bc091147f91f2877a82074083c305a842)

Author	SHA1	Message	Date
Michael Prokop	378c791f21	TT#14008 Shellcheck fixes ... Fixup for git commit 23f5660314, fixing SC2034 (x appears unused) + SC2181 (check exit code directly). Change-Id: I50684e8e76940153c98d02210ac349f24962bac4	4 years ago
Richard Fuchs	23f5660314	TT#14008 unload kernel module after shutdown ... This has become important after the latest change to run rtpengine as non-root user as it requires reloading the kernel module with the new user/group permissions. Change-Id: Iedf2624402397f5d444955e9d5d6d5aa414be1c3	4 years ago
Richard Fuchs	6b65131966	TT#157800 support file mode mask for /proc interface ... The per-table /proc files may contain sensitive information. Add an optional file mode mask to apply to the top directly to hide it from unprivileged users. Change-Id: I3ec02739e0d97e53c8628259922ccf64ddfa8415	4 years ago
Richard Fuchs	190a9e9245	TT#14008 allow null TABLE variable ... If there's no config file present then retrieval of the table number yields an empty string. Allow this as an expected case to silence a warning from bash (using -lt against an empty string) Change-Id: I0420d2e1c555f6b56a56fc5f47d3bc183a929e50	4 years ago
Michael Prokop	9a5e02535c	TT#137760 Fix shellcheck issues ... Fixes: | In debian/ngcp-rtpengine-iptables-setup line 15: | TABLE=$(/usr/libexec/rtpengine/rtpengine-get-table --config-file=$CONFIG_FILE) | ^----------^ SC2086: Double quote to prevent globbing and word splitting. | | In el/rtpengine.init line 36: | configfile=${CONFIG_FILE-/etc/rtpengine/rtpengine.conf} | ^--------^ SC2034: configfile appears unused. Verify use (or export if used externally). | | In el/rtpengine.init line 38: | TABLE=$(/usr/libexec/rtpengine/rtpengine-get-table --config-file=$CONFIG_FILE) | ^----------^ SC2086: Double quote to prevent globbing and word splitting. Those went unnoticed in commit 111b0a769c, but are failing in github actions with shellcheck v0.7.2. While at it, ensure that /etc/rtpengine/rtpengine.conf is used as fallback, if CONFIG_FILE isn't defined. Change-Id: I1c1948245a907bd6d299b242a9faff960d0608bc	4 years ago
Guillem Jover	111b0a769c	TT#137760 Refactor table fetching into a new helper tool ... This centralizes the table setting into the respective config files instead of keeping copies all over the place, that can easily get out of sync. Change-Id: I12f3fa172f34861365c31c8d8718b3fae8a9de5b	4 years ago
Karsten Horsmann	940444a5dd	not report errors if "which" is failing. ... Since ngcp-virt-identify is not part of rtpengine #916 the helper Pre/Post script should not report errors if "which" is failing.	5 years ago
Richard Fuchs	cd23c05044	TT#56007 TT#55864 make RTPENGINE rules UDP only ... The rtpengine kernel module only cares about UDP packets, so narrow down our iptables rule accordingly. Change-Id: I33856efa6b39372104b05ec0dc6f34ad0b5e0cbd	7 years ago
Richard Fuchs	9c6677d2fd	TT#56007 TT#55864 leave xt_RTPENGINE loaded after stop ... There might be a firewall script that installs and manages the xt_RTPENGINE rules even if rtpengine isn't running at the point. Leave the module loaded if possible and unload it only for a package removal or upgrade. Change-Id: I5a35e965379aebd757a45883f82bbcb5fa2412e8	7 years ago
Guillem Jover	9b3226f42e	TT#49106 Do not use absolute paths for commands ... This makes it difficult to interpose local scripts to override local behavior, for testing purposes for example. Warned-by: lintian Change-Id: I5e1feda02a26f482728f5404496c5870ec93d8aa	7 years ago
Guillem Jover	79807a9c2e	TT#26264 Use better systemd native units ... While still not the ideal implementation, this is certainly better than the sysvinit script wrapper. We then will "only" need to move the setup scripts into proper service files later on. Change-Id: I990d6847117a4b91a8365a5e307fd96cf5b1899f	8 years ago