These will be shared between userspace and kernel space and so the
definitions must be part of the kernel includes.
Change-Id: Iabf7a4ecff3638ea1765a6d7341bb24e9955b509
This has been broken for a while and nobody seems to be using it since
nobody complained. Remove it.
Change-Id: I114e7b1859ecd1982338c625f4523f372af3bbe8
- add example mock chroots
- update for nftables, iptables deprecation in EL9
- ensure distro build flags are used %[set_build_flags}, especially
-fPIE
closes#1753
Change-Id: I11ef5791885fc6129f528ad0425c679ee26e5a08
As we now natively support nftables, we no longer need to rely on the
iptables helper script. We can completely remove it.
Change-Id: I214bfee6ada534754141cb86bb50e87556de977d
Capabilities listed in the ambient set must also be included in the
bounding set.
Change-Id: Iac8a97f6ba4f5446430ec2678092f768aeb8bb25
Related-to: I172bd30c9fbe488574e9cc015ba552e805c95fe6
In commit 427615d45b we switched to usage of dh-sequence-dkms. By
renaming debian/dkms.conf.in into debian/ngcp-rtpengine-kernel-dkms.dkms
and replacing its `__VERSION__` with `#MODULE_VERSION#` we broke the
shipped RPM spec file, which also relies on our dkms configuration file.
Accordingly adapt el/rtpengine.spec.
Thanks to @themsley-voiceflex for the bug report
Closes#1650
Change-Id: I257a8c223f931bb959f245ed518b855ffa988a81
Related to commit a3062b5f, let's also update the RPM spec file, its
configs/scripts and the README, to use /usr/bin instead of /usr/sbin.
While at it, noticed that el/ngcp-rtpengine-iptables-setup seemed to use
a wrong path (/sbin/rtpengine-get-table instead of
/usr/sbin/rtpengine-get-table), adjusted accordingly.
While at it, also fixed mixed-use-of-spaces-and-tabs issues (as reported
by rpmlint) in rtpengine.spec.
FTR, we have the following layout in the resulting RPMs now:
* /usr/bin/rtpengine
* /usr/bin/rtpengine-ctl
* /usr/bin/rtpengine-recording
* /usr/sbin/ngcp-rtpengine-iptables-setup
* /usr/sbin/rtpengine-get-table
Change-Id: I7e9e3527f4dc07adba425172cebb5672f2541690
Fixes:
| In debian/ngcp-rtpengine-iptables-setup line 15:
| TABLE=$(/usr/libexec/rtpengine/rtpengine-get-table --config-file=$CONFIG_FILE)
| ^----------^ SC2086: Double quote to prevent globbing and word splitting.
|
| In el/rtpengine.init line 36:
| configfile=${CONFIG_FILE-/etc/rtpengine/rtpengine.conf}
| ^--------^ SC2034: configfile appears unused. Verify use (or export if used externally).
|
| In el/rtpengine.init line 38:
| TABLE=$(/usr/libexec/rtpengine/rtpengine-get-table --config-file=$CONFIG_FILE)
| ^----------^ SC2086: Double quote to prevent globbing and word splitting.
Those went unnoticed in commit 111b0a769c, but are failing
in github actions with shellcheck v0.7.2.
While at it, ensure that /etc/rtpengine/rtpengine.conf
is used as fallback, if CONFIG_FILE isn't defined.
Change-Id: I1c1948245a907bd6d299b242a9faff960d0608bc
These can be set from the config file, which makes the support in the
sysvinit script redundant. Remove all these and leave only the minimally
relevant ones involved in the startup of the daemon.
Change-Id: I3faac4594d7f1a21e65761036c2ab153acb96152
The default value for the kernel table in rtpengine is -1, so the helper
should default to use the same to match in case the parameter is not set
in the config file.
Remove an explicit --table passed to the daemon in the el init script,
and remove fallback initialization handling already done by the new
helper.
Change-Id: Ie4ec50a34e467f829279ad626a5b0e3b15acfd16
Fixes: commit 111b0a769c
This centralizes the table setting into the respective config files
instead of keeping copies all over the place, that can easily get out
of sync.
Change-Id: I12f3fa172f34861365c31c8d8718b3fae8a9de5b
commit 26478c1dcfafab68fe29e9828934f0d8672ec3ed
Merge: aeb0b7bcfc265e0b
Author: Richard Fuchs <rfuchs@sipwise.com>
Date: Wed Jun 23 14:45:32 2021 -0400
Merge branch 'el-systemd' of https://github.com/khorsmann/rtpengine into khorsmann-el-systemd
Change-Id: Ide2e93d5baa1ecba97d256a48c53c106c084f9fd
commit fc265e0b3d
Merge: 41a9a8ae1d845c21
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Wed Jun 23 19:25:09 2021 +0200
Merge branch 'sipwise:master' into el-systemd
commit 41a9a8ae6e
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Wed Jun 23 19:22:09 2021 +0200
iptables in ExecStart/ExecStopPost needs root privleges. Correct copy-paste error.
commit 0f991f6666
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Wed Jun 23 17:57:55 2021 +0200
readd User/Group and switch back to forking cause CentOS7 systemd is very old
commit 11290d48b6
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Tue Jun 22 12:18:38 2021 +0200
if ngcp-virt-identify not there should not break the script
commit b7040ad992
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Tue Jun 22 12:05:04 2021 +0200
add iptables helper for el systemd to spec file
commit 6d67dc3b3a
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Tue Jun 22 11:21:34 2021 +0200
* add also ngcp-rtpengine-iptables-setup. So iptables rules will created like the debian packages did that.
closes#1292
Change-Id: I6f31608c70b069b3584ad240b7eda10e59c94e4b
Systemd complains about 755 rights of EL service files.
"systemd[1]: Configuration file /usr/lib/systemd/system/rtpengine.service is marked executable. Please remove executable permission bits. Proceeding anyway."
Sipwise Jenkins Builder
lrh3321
Richard Fuchs
Takuya Wakazono
S-P Chan
Michael Prokop
Anton Voylenko
Guillem Jover
Karsten Horsmann