23 Commits (03212c28ef1c66ada3faabdd9d2648bf2f9caeb4)

Author	SHA1	Message	Date
Richard Fuchs	5e51cfde5b	MT#55283 remove redundant code ... Use str_cmp() to implement str_eq() Use str_shift_cmp() in place of str_prefix() Update return types to bool Change-Id: If7927d957e20780408e77da1d04baffa082a6914	2 years ago
Richard Fuchs	a2ee38ac44	MT#55283 rename STR_CONST_INIT... ... ... to STR_CONST...() for consistency no-op Change-Id: I68da3d1a80b9d6db69adba1091e58cc4909305ca	2 years ago
Richard Fuchs	a6b28af6f8	MT#55283 modernise STR_INIT and str_init ... Obsolete str_init(), rename STR_INIT() to just STR(), and replace all instances of str_init() with STR(). no-op Change-Id: I981529063ad2ea26089add467f7a84b638dbf423	2 years ago
Richard Fuchs	dfbadf004e	MT#55283 remove redundant string parsing ... `delete-delay` is already parsed using bencode_dictionary_get_int_str() so we don't need to special-handle string type values Change-Id: If9758ccfbbe18674b7731aa53b9de5bd3fd87ae4	2 years ago
Richard Fuchs	89573be718	MT#55283 skip creation of single-item lists ... The function in charge of processing codec flags can already handle standalone string values and doesn't require a list to wrap single strings. Change-Id: Id9bc97d455c75a3d1b0a19c5dbe43f677c937401	2 years ago
Richard Fuchs	a05884016d	MT#55283 convert flags parsing to `str` ... Use two invocations of str_token_sep instead of strpbrk + strchr. Remove remnants of C-style string parsing. Change-Id: Id7aa27dc4e8f77398cc4d7d93847a45eee0a329e	2 years ago
Donat Zenichev	f695e77064	MT#58535 rtpp_flags: add support for generic 'rtcp-mux-*' ... Add generic parsing for 'rtcp-mux-*' flags in `call_ng_flags_flags()`. Additionally add tests for: - rtcp-mux - SDES - T.38 Change-Id: I675a9de455fa87a8dfdc4453e010141cee2f294d	2 years ago
Donat Zenichev	ceb49c9b54	MT#58535 rtpp_flags: deprecate usage of dict for parsing ... Deprecate a usage of intermediate dictionary for parsing of rtpp flags. Just use the `call_ng_main_flags()` function directly with a given `bencode_buffer_t` buffer. Change-Id: I0bea13b94b6e0016799dd07a50061e1367131106	2 years ago
Donat Zenichev	7b94627fc2	MT#58535 rtpp_flags: parse the rest of flags directly ... Switch the rest of flags (with non-specific processing) to direct parsing or deprecate specific parsing at all and let it be parsed as generic one (key/val). Deprecated for: - `TOS` - `to-tag` - `call-id` - `via-branch` Left for: - `from-tag` (requires directional flag setting) - `delete-delay` (uses int bencode object, because the `call_delete_ng()` requires it in this format) Change-Id: I0c5cb173bae09064f8177298aef3d070132f84cf	2 years ago
Donat Zenichev	e79bc405ca	MT#58535 rtpp_flags: Deprecate `repacketize` flag parsing ... Parsing of `repacketize` using `parse_repacketize()` has been deprecated. Change-Id: Ibbe3c3d41da5974761aabe7f2abfbdab6ead7bdc	2 years ago
Donat Zenichev	db6bfb9325	MT#58535 rtpp_flags: deprecate `new_list_to_dict()` ... Deprecate parsing of generic flags using `new_list_to_dict()`. Leaving it only for `received-from` as it requires special handling. Function signature is adopted accordingly. The funciton itself calls the `call_ng_main_flags()` directly, without really using intermediate bencode objects. Change-Id: I320761a4b84da0128981f9b65e3ba69e9b4018ac	2 years ago
Donat Zenichev	97f7098459	MT#58535 rtpp_flags: parse `direction` flag directly ... Direction parsing. Instead of adding key/val flags to the dictionary for further parsing later via iteration in `call_ng_main_flags()`, just call the `call_ng_main_flags()` directly. Change-Id: Ide137aed12a6ba416b59a307a0a11a934f78a858	2 years ago
Donat Zenichev	8548e7d67b	MT#58535 rtpp_flags: parse `codec-*` flags directly ... Codec related flags parsing. A bencode list for codec related flags keeping (while parsing in `parse_rtpp_flags()` ), is removed due to no need. Instead of adding key/val flags to the dictionary for further parsing later via iteration in `call_ng_main_flags()`, just call the `call_ng_codec_flags()` directly. Change-Id: I1adcea84e9254ae35e6480d61426f1434513e779	2 years ago
Donat Zenichev	a642a4e917	MT#58535 rtpp_flags: parse `transport` flag directly ... Transport parsing. Instead of adding key/val flags to the dictionary for further parsing later via iteration in `call_ng_main_flags()`, just call the `call_ng_main_flags()` directly. Change-Id: I86a2d6855bcd94edb206c632d8288dd769e94ba8	2 years ago
Donat Zenichev	1e65172b52	MT#58535 rtpp_flags: parse key/val flags directly ... Instead of adding key/val flags to the dictionary for further parsing later via iteration in `call_ng_main_flags()`, just call the `call_ng_main_flags()` directly. Change-Id: Ia893a6b50db7a0659a42c09463169f2c0f5e595e	2 years ago
Donat Zenichev	066ca7387c	MT#58535 rtpp_flags: fix typo in code commentaries ... Fix a typo in code commentaries for `via-branch`. Change-Id: I5b22c25fa1b6050bbff9236da4d76028dc4056b2	2 years ago
Donat Zenichev	1331437a1b	MT#58535 rtpp_flags: fix bug in `direction` parsing ... Instead of adding `key` the `val` is to be added. Change-Id: I8ffdfd8add0d91669f75c2cffe30a3e07e3089eb	2 years ago
Donat Zenichev	ff98b83f6f	MT#58535 rtpp_flags: remove unused `flags` bencode list item ... Since the generic flags parsing is done (from now on) directly in the `parse_rtpp_flags()`, there is no need to keep a separate bencode list object to store them, which was originally intended to be used later for parsing in `call_ng_flags_flags()`, but not the case anymore. Change-Id: I7898e29cabecfd6e8429c064d7b5904d94c50513	2 years ago
Donat Zenichev	59dca7dcec	MT#58535 Shadow the `parse_str_flag()` because unused ... It's a useful function for parsing flags, which we most probably will need in the future, but unsed now. Change-Id: I3bed7b52e565a24f4ea8ee791a5872ad9cb06228	2 years ago
Donat Zenichev	282f57884e	MT#58535 Use `call_ng_flags_flags()` for generic flags ... During the parsing of `rtpp_flags` use the `call_ng_flags_flags()` directly instead of the `bencode_list_add_str()`, hence reduce amount of iterations required to parse generic flags. Additionally: `call_ng_flags_flags()` is made visible for usage within external files. `helper_arg` union has been moved to the header. Change-Id: I34399a0d3940a1276feb1210e4421cbcdf656e9d	2 years ago
Donat Zenichev	15d0867737	MT#58535 rtpp_flags: add directional flag parsing ... Is added by: - explicit generic flag "directionl"; or - if the "from-tag" flag is used Introduce the `directional` flag for `sdp_ng_flags` struct. In use by: - `media_block_match1()` Additionally: add `IS_OP_DIRECTIONAL()` marco check. Change-Id: Ifd56ea2ad8277d7dec136def1c028c5e2b680ff1	2 years ago
Donat Zenichev	f60139cf0d	MT#58535 Add opmode to processing of flags ... Add operation mode to the flags parsing functions. Change-Id: I49147b39ebccd43dfa703ba7857f1902bdad976b	2 years ago
Donat Zenichev	36c19b9111	MT#58535 rtpp_flags: introduce raw flags parsing ... Add support of rtpp_flags parsing for the daemon. From now on, it's possible to parse option flags on the daemon side instead of the kamailio module. It's identical to what the module does, but the difference is: - module sends general call identification such as: call-id, From/To tags, viabranch using bencode - meanwhile all generic/non-generic option flags are added to the `rtpp_flags` bencode member as str - parsing of that is done as usually using the `call_ng_main_flags()` / `call_ng_flags_flags()` and additionally using new parser `parse_rtpp_flags()` New file implementation and header introduced: - control_ng_flags_parser.c - control_ng_flags_parser.h Otherwise no functional changes, and the parsing itself remains working following the same algorithm. Change-Id: I59e47fa1947e2aeaa0bbf3930a0f21d9a6d669ad	2 years ago