rtpengine

Commit Graph

Author	SHA1	Message	Date
Richard Fuchs	1095a9d791	MT#55283 work around LWS thread non-safety While LWS explicitly allows usage of lws_callback_on_writable() from other threads, for some reason there is no internal locking in place, and so a concurrently running lws_service() can interfere with internal structures, in particular if lws_service() is closing connections at the same time as lws_callback_on_writable() is invoked. The suggested approach of using lws_cancel_service() in combination with the LWS_CALLBACK_EVENT_WAIT_CANCELLED callback and a user-kept queue is not feasible, as we need to support LWS 2.x, which doesn't have LWS_CALLBACK_EVENT_WAIT_CANCELLED. Closes #1624 Change-Id: Ia3ddeda66fd553c87f99404e0816d97ecbd4cdfe (cherry picked from commit `1457b34f65`)	3 years ago
Richard Fuchs	2e375cd05b	MT#55283 eliminate useless return values These functions now cannot fail and so returning a value is pointless. Change-Id: I062449f30f05fb3efa4ba520004a13de3a0abd5a (cherry picked from commit `26cc168f83`)	3 years ago
Richard Fuchs	d7d1d478b0	MT#55283 single-threaded lws_write() Avoid calling lws_write() from threads other than the service thread, as this might not be thread-safe. Instead store the values used for the HTTP response headers in the websocket_output, then trigger a "writable" callback, and finally do all the lws_write() calls from the service thread. Reported in #1624 Change-Id: Ifcb050193044e5543f750a12fb44f5e16d4c0a08 (cherry picked from commit `b207d0c586`)	3 years ago
Richard Fuchs	acbb2ccb69	MT#55283 reverse loop skip logic Removes one level of indentation for prettier code. Functional no-op. Change-Id: I5f5528944f144499540f34bc1f322d00c9454fa6 (cherry picked from commit `cb9ec2abf9`)	3 years ago
Richard Fuchs	e6cc16e542	TT#14008 fix "Connection: Close" HTTP breakage closes #1482 Change-Id: I5357a079616476b3fd1d7cfa842b23fa31135674	4 years ago
Richard Fuchs	8b8b7fb15c	TT#14008 fix handling of large WS payloads closes #1294 Change-Id: Icd901009721955be8b56042b2308c6638b89e064 (cherry picked from commit `99985d234d`)	5 years ago
Richard Fuchs	a8013ffe70	TT#111051 set thread specific process names Change-Id: I6a5bb14c070d93b865510786f5107220b93faef1	5 years ago
Guillem Jover	e2552773cc	TT#108003 Handle errors during websocket connection initialization Make the websocket_conn_init() function return an error code, and delay the initialization after we cannot fail. And otherwise return -1, such as when we cannot initialize the HTTP nor SSL connection. Change-Id: I0facd53560fdb06678d7df9775be277e5c4b2cae Warned-by: coverity	5 years ago
Richard Fuchs	1dbfbe87d3	TT#14008 move g_string_free helper to auxlib Change-Id: I34e0aa0be1df06346e86684c6488caf8e302df9f	5 years ago
Richard Fuchs	554034eb7e	TT#106101 also turn UDP/WS receive buffer into refcounted object Change-Id: I81fa68b07af3a87e26d031a5722dcd103a1e620e	5 years ago
Richard Fuchs	9653546f7c	TT#107157 fix LWS HTTP handling crash Sequence of events: 1) HTTP request is being handled in worker thread by calling the handler func() from within websocket_process(). 2) Handler func generates output, queues it up, and requests a `writeable` callback from within websocket_write_raw(). 3) Main LWS thread triggers writeable callback and calls websocket_dequeue(). 4) Output is given to LWS still within the main LWS thread, and finally lws_http_transaction_completed() is called to release the connection and ready it for the next HTTP connection. 5) LWS internally cleans up the connection and frees the user context (our `wc` struct). 6) The worker thread wakes up and continues to use the now invalid `wc` in order to clean up after it has done its job. Boom. The solution is to handle the `drop protocol` callback, which is triggered by LWS in the main LWS thread in step 4 from within lws_http_transaction_completed(). We call our own connection cleanup function websocket_conn_cleanup() which blocks until all jobs are removed from `wc` (step 6) and only then continue, allowing LWS to safely free the struct. Change-Id: I596a98e9b552a96aef259f4523f16fa63c287ef4	5 years ago
Richard Fuchs	30733ec5cd	TT#97301 support granular log levels Change-Id: Ife458bd2449f61113a3e6db1708821570d92dc23	5 years ago
Richard Fuchs	cd577a2710	TT#106150 fix possible race condition while processing WS queue Change-Id: I1137d828487e988b7afc3a0992312e4d8a0de876	5 years ago
Richard Fuchs	8de20ce28b	TT#82405 terminate HTTP connection when output was been written This allows persistent HTTP connections to work properly. Change-Id: I5e74293bcc9986d4fb3800b7dbcbc3c65b9a14fb	5 years ago
Richard Fuchs	c2c7f9a506	TT#82405 add convenience function to return HTTP data Change-Id: I3ea40a7341a8959b407e6bf296e80226d52f1e1f	5 years ago
Richard Fuchs	5d895fb7be	TT#82405 add Prometheus stats exporter Change-Id: Ic55b42a707e430a61c0422c65827ed2145511586	5 years ago
Richard Fuchs	dec54fa3e0	TT#102500 fix missing timestamping in websocket threads closes #1113 Change-Id: Id301a4c47f6e341777ce7c3b58fcea4c659d2f8d	5 years ago
Richard Fuchs	f0212124fe	fix compiler warning Change-Id: I19ee1b097a4d0d85ba69fd01975e26f69c6c55fd	5 years ago
Richard Fuchs	4910f7b33f	TT#88951 support queuing multiple WS output messages Change-Id: I9bcb1f5dd2942c4631820c25f343331c9630b8d7	5 years ago
Richard Fuchs	e1dda97028	TT#14008 fix some warnings from musl Change-Id: I99fe1185cf814232b44c078b62199e850850cb0d	5 years ago
Richard Fuchs	ca86f81a53	TT#14008 fix compilation for libwebsockets 3.x closes #1087 Change-Id: I2178d577a6913a13c1a3df7caa46978c1423501f	5 years ago
Richard Fuchs	31f8b6f982	TT#91150 support NG over HTTP/WS Change-Id: Ib0255872f6d85f2ca5c2d9118831ba8e65f7df2a	5 years ago
Richard Fuchs	3f301dd73b	TT#88951 support handling CLI commands via HTTP and WS Change-Id: Ic2e43328fa698d8abbc16146c997598f25bf84e6	5 years ago
Richard Fuchs	aa36a1f619	TT#88951 add HTTP/Websocket listener Change-Id: Ib2e7c87913abd4f89aa43075fe7cd9fb4d7cf1f7	5 years ago

24 Commits (mr9.5.6)