120 Commits (mr13.0)

Author	SHA1	Message	Date
Eric Green	aea277dbbe	Add a mutex lock for recording to ensure thread safety when writing to pcap	10 years ago
Eric Green	0e1892f532	recording.c fix my tabbing to use actual tabs	10 years ago
Eric Green	a8576eb2d2	Do not convert to network byte ordering before we are done using a variable	10 years ago
Dylan Mikus	fa8146f053	Fixes for recording packet counter ... - The packet counter was accidentally a pointer, resulting in it incrementing by 8 instead of 1. That is fixed. - Use proper formatting macro for uint64_t printing. - Start PCAP packet indexing at 1 since that is what Wireshark does.	10 years ago
Dylan Mikus	209cb7ab32	Modifications to recording metadata start/end time lines ... In the call recording metadata file, start and end timestamps for the call are now "key: value" formatted so you can tell what they are just by reading the metadata file.	10 years ago
Dylan Mikus	5fe68b9097	Link recording metadata SDP to RTP packet numbers ... We write out what RTP packet number the SDP came before. When we receive an SDP offer or answer, we write out the RTP packet number that the SDP preceeded. This will let us split the RTP recording PCAP around SDP renegotiation for things like hold/unhold. Also write out whether the SDP was an offer or an answer.	10 years ago
Dylan Mikus	526e9c251c	Get recording metadata call start from call struct ... When we write out the start time of a call for the recording metadata, we used to get the timestamp from the given `call_monologue.started` member. This value changes after each SDP renegotiation. Now, we use the `call.created` member.	10 years ago
Dylan Mikus	a109fa2d6d	Change metadata file permissions and fix some warnings ... I changed metadata file permissions to 664. I made some non-void functions properly return non-void values. This does not change any functionality. Just quiets a few compiler warnings.	10 years ago
Dylan Mikus	d267a3bdd7	Tweaks to log verbosity for some messages ... Changed some `ilog` messages to log to INFO or debug to limit the verbosity of our log files.	10 years ago
Dylan Mikus	abd953812f	Fixes to match PCAP packets with SDP ... We want to be able to match up the source and target <IP>:<PORT> with the IP and port info sent in SDP. I adjusted the source and target <IP>:<PORT> we write to the IP and UDP headers in the PCAP file. I added the offer SDP (in addition to the already written answer SDP) to the metadata file. As a consequence of writing out the offer SDP, we will have empty PCAP files and associated metadata files for calls that are never answered. squash! Fixes to match PCAP packets with SDP Added comments detailing the types of endpoint IP/port values we can use.	10 years ago
Dylan Mikus	beab4d95b4	Write recording files in url-encoded format ... We write the call-id out as part of the filename for pcap and metadata files for recorded calls. We don't want troublesome characters to be in the filename, so we urlencode the filenames.	10 years ago
Dylan Mikus	adb6193891	Minorly adjusted the recording metadata file format ... In the recording metadata files, we now separate each logical section of metadata by two blank lines. So, it goes: 1. the PCAP file URL 2. two blank lines 3. all answer SDP, each separated by one blank line 4. two blank lines 5. start timestamp 6. end timestamp (no blank line in between) 7. the rest of the file is unstructured metadata (any number of lines)	10 years ago
Dylan Mikus	0b33b4815a	Write out rewritten SDP from answer to metadata file	10 years ago
Dylan Mikus	466c52c18e	Refactored recording setup to streamline it ... We had initialization code for recording scattered through "call_interfaces.c", "call.c", and "recording.c". I moved more of the actual code into functions within recording.c under the parent function `detect_setup_recording`. We call this function from "call_interfaces.c". I moved the disjointed bit of PCAP initialization to occur right below where we toggle recording on or off.	10 years ago
Dylan Mikus	d604ff6fd3	Set more permissive permissions in spool directory ... In the rtpengine spool directory, when we create the "pcaps" and "metadata" inner directories, we now give all users read and write privileges to them, instead of just the owner and the group having those permissions.	10 years ago
Dylan Mikus	1cec331d1c	Only turn on or off recording if explicitly specified ... When we receive an offer or an answer, we will only turn recording on if it contains the "record-call=yes" flag. Likewise, we only turn recording off if it contains the "record-call=no" flag. If no flag is specified, the call keeps its current recording status. It used to be the case that not specifying "record-call=yes" would turn off call recording. This fix is necessary to account for SDP renegotiation during hold/unhold. If the call system sends over another offer during SDP renegotiation to hold and then unhold, we don't want to change recording behavior unless the call system specifically says so.	10 years ago
Dylan Mikus	b3d6073447	Prefix recording metadata and pcap files with call id ... We want to be able to associate call files with a call without the presence of identifying metadata within the metadata file. To accomplish this, we prepend the call-id to the start of the pcap recording files and the call metadata files. Even though call-id is supposed to be unique, because of paranoia we keep some of the random affix hex string, but we reduced it down to an 8-byte random value. Also, some minor argument ordering and name refactoring for random string generation functions.	10 years ago
Dylan Mikus	844abeec7d	Don't free the metadata before writing it to metadata file ... We used to sometimes free the generic metadata (passed in through rtpengine commands) before writing it to disk. Then we were writing blank metadata to our metadata files. We fixed the ordering of our `free` operations.	10 years ago
Dylan Mikus	7acc3239d2	Write out unique ip:port pairs for all streams. ... We should do some more checking to make sure we're using the correct values for source and destination ip:port pairs.	10 years ago
Dylan Mikus	f516684ade	All RTP packet data for a call goes to one PCAP file. ... This involved moving all code from fs.(c|h) to recording.(c|h). We still spoof packets, so the UDP will look like all monologues are coming over the same port and will probably look like they are all one stream if you look at the PCAP file.	10 years ago