389 Commits (coverity_scan)

Author	SHA1	Message	Date
Richard Fuchs	33e5f09592	MT#61625 support "blackhole" codec handler ... Special codec handler to support not forwarding (nor any processing whatsoever) of particular payload types at all. Support this in the kernel module as well. Change-Id: If10227affa54307e1e9b448eadd0bf2bfc5774ba	10 months ago
Richard Fuchs	a1ec17504b	MT#55283 use _ht_destroy_ptr in a few more places ... Change-Id: I98e088e5f6fe23532ca06a0592e73dac3b3024c3	10 months ago
Richard Fuchs	23e5854658	MT#61625 add missing port release ... Change-Id: I54108b846ae34b74ce992f622c42d8ba99b46570	10 months ago
Richard Fuchs	9d9e0615a5	MT#55283 split up __get_consecutive_ports ... Separate out the two distinct use cases of requesting a specific port, and requesting (one or more) random ports. Change-Id: Ifbe7725d8638d49f620c9f4b9445342d180c8770	10 months ago
Richard Fuchs	c040dffdc1	MT#55283 split out socket open logic ... Change-Id: I7fc0784fec800008c91a87e227f5f69d182a9e1e	10 months ago
Richard Fuchs	95fc263991	MT#55283 add helpers for reserve_port ... Add helper functions wrapping around reserve_port which directly return a socket_port_link object. This allows us to rework __get_consecutive_ports and release_reserved_port to eliminate mixing different port numbers in the same list, which makes for cleaner code. Change-Id: Ia9808f71c854f6efd0e93ce8df4527c4aea311bd	10 months ago
Richard Fuchs	a7082a1119	MT#55283 split up reserve_port ... Change-Id: I194f9661c890a3fe4f4814fc84c747baa2ba0f11	10 months ago
Richard Fuchs	2dd06398a2	MT#55283 use bool for get_consecutive_ports ... Change-Id: Ic4bfcaf2fe64874c5b108dda2c774bc7a46cd212	10 months ago
Richard Fuchs	0da49000ba	MT#61404 always update egress RTP index ... Add a simple function that acts as an encryption callback to just update the ext_seq (index) of the egress SSRC context. The kernel module already does this, but the daemon only did it when SRTP was involved. This now tracks egress packet indexes in all cases. Change-Id: I9460744de55ead4b05aceb322fd8482442ff2b41	11 months ago
Richard Fuchs	a19bed611c	MT#61404 remove unused RTP/non-RTP distinction ... Change-Id: Ia43e1eb373c893df6693032a14eb631f16593094	11 months ago
Richard Fuchs	eeeb2d8641	MT#55283 move socket_port_link into stream_fd ... This allows us to simplify some function signatures Change-Id: I58f65735ba84ec7a536b1b170d1ef90e266308f5	11 months ago
Richard Fuchs	08e382540e	MT#55283 add link to port_pool in socket_port_link ... Change-Id: I43400175271b089a368f731bd55acb05ccab7141	11 months ago
Richard Fuchs	c99a4691b4	MT#55283 use GPOINTER_TO_UINT ... Change-Id: I5e8ee279aa193c1b7f71a01c42fa3482856b9b30	11 months ago
Richard Fuchs	4c9343b8c6	MT#55283 used typed hash table for rtp_stats ... Change-Id: I015a931d7e726815d2a7d06fa4d74a1418dfec0b	11 months ago
Richard Fuchs	7599e5c375	MT#55283 convert close_socket to bool ... Change-Id: I290012391ba1fa2c6c550614e054181de6e0b94e	11 months ago
Richard Fuchs	c2ba54e615	MT#55283 convert open_socket to bool ... Change-Id: I715afc937f6b1cbc124ff14a0428f781f58cd050	11 months ago
Richard Fuchs	416ca38d25	MT#55283 allow overlapping port ranges ... Change-Id: I6df35b8cc0687567d7c3c0fd6d44979345dca364	11 months ago
Richard Fuchs	1b7077152f	MT#55283 change reserve_port semantics ... Change-Id: I162fbf8f167b1c47e060128dcb4f8773c8fbf3a7	11 months ago
Richard Fuchs	3c6108e072	MT#55283 move mutex locking into function ... Change-Id: Ie01aa986887f2d0e709aae725b0a50ca833d84b6	11 months ago
Richard Fuchs	347c21fc7e	MT#55283 use typed GQueue ... Change-Id: Iea5a5e988ea23a17a5b2da5f02cd972afae2db87	11 months ago
Richard Fuchs	9d93762053	MT#62053 add exclude-ports option ... Change-Id: Ibf319f5ae00e120490610c695a326f5397412155	11 months ago
Richard Fuchs	aec1a0940c	MT#62053 add safeguard against broken port ranges ... Change-Id: I5e4fa46b5d75253129e887da8ddbba4fc60702f5	11 months ago
Richard Fuchs	2d8f5616e4	MT#62053 exclude ports only from applicable interface ... Change-Id: I9daf5fee91007e025b526e197191d98bdb54cc06	11 months ago
Richard Fuchs	6276b37cd2	MT#55283 use list pointer ops for port pool ... Avoid repeated calls to the memory allocated for port pool list management by picking out the list elements without freeing them, storing them in the stream_fd object, and then returning them to the list when the port is released. Change-Id: I67cd5039e62e4d2965e85d7ba7f0454f08f40494	11 months ago
Richard Fuchs	b9972e481e	MT#55283 use bool type ... Change-Id: I75aa1a4091ecc91d4937dfc0bdceb18551a9c879	11 months ago
Richard Fuchs	8e9afe626b	MT#55283 (some) type safety for ports free list ... Change-Id: I79e47f9e6dbfa29c738f75efd2c3d3322e4cb6e1	11 months ago
Richard Fuchs	4e53f06fe6	MT#55283 directly pass port_pool to functions ... Change-Id: Ifd68dc1b5bd53f4d5e9b74883f84104a02e86c18	11 months ago
Richard Fuchs	3fd2586d31	MT#55283 save some memory by using an offset ... Change-Id: Ic53fd60bc2780d0890905c14acfbc39d8cf89861	11 months ago
Richard Fuchs	267d244cb4	MT#55283 use array instead of hash table ... Change-Id: Ie510523724d14d8c76bb9647ee184ea3756be06c	11 months ago
Richard Fuchs	4279ed6750	MT#55283 fix for older compilers ... Change-Id: I05e8d3bd5c4b9608f4896aecab189c8c344fb139	11 months ago
Richard Fuchs	28802073fe	MT#55283 use typed objects for interfaces ... Change-Id: I57aaf64dbf1bb51e8ea9616ae483b14f470e9751	11 months ago
Richard Fuchs	ad6fb06b13	MT#55283 type safety for uid_alloc ... Change-Id: I4b5975d22f2713b66edba128f0749461578f9cde	11 months ago
Richard Fuchs	3ea365ef60	MT#55283 use typed hash table for rr_spec ... Change-Id: I99a4c334e182e5cb568cd8241b4f81340066dee2	11 months ago
Richard Fuchs	02bccee56b	MT#55283 use typed queue for local_intf ... Change-Id: Id7bf3804ab029bdf60d010b05e057bb7851645cd	11 months ago
Richard Fuchs	15fa36df30	MT#55283 use link manipulation ... Change-Id: Ib5c6984f100ac589b51f668737d5b72f6cd8d394	11 months ago
Richard Fuchs	964d6b0b8c	MT#55283 use typed queue for logical_intf ... Change-Id: I16fb597d6a30e7b4396493fa31f29a346db84e7c	11 months ago
Richard Fuchs	5b7bc82bbb	MT#55283 warn about mismatched port ranges ... Change-Id: I229056084844702e88867f4c9a17fe3b311d1036	11 months ago
Richard Fuchs	ad8ce3541d	MT#61822 add RWLOCK_STATIC_INIT ... Change-Id: I6718df967b70554a32c3caddcb4e29af4fb6d7f0	1 year ago
Richard Fuchs	2ce79f9bb4	MT#61822 add type safety to obj_alloc ... Make the macro return the appropriate pointer type, and make sure the free function takes an argument of the same type. This also eliminates some boilerplate type-casting code. Change-Id: I3094271fa2c53ec93b9ff9f837d461cf422e0f12	1 year ago
Peter Pulham	8e04c44b86	MT#55283 media_socket.c: check for NULL payload_types passed to kernelize_one ... under normal circumstances, the rtp sink enters this function first and updates the reti->local.family var to AF_INET so that when the function is called for an rtcp sink, it exits the function early. However, if media is being blocked the rtcp sink is the first to enter the function and does so with a NULL payload type. this NULL check is therefore required to prevent a sefgault on the call to `assert`. closes #1876 Change-Id: Id95cbbc9ae388f50dd51417c351f4a9ba09eb5f0	1 year ago
Richard Fuchs	38985b96df	MT#55283 always use full-struct initialisation ... Avoids uninitialised values. Closes #1873 Identified by Alexandru Pirvulescu <alex@tcnbroadcasting.com> Change-Id: Ie7019c2f762b6f163d6d27c519513f6898e1571c Ref: https://github.com/sipwise/rtpengine/pull/1873 Thanks: Alexandru Pirvulescu <alex@tcnbroadcasting.com>	1 year ago
Richard Fuchs	f60ee917c9	MT#55283 unify types used for sequence numbers ... We use int or unsigned int everywhere, except in a few leftover places. Unify to (unsigned) int. Change-Id: I0896b2f177957c17b30a3d0cb6b3fb2beb4bd684	1 year ago
Richard Fuchs	201c15489c	MT#55283 initialise str objects with macros ... Use provided macros for initrialise str objects everywhere instead of manually setting .s and .len. This allows for flexibility to extend str objects. Change-Id: I5ebca0bc82b348301c2c8e94b974c7acbf249b82	1 year ago
Richard Fuchs	7b1557cc1e	MT#55283 rekernelize after DTLS connect ... Change-Id: I468b6c07df96111ee49a85e36382a692dbeec82b	1 year ago
Richard Fuchs	a0b705eef9	MT#55283 trigger rekernel for SSRC-less streams ... If a stream has been pushed to the kernel from anything other than RTP, even though RTP is expected, we get a forwarding entries without any SSRCs. This is valid, but once actual RTP is received, it needs to be passed on to user space, so that SSRC contexts can be set up. Possible fix for #1855 Change-Id: I51b82d3cf79cf66780fdde154bebe56e0f43174b	1 year ago
Richard Fuchs	a2ee38ac44	MT#55283 rename STR_CONST_INIT... ... ... to STR_CONST...() for consistency no-op Change-Id: I68da3d1a80b9d6db69adba1091e58cc4909305ca	1 year ago
Richard Fuchs	a2059a2449	MT#55283 modernise STR_INIT_LEN() et al ... Obsolete str_init_len() and replace with macro. Rename STR_INIT_LEN() to just STR_LEN() no-op Change-Id: I09dc91dedd57a5b5ca791be4e6f158aecbf339ed	1 year ago
Richard Fuchs	a008e27a45	MT#55283 support interface aliases ... Change-Id: Ifd85bc49201bab1ab89a8d240ee682a6d1655868	2 years ago
Richard Fuchs	3e73fb5181	MT#55283 move ownership of logical_intf to queue ... Use the __preferred_lists_for_family queues as storage for all logical_intf objects instead of the __logical_intf_name_family_hash hash table. Move cleanup of logical_intf objects to cleanup of the respective queues. Use the hash table key free function to manage the key objects. Change-Id: I3f9628fbde0c9c71dc6afcfc95bfd54a5b12d6fa	2 years ago
Richard Fuchs	68b7bfa72c	MT#55283 introduce dedicated intf_key struct ... Change-Id: I658afeabde10d21a7a8587e159481517a2498f8f	2 years ago