From f2ec16f0c231c478a0cb65ece85f7adc50250795 Mon Sep 17 00:00:00 2001 From: Richard Fuchs Date: Mon, 7 Sep 2026 10:30:47 -0400 Subject: [PATCH] MT#55283 remove largely useless error flag Change-Id: I95831d6376ed13fe4dbd79563883d50933ac1ad0 --- lib/bencode.c | 7 +------ lib/bencode.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/bencode.c b/lib/bencode.c index 1bc003bf0..c0dd87662 100644 --- a/lib/bencode.c +++ b/lib/bencode.c @@ -93,7 +93,6 @@ int bencode_buffer_init(bencode_buffer_t *buf) { buf->pieces = __bencode_piece_new(0); if (!buf->pieces) return -1; - buf->error = 0; return 0; } @@ -104,8 +103,6 @@ void *bencode_buffer_alloc(bencode_buffer_t *buf, size_t size) { if (!buf) return NULL; - if (buf->error) - return NULL; piece = buf->pieces; @@ -113,10 +110,8 @@ void *bencode_buffer_alloc(bencode_buffer_t *buf, size_t size) { goto alloc; piece = __bencode_piece_new(size); - if (!piece) { - buf->error = 1; + if (!piece) return NULL; - } piece->next = buf->pieces; buf->pieces = piece; diff --git a/lib/bencode.h b/lib/bencode.h index 7129af791..36634d0cd 100644 --- a/lib/bencode.h +++ b/lib/bencode.h @@ -41,7 +41,6 @@ struct bencode_item { struct bencode_buffer { struct __bencode_buffer_piece *pieces; - unsigned int error:1; /* set to !0 if allocation failed at any point */ };