From d86f51ac547a8718ddee03efc9399be2e3dc049e Mon Sep 17 00:00:00 2001 From: Donat Zenichev Date: Mon, 11 May 2026 14:56:27 +0200 Subject: [PATCH] MT#61856 monologue_publish: refactor the func for ports Add the error alias for ports allocation failure and use it where possible. Change-Id: I6095c44385508ab9626a9582ef314500061708f1 --- daemon/call.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/daemon/call.c b/daemon/call.c index 0dd21881e..b414f6462 100644 --- a/daemon/call.c +++ b/daemon/call.c @@ -4456,7 +4456,7 @@ int monologue_publish(struct call_monologue *ml, sdp_streams_q *streams, sdp_ng_ struct endpoint_map *em = __get_endpoint_map(media, num_ports, NULL, flags, true); if (!em) - return -1; // XXX error - no ports + goto error_ports; __num_media_streams(media, num_ports); @@ -4476,14 +4476,16 @@ int monologue_publish(struct call_monologue *ml, sdp_streams_q *streams, sdp_ng_ sdp_sp_move(&media->sp, sp); } - if (!monologue_open_ports(ml)) { - ilog(LOG_ERR, "Error allocating media ports"); - return -1; - } + if (!monologue_open_ports(ml)) + goto error_ports; monologue_media_start(ml); return 0; + +error_ports: + ilog(LOG_ERR, "Error allocating media ports"); + return -1; } /* called with call->master_lock held in W */