From c6b214cda14fef96a5a54dd9a78e5024a757042e Mon Sep 17 00:00:00 2001
From: Donat Zenichev <dzenichev@sipwise.com>
Date: Tue, 1 Oct 2024 11:33:09 +0200
Subject: [PATCH] MT#60476 print_sdp_media_section: return void
Instead of returning a pointer to ps, just return void,
because previously used pointer (by sdp_replace) is
not used by any other function.
Change-Id: If2e211b98ab801061f40210b571804ff8184124f
---
daemon/sdp.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/daemon/sdp.c b/daemon/sdp.c
index fad58cf5c..ea64a3d1c 100644
--- a/daemon/sdp.c
+++ b/daemon/sdp.c
@@ -2789,7 +2789,7 @@ static void print_sdp_session_section(GString *s, sdp_ng_flags *flags,
}
/* TODO: rework an appending of parameters in terms of sdp attribute manipulations */
-static struct packet_stream *print_sdp_media_section(GString *s, struct call_media *media,
+static void print_sdp_media_section(GString *s, struct call_media *media,
const endpoint_t *address, struct call_media *source_media,
struct packet_stream *rtp_ps,
packet_stream_list *rtp_ps_link, sdp_ng_flags *flags)
@@ -2799,7 +2799,7 @@ static struct packet_stream *print_sdp_media_section(GString *s, struct call_med
if (source_media) {
/* just print out all original values and attributes */
sdp_out_original_media_attributes(s, media, address, source_media, rtp_ps, flags);
- return NULL;
+ return;
}
/* add attributes and connection information only when audio is accepted */
@@ -2810,8 +2810,7 @@ static struct packet_stream *print_sdp_media_section(GString *s, struct call_med
/* print zeroed address for the non accepted media, see RFC 3264 */
sdp_out_add_media_connection(s, media, rtp_ps, NULL, flags);
-
- return NULL;
+ return;
}
struct call_monologue *monologue = media->monologue;
@@ -2874,7 +2873,7 @@ static struct packet_stream *print_sdp_media_section(GString *s, struct call_med
append_attr_to_gstring(s, "end-of-candidates", NULL, flags, media->type_id);
}
- return ps_rtcp;
+ return;
}
static void sdp_out_add_origin(GString *out, struct call_monologue *monologue,