From b8a0dd52eee70c7a6efb62eac00e9fd4e49acf21 Mon Sep 17 00:00:00 2001 From: Donat Zenichev Date: Mon, 25 May 2026 17:17:23 +0200 Subject: [PATCH] MT#61856 media_player: get db id, release mysql res Not released in case of success or failure on `cache_fn()`. Just fix it. Change-Id: Ia06141141c74d870ac70aac96047b532210c5482 --- daemon/media_player.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/daemon/media_player.c b/daemon/media_player.c index 2982f42bd..3ca403a8f 100644 --- a/daemon/media_player.c +++ b/daemon/media_player.c @@ -1980,17 +1980,20 @@ success:; unsigned long *lengths = mysql_fetch_lengths(res); err = "empty result from database"; if (!row || !lengths || !row[0] || !lengths[0]) { - mysql_free_result(res); - goto err; + goto release_res; } err = "failed to insert data into cache"; if (!cache_fn(row[0], lengths[0], id)) - goto err; + goto release_res; *out = dup_fn(row[0], lengths[0]); + mysql_free_result(res); return NULL; +release_res: + if (res) + mysql_free_result(res); err: if (query) ilog(LOG_ERR, "Failed to read media from database (used query '%s'): %s", query, err);