mirror of https://github.com/sipwise/rtpengine.git
Ref #2211 "set rediscmdtimeout 0" reconnects the Redis connections, but each of the three calls is guarded by rtpe_redis instead of its own pointer: - with --redis and no notification connection (no --redis-subscribe and no subscribed keyspace), redis_reconnect(rtpe_redis_notify) locks a NULL mutex and rtpengine crashes; - with --redis-write and no --redis, the write connection is never reconnected, so its command timeout is never cleared. Guard each call with its own pointer, as the non-zero branch already does. Tested by auto-daemon-tests-redis-errors.pl, added later in this series ("set rediscmdtimeout 0" over the ng "cli" command with --redis only): without this change rtpengine crashes and never replies. The change is first in the series so that it can be taken on its own. Change-Id: Ia458a6eb0b70a6906ab410fd91087ad5af581f3b (cherry picked from commitmr26.2.120bcdce73c) (cherry picked from commitc0619b2e92)
parent
8096876843
commit
b6def2dbd3
Loading…
Reference in new issue