mirror of https://github.com/sipwise/rtpengine.git
Ref #2211 redis_connect() finds "role:" in the INFO reply and compares what follows with memcmp(): 11 bytes for "role:master", 19 for "role:active-replica" and 10 for "role:slave". memcmp() may read all n bytes, so a reply that ends less than 19 bytes after "role:" (for example a replica's "role:slave\r\n" with nothing after it) is read past its end. Real Redis and KeyDB servers send many more lines after the role, so this does not show in practice, but AddressSanitizer aborts on it (heap-buffer-overflow in the memcmp interceptor) with a minimal reply, such as one from a test server or a proxy. Use strncmp(): hiredis NUL-terminates the reply string, so the compare stops at its end. Tested by auto-daemon-tests-redis-errors.pl, added later in this series, which answers a reconnect's INFO with just "role:slave": an ASan build aborts there without this change. The change is early in the series so that it can be taken on its own. Change-Id: Icdf3d3a23464d861f57406436328d0b166794362 (cherry picked from commitmr26.3.1e5ff3ea8af) (cherry picked from commitbb58e6a8f3)
parent
638e34bb81
commit
a786bec2cc
Loading…
Reference in new issue