From a6719e93297cb7e9e9bc0e53576c47c9687125bc Mon Sep 17 00:00:00 2001 From: Donat Zenichev Date: Fri, 27 Sep 2024 09:25:13 +0200 Subject: [PATCH] MT#55283 __get_media: NULL assigned but not used The `med` is assigned to NULL, which however doesn't serve any purpose. To fix this defect report, just remove the redundant assignment. Fixes the: *** CID 1600020: Code maintainability issues (UNUSED_VALUE) /daemon/call.c: 690 in __get_media() 684 med = g_hash_table_lookup(ml->media_ids, &sp->media_id); 685 if (med) { 686 if (med->type_id == sp->type_id) 687 return med; 688 ilogs(ice, LOG_WARN, "Ignoring media ID '" STR_FORMAT "' as media type doesn't match. " 689 "Was media ID changed?", STR_FMT(&sp->media_id)); >>> CID 1600020: Code maintainability issues (UNUSED_VALUE) >>> Assigning value "NULL" to "med" here, but that stored value is overwritten before it can be used. 690 med = NULL; 691 } 692 if (flags->trickle_ice) 693 ilogs(ice, LOG_ERR, "Received trickle ICE SDP fragment with unknown media ID '" 694 STR_FORMAT "'", 695 STR_FMT(&sp->media_id)); Change-Id: I9871be9cab8928a8e5b6ad2a5e403b9ee3d44295 --- daemon/call.c | 1 - 1 file changed, 1 deletion(-) diff --git a/daemon/call.c b/daemon/call.c index 76bc6295d..556dea4d1 100644 --- a/daemon/call.c +++ b/daemon/call.c @@ -687,7 +687,6 @@ static struct call_media *__get_media(struct call_monologue *ml, const struct st return med; ilogs(ice, LOG_WARN, "Ignoring media ID '" STR_FORMAT "' as media type doesn't match. " "Was media ID changed?", STR_FMT(&sp->media_id)); - med = NULL; } if (flags->trickle_ice) ilogs(ice, LOG_ERR, "Received trickle ICE SDP fragment with unknown media ID '"