From 9c8075ca8797f7d88a9c3ed2715435024cc9a21e Mon Sep 17 00:00:00 2001 From: Richard Fuchs Date: Thu, 28 Feb 2013 13:30:21 -0500 Subject: [PATCH] agents MUST ignore all other attributes that follow MESSAGE-INTEGRITY --- daemon/sdp.c | 1 + daemon/stun.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/daemon/sdp.c b/daemon/sdp.c index 3273a3c20..b733c75f9 100644 --- a/daemon/sdp.c +++ b/daemon/sdp.c @@ -857,6 +857,7 @@ int sdp_replace(struct sdp_chopper *chop, GQueue *sessions, struct call *call, goto error; if (flags->ice_force) { + /* XXX locking here? */ create_random_string(call, &rtp->up->ice_ufrag[0], 8); create_random_string(call, &rtp->up->ice_pwd, 28); diff --git a/daemon/stun.c b/daemon/stun.c index 1f6b05ba1..193a46e30 100644 --- a/daemon/stun.c +++ b/daemon/stun.c @@ -65,7 +65,7 @@ static int stun_attributes(struct stun_attrs *out, str *s) { break; case 0x0008: /* message-integrity */ out->msg_integrity = attr; - break; + goto out; case 0x0025: /* use-candidate */ out->use = 1; @@ -85,6 +85,7 @@ static int stun_attributes(struct stun_attrs *out, str *s) { } } +out: return 0; }