From 9a3f33a7030473679b8ee73ce86a7860c409e88c Mon Sep 17 00:00:00 2001 From: Richard Fuchs Date: Wed, 11 Mar 2026 17:21:05 -0400 Subject: [PATCH] MT#55283 fix stream close race condition Using the stream object after dropping the reference is unsafe. Change-Id: I58df474272cc7e168d6d65e5f6ace3a42fe22ef1 --- kernel-module/nft_rtpengine.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel-module/nft_rtpengine.c b/kernel-module/nft_rtpengine.c index b50e0d96d..5d1f8c9ab 100644 --- a/kernel-module/nft_rtpengine.c +++ b/kernel-module/nft_rtpengine.c @@ -1223,12 +1223,12 @@ static void stream_put(struct re_stream *stream) { if (!stream) return; - if (!atomic_dec_and_test(&stream->refcnt)) { - /* if this is an open file being closed and there's a del_stream() - * waiting for us, we need to wake up the sleeping del_stream() */ - wake_up_interruptible(&stream->close_wq); + /* if this is an open file being closed and there's a del_stream() + * waiting for us, we need to wake up the sleeping del_stream() */ + wake_up_interruptible(&stream->close_wq); + + if (!atomic_dec_and_test(&stream->refcnt)) return; - } DBG("Freeing stream object\n");