From 953ac7cb6371cf6fc6c7bc9a4ed65cd3aa2871a1 Mon Sep 17 00:00:00 2001 From: Arman Bahlakeh Date: Thu, 22 Oct 2026 19:16:32 +0200 Subject: [PATCH] MT#55283 tests: cover stranded packets and the wrap-around window in the sequencer test6: lost / received / lost with forced emissions; the second forced emission must return the lower queued packet, not the one that arrived last. test7: a packet exactly one ring size ahead across the 65535->0 wrap-around must be handled as a seq reset. Both tests fail on the previous sequencer code. Change-Id: I47c5d0b961856255cb204fbcf2e656cf01b49d7d (cherry picked from commit eaa2b75c42a9f29f0df8e8276aac7c03ffdd88ba) --- t/test-sequencer.c | 115 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 115 insertions(+) diff --git a/t/test-sequencer.c b/t/test-sequencer.c index f2d7d254c..b8b868f62 100644 --- a/t/test-sequencer.c +++ b/t/test-sequencer.c @@ -503,12 +503,127 @@ void test5(void) { } +// a lost-packet emission must not strand lower queued packets behind a_idx +void test6(void) { + packet_sequencer_t ps = {0}; + packet_sequencer_init(&ps, ffunc, false); + + void *p; + int i; + num_freed = 0; + + seq_packet_t pks[5] = {0}; + pks[0].seq = 0; + pks[1].seq = 2; + pks[2].seq = 4; + pks[3].seq = 130; + pks[4].seq = 131; + + i = packet_sequencer_insert(&ps, &pks[0]); + assert(i == 0); + p = packet_sequencer_next_packet(&ps); + assert(p == &pks[0]); + p = packet_sequencer_next_packet(&ps); + assert(p == NULL); + + // seq 1 lost + i = packet_sequencer_insert(&ps, &pks[1]); + assert(i == 2); + p = packet_sequencer_next_packet(&ps); + assert(p == NULL); + + // seq 3 lost + i = packet_sequencer_insert(&ps, &pks[2]); + assert(i == 2); + p = packet_sequencer_next_packet(&ps); + assert(p == NULL); + + // forced emission of seq 2 (lost-packet path); seq 4 stays queued + p = packet_sequencer_force_next_packet(&ps); + assert(p == &pks[1]); + assert(ps.lost_count == 1); + p = packet_sequencer_next_packet(&ps); + assert(p == NULL); + + // a packet far ahead arrives; a_nxt must still point at seq 4 + i = packet_sequencer_insert(&ps, &pks[3]); + assert(i == 2); + p = packet_sequencer_next_packet(&ps); + assert(p == NULL); + + // forced emission must give seq 4, not seq 130 + p = packet_sequencer_force_next_packet(&ps); + assert(p == &pks[2]); + assert(ps.lost_count == 2); + assert(ps.roc == 0); + + p = packet_sequencer_force_next_packet(&ps); + assert(p == &pks[3]); + assert(ps.lost_count == 127); + + i = packet_sequencer_insert(&ps, &pks[4]); + assert(i == 0); + p = packet_sequencer_next_packet(&ps); + assert(p == &pks[4]); + p = packet_sequencer_next_packet(&ps); + assert(p == NULL); + + assert(ps.lost_count == 127); + assert(ps.roc == 0); + assert(ps.n_pks == 0); + assert(num_freed == 0); + + packet_sequencer_destroy(&ps); +} + +// a packet exactly one ring size ahead across the wrap-around is a seq reset +void test7(void) { + packet_sequencer_t ps = {0}; + packet_sequencer_init(&ps, ffunc, false); + + void *p; + int i; + num_freed = 0; + + seq_packet_t pks[3] = {0}; + pks[0].seq = 65534; + pks[1].seq = 0; + pks[2].seq = 127; + + i = packet_sequencer_insert(&ps, &pks[0]); + assert(i == 0); + p = packet_sequencer_next_packet(&ps); + assert(p == &pks[0]); + + // seq 65535 lost, seq 0 queued + i = packet_sequencer_insert(&ps, &pks[1]); + assert(i == 2); + p = packet_sequencer_next_packet(&ps); + assert(p == NULL); + + // seq 127 is 128 ahead of the expected 65535: a reset, not the head slot + i = packet_sequencer_insert(&ps, &pks[2]); + assert(i == 1); + assert(num_freed == 1); + p = packet_sequencer_next_packet(&ps); + assert(p == &pks[2]); + p = packet_sequencer_next_packet(&ps); + assert(p == NULL); + + assert(ps.lost_count == 0); + assert(ps.n_pks == 0); + + packet_sequencer_destroy(&ps); +} + int main(void) { test1(); test2(); test3(); test4(); test5(); + test6(); + test7(); return 0; }