From 923da556c9ff125c94a1afcc84f83d4cd9d23a01 Mon Sep 17 00:00:00 2001 From: Donat Zenichev Date: Wed, 20 May 2026 18:01:22 +0200 Subject: [PATCH] MT#61856 main: validate more time/count options Some of the values aren't actually checked, such as: `redis_disable_time`, `mqtt_publish_interval`, `dtx_lag`, `dtx_delay`, `dtx_shift` and `max_dtx`. Add consistent validation where negative values are not meaningful. Change-Id: Ibb6e128ec71253f4e17c1232e3c90de44ded050b --- daemon/main.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/daemon/main.c b/daemon/main.c index f0616b00d..f58e6f147 100644 --- a/daemon/main.c +++ b/daemon/main.c @@ -1245,11 +1245,28 @@ static void options(int *argc, char ***argv, charp_ht templates) { rtpe_config.rtcp_interval_us = 5000 * 1000LL; rtpe_config.redis_disable_time_us = redis_disable_time * 1000000LL; + if (rtpe_config.redis_disable_time_us < 0) + die("Invalid negative redis-disable-time"); + rtpe_config.mqtt_publish_interval_us = mqtt_publish_interval * 1000LL; + if (rtpe_config.mqtt_publish_interval_us < 0) + die("Invalid negative mqtt-publish-interval"); + rtpe_config.dtx_lag_us = dtx_lag * 1000LL; + if (rtpe_config.dtx_lag_us < 0) + die("Invalid negative dtx-lag"); + rtpe_config.dtx_delay_us = dtx_delay * 1000LL; + if (rtpe_config.dtx_delay_us < 0) + die("Invalid negative dtx-delay"); + rtpe_config.dtx_shift_us = dtx_shift * 1000LL; + if (rtpe_config.dtx_shift_us < 0) + die("Invalid negative dtx-shift"); + rtpe_config.max_dtx_us = max_dtx * 1000000LL; + if (rtpe_config.max_dtx_us < 0) + die("Invalid negative max-dtx"); if (redisps) { if (redis_ep_parse(&rtpe_config.redis_ep, &rtpe_config.redis_db, &rtpe_config.redis_hostname,