MT#55283 remove unused argument

Even though both true and false are set in different calls to the
function, there's no effective difference in output.

Change-Id: I0d29dbf2d8041523b6b28bb0c0270bb6b414dcb5

daemon/call_interfaces.c

@@ -3497,7 +3497,7 @@ const char *call_publish_ng(ng_buffer *ngbuf, bencode_item_t *input, bencode_ite
 	if (ret)
 		ilog(LOG_ERR, "Publish error"); // XXX close call? handle errors?
 
-	ret = sdp_create(&sdp_out, ml, &flags, false, true);
+	ret = sdp_create(&sdp_out, ml, &flags, true);
 	if (!ret) {
 		save_last_sdp(ml, &sdp_in, &parsed, &streams);
 		bencode_buffer_destroy_add(output->buffer, g_free, sdp_out.s);
@@ -3578,7 +3578,7 @@ const char *call_subscribe_request_ng(bencode_item_t *input, bencode_item_t *out
 			return "Failed to rewrite SDP";
 	} else {
 		/* create new SDP */
-		ret = sdp_create(&sdp_out, dest_ml, &flags, false, false);
+		ret = sdp_create(&sdp_out, dest_ml, &flags, false);
 	}
 
 	/* place return output SDP */

daemon/janus.c

@@ -650,7 +650,7 @@ static const char *janus_videoroom_join(struct websocket_message *wm, struct jan
 			return "Subscribe error";
 
 		/* create SDP */
-		ret = sdp_create(jsep_sdp_out, dest_ml, &flags, true, true);
+		ret = sdp_create(jsep_sdp_out, dest_ml, &flags, true);
 
 		if (!dest_ml->janus_session)
 			dest_ml->janus_session = obj_get(session);
@@ -880,7 +880,7 @@ static const char *janus_videoroom_configure(struct websocket_message *wm, struc
 		// XXX check there's only one audio and one video stream?
 
 		g_auto(str) sdp_out = STR_NULL;
-		ret = sdp_create(&sdp_out, ml, &flags, true, true);
+		ret = sdp_create(&sdp_out, ml, &flags, true);
 		if (ret)
 			return "Publish error";
 

daemon/sdp.c

@@ -3397,7 +3397,7 @@ error:
 }
 
 int sdp_create(str *out, struct call_monologue *monologue, const sdp_ng_flags *flags,
-		 bool print_other_sess_attrs, bool print_other_media_attrs)
+		 bool print_other_media_attrs)
 {
 	const char *err = NULL;
 	GString *s = NULL;
@@ -3431,8 +3431,7 @@ int sdp_create(str *out, struct call_monologue *monologue, const sdp_ng_flags *f
 	g_string_append_printf(s, "s=%s\r\n", rtpe_config.software_id);
 	g_string_append(s, "t=0 0\r\n");
 
-	if (print_other_sess_attrs)
-		monologue->sdp_attr_print(s, monologue, flags);
+	monologue->sdp_attr_print(s, monologue, flags);
 
 	for (unsigned int i = 0; i < monologue->medias->len; i++) {
 		media = monologue->medias->pdata[i];

include/sdp.h

@@ -61,7 +61,7 @@ int sdp_replace(struct sdp_chopper *, sdp_sessions_q *, struct call_monologue *,
 		bool print_other_attrs);
 int sdp_is_duplicate(sdp_sessions_q *sessions);
 int sdp_create(str *out, struct call_monologue *, const sdp_ng_flags *flags,
-		bool print_other_sess_attrs, bool print_other_media_attrs);
+		bool print_other_media_attrs);
 const char *sdp_get_sendrecv(struct call_media *media);
 
 int sdp_parse_candidate(struct ice_candidate *cand, const str *s); // returns -1, 0, 1