From 88f13a644d896090dda2a09b66cac5752afe00cb Mon Sep 17 00:00:00 2001 From: Donat Zenichev Date: Tue, 12 May 2026 11:08:55 +0200 Subject: [PATCH] MT#61856 make `call_timer_delete_monologues()` return void It never returns anything apart 0 (`ret` always remains set to the originally defined 0). So just make it returning void. Change-Id: Ibc0a1b86f1820055f3459dacbdfea0274fbf7377 --- daemon/call.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/daemon/call.c b/daemon/call.c index 79666ba1a..712e6c9af 100644 --- a/daemon/call.c +++ b/daemon/call.c @@ -77,9 +77,8 @@ static struct media_subscription *__subscribe_medias_both_ways(struct call_media static void call_stream_crypto_reset(struct packet_stream *ps); /* called with call->master_lock held in R */ -static int call_timer_delete_monologues(call_t *c) { +static void call_timer_delete_monologues(call_t *c) { struct call_monologue *ml; - int ret = 0; int64_t min_deleted = 0; bool update = false; @@ -110,7 +109,6 @@ static int call_timer_delete_monologues(call_t *c) { rwlock_lock_r(&c->master_lock); // coverity[missing_unlock : FALSE] - return ret; } @@ -165,8 +163,7 @@ static void call_timer_iterator(call_t *c, struct iterator_helper *hlp) { goto delete; if (c->ml_deleted_us && rtpe_now >= c->ml_deleted_us) { - if (call_timer_delete_monologues(c)) - goto delete; + call_timer_delete_monologues(c); } // conference: call can be created without participants added