From 72dad51a1082ee99551db28ee08ff8d37b8cce08 Mon Sep 17 00:00:00 2001 From: Victor Seva Date: Fri, 28 Oct 2022 10:43:47 +0200 Subject: [PATCH] TT#14008 websockets test: expose the real problem when connecting related to #1497 #1549 > ====================================================================== > ERROR: setUpClass (__main__.TestWSJanus) > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/code/t/auto-daemon-tests-websocket.py", line 114, in setUpClass > eventloop.run_until_complete(get_ws(cls, "janus-protocol")) > File "/usr/lib/python3.10/asyncio/base_events.py", line 646, in run_until_complete > return future.result() > File "/code/t/auto-daemon-tests-websocket.py", line 23, in get_ws > cls._ws = await connect( > File "/usr/lib/python3/dist-packages/websockets/legacy/client.py", line 622, in __await_impl__ > transport, protocol = await self._create_connection() > File "/usr/lib/python3.10/asyncio/base_events.py", line 1089, in create_connection > transport, protocol = await self._create_connection_transport( > File "/usr/lib/python3.10/asyncio/base_events.py", line 1107, in _create_connection_transport > protocol = protocol_factory() > File "/usr/lib/python3/dist-packages/websockets/legacy/client.py", line 160, in __init__ > super().__init__(**kwargs) > File "/usr/lib/python3/dist-packages/websockets/legacy/protocol.py", line 154, in __init__ > self._drain_lock = asyncio.Lock( > File "/usr/lib/python3.10/asyncio/locks.py", line 78, in __init__ > super().__init__(loop=loop) > File "/usr/lib/python3.10/asyncio/mixins.py", line 17, in __init__ > raise TypeError( > TypeError: As of 3.10, the *loop* parameter was removed from Lock() since it is no longer necessary > > ---------------------------------------------------------------------- Change-Id: I3178c54ed7eb40b9cc06769c1f1e237e0d58f966 --- t/auto-daemon-tests-websocket.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/auto-daemon-tests-websocket.py b/t/auto-daemon-tests-websocket.py index 9baaf5fd0..5627bbfdc 100644 --- a/t/auto-daemon-tests-websocket.py +++ b/t/auto-daemon-tests-websocket.py @@ -11,7 +11,7 @@ import traceback import unittest import uuid -import websockets +from websockets import connect eventloop = None @@ -20,11 +20,11 @@ eventloop = None async def get_ws(cls, proto): for _ in range(1, 300): try: - cls._ws = await websockets.connect( + cls._ws = await connect( "ws://127.0.0.1:9191/", subprotocols=[proto] ) break - except: + except FileNotFoundError: await asyncio.sleep(0.1)