From 865c412b435ecdc18cd46dda2cf818469da28593 Mon Sep 17 00:00:00 2001 From: Alessio Garzi Date: Fri, 7 Nov 2025 11:51:41 +0100 Subject: [PATCH] MT#63353 Force permissions to 640 for log file If file is not created, after creation, set it with perm 640 otherwise the following tests will fail 09:46:40 not ok 24 - Command: find /var/log/ngcp/ -maxdepth 1 -type f -size +0 -perm /o+rwx: stdout: Expected "object: *bytes.Reader" to have patterns ["!/./"] the missing elements were ["!/./"] [sipwise-lab-trunk] root@sp1:~# find /var/log/ngcp/ -maxdepth 1 -type f -size +0 -perm /o+rwx /var/log/ngcp/ngcp-reminder.log [sipwise-lab-trunk] root@sp1:~# ls -lah /var/log/ngcp/ngcp-reminder.log -rw-r--r-- 1 root root 9.3K Nov 7 11:41 /var/log/ngcp/ngcp-reminder.log Change-Id: Ia441d9cad7db4525c60e6e8d4114ca273226dca5 (cherry picked from commit 852d7c9a08e2c4487c7f03f257ab4ca1d153bc75) (cherry picked from commit 8620ad434b85892ecfae211194463552fe993837) --- ngcp-reminder | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/ngcp-reminder b/ngcp-reminder index ec85a35..d714f22 100644 --- a/ngcp-reminder +++ b/ngcp-reminder @@ -34,6 +34,16 @@ file_formatter = logging.Formatter('%(asctime)s [%(levelname)s] %(message)s') file_handler.setFormatter(file_formatter) logger.addHandler(file_handler) +# Ensure proper permissions and ownership for the log file +try: + if os.path.exists(LOG_FILE): + uid = pwd.getpwnam(OWNER).pw_uid + gid = pwd.getpwnam(OWNER).pw_gid + os.chown(LOG_FILE, uid, gid) + os.chmod(LOG_FILE, 0o640) # rw-r----- +except Exception as e: + logger.warning(f"Unable to set log file ownership or permissions: {e}") + # --- Configuration reader ---------------------------------------------------- def read_config(path):