You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Michael Prokop 57701e3ed0 TT#36827 Do not set permissions on output files of type symlink ... If the output file has been replaced by a symlink then the permissions of the symlink's target are adjusted. This is clearly unwanted and unexpected behavior. This can happen e.g. when masking a service via systemd's systemctl, demonstration: | sipwise@sp1:~$ sudo rm /etc/systemd/system/ntp.service | sipwise@sp1:~$ sudo systemctl mask ntp | Created symlink /etc/systemd/system/ntp.service → /dev/null. | sipwise@sp1:~$ ls -la /dev/null | crw-rw-rw- 1 root root 1, 3 May 12 01:54 /dev/null | sipwise@sp1:~$ sudo ngcpcfg build /etc/systemd/system/ntp.service | 2018-05-15 16:06:47: Checking state of local storage: | 2018-05-15 16:06:47: OK: nothing to pull | 2018-05-15 16:06:47: configs were checked successfuly | 2018-05-15 16:06:47: No patchtt files found, nothing to patch. | Loading /etc/ngcp-config/config.yml in memory: OK | Loading /etc/ngcp-config/network.yml in memory: OK | Loading /etc/ngcp-config/constants.yml in memory: OK | 2018-05-15 16:06:48: Generating /etc/systemd/system/ntp.service: OK | sipwise@sp1:~$ ls -la /dev/null | cr--r--r-- 1 root root 1, 3 May 12 01:54 /dev/null Instead check whether the expected output file is a symlink and if so don't modify permissions at all, but warn instead. Change-Id: I1c1bb0941a8a2f599652b7c089efd63ff33ca455		8 years ago
debian	Release new version 6.3.0.0+0~mr6.3.0.0	8 years ago
docs	TT#34758 Change description of init-mgmt	8 years ago
etc/ngcp-config	MT#17781 Define NGCPCTL_BASE to fix PRO/Carrier installation	10 years ago
functions	TT#24920 Initial commit for 'ngcpcfg patch'	8 years ago
helper	TT#36827 Do not set permissions on output files of type symlink	8 years ago
hooks	MT#22361 Remember file permissions through pre-commit hook + restore-permissions helper script	10 years ago
lib	TT#24841 don't return empty strings from IP helper scripts	8 years ago
sbin	TT#34758 Change description of init-mgmt	8 years ago
scripts	TT#35912 systemd does not always cleanup .wants/ relationships by itself	8 years ago
t	TT#33030 allow overwriting entire subkeys with similar types	8 years ago
testsuite	TT#26264 Use ngcp-service instead of directly calling /etc/init.d/<service>	8 years ago
.gitignore	MT#16391 Initial tests using pytest	9 years ago
.gitreview	MT#7505 Add gitreview file	12 years ago
Makefile	TT#14817 Add new network.yml dynamic validator program	9 years ago