10 Commits (cf71caa1672a7f66ec8416bc91e75207b37a41d4)

Author	SHA1	Message	Date
Guillem Jover	b89b447e64	TT#177550 initialise: Add sites/current to the default .gitignore ... This is the symlink pointing to the current site for this site, which cannot be committed to git, or we'd get constant conflicts when multiple sites commit their own. Change-Id: I054afc15bb3a52d0ca2357db5ea4a152cfff035b	3 years ago
Guillem Jover	a4f3d9d2de	TT#156156 Switch to «-» as the word separator in CLI options ... The prevalent convention in the project is to use «-» instead of «_» to split words in options. Switch the options to that, and keep backwards compatibility option alias that emits a deprecation warning while people transition to the new names. The alias will be removed on the next LTS. Change-Id: I8bb7f26f8a766f7ea76ba2d9e49b793e5cb8d11e	3 years ago
Michael Prokop	0dda93ad97	TT#82051 Shellcheck fixes ... shellcheck v0.7.1 complains about a bunch of issues: SC1083: This { is literal. Check expression (missing ;/\n?) or quote it. SC1083: This } is literal. Check expression (missing ;/\n?) or quote it. SC1090: Can't follow non-constant source. Use a directive to specify location. SC2034: foo appears unused. Verify it or export it. SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2128: Expanding an array without an index only gives the first element. SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2155: Declare and assign separately to avoid masking return values. SC2162: read without -r will mangle backslashes. SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2237: Use [ -z .. ] instead of ! [ -n .. ]. We're still bound to support shellcheck v0.3.4 and sadly this version fails hard when using the modern "shellcheck source=" directives to address SC1090 and SC1091. It's failing like: | not ok 1 source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009] | not ok 2 source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073] | not ok 3 source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072] So until we can get rid of supporting this ancient shellcheck version, instead of using: | # shellcheck source=etc/ngcp-config/ngcpcfg.cfg | # shellcheck source=functions/init | # shellcheck source=functions/logs | # shellcheck source=functions/main we need to place disable=SC1090 and disable=SC1091 accordingly. Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e	5 years ago
Mykola Malkov	1a9d71268d	TT#47956 Subtract HA repo setup from 'initialise' into 'init-shared' ... We need to initialize ngcpcfg without HA repo, to solve chicken-eggs problem about git hooks handking. Also it will be useful to build glusterfs configs from tt2 templates and yml configuration. Then start glusterfs and store HA repo on glusterfs. In this case ngcp-installer will be able to call: > ngcpcfg initialise --without_shared > ngcpcfg set ... > ngcpcfg build ... > ngcpcfg init-shared > ngcpcfg apply "Applying everything together" In the past it was not so critical problem until we started taking care about the files permissions which are coming from ngcp-template-* packages and transferred to POSIX perms via ngcpcfg. One of the problems there is 'git clone' (which is a part of HA setup initialisation). It resets file perms if they are not yet stored into file '.ngcpcfg_perms'. Change-Id: I3cdc93f309f0b899e626779afb1e71f64b2cb953	7 years ago
Guillem Jover	b2c87aa4a9	TT#47373 Remove path hardcoding for hooks handling ... When running the test suite, in case we need to cover the code paths that are handling the hooks, we should not assume the files are installed in the system directories. Change-Id: I1cd09eaf186d28093eb03ad5e9fc096fe7d63a3e	7 years ago
Alexander Lutay	9b7ce2abf2	TT#44969 Extract git status check to common function (for further refactoring) ... 'git status' output has been changed in 2.9 which causes some troubles for us (we didn't change all the places, we missed ngcpcfg-ha.git repo, better to use common code in all the places). Change-Id: Ie664af89ee6d6b31fb3011e763107c41bf4cf00f	7 years ago
Michael Prokop	bd9bf75e4a	TT#11776 Support git v2.9.3 and newer ... When installing Debian/stretch we fail at this stage: | ngcpcfg --no-db-sync commit On first glance it looks like a mariadb issue, though actually it's the git status check inside ngcpcfg that's failing. The reason is that starting with git v2.9.3 there's a different output in its "status" output: | commit 2a0e6cdedab306eccbd297c051035c13d0266343 | Author: Lars Vogel <lars.vogel@gmail.com> | Date: Thu Jun 9 20:19:30 2016 +0200 | | Use "working tree" instead of "working directory" for git status | | Working directory can be easily confused with the current directory. | In one of my patches I already updated the usage of working directory | with working tree for the man page but I noticed that git status also | uses this incorrect term. | | Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> | Signed-off-by: Junio C Hamano <gitster@pobox.com> In Debian/stretch we've 2.11.0-2 and are affected by this change. Adjust the `git status` checks accordingly to support git in all its versions. NOTE: we should consider switching to `git status --porcelain` (see git commit fc5af3bbb2 for some history about it) once we've the testsuite in place. Change-Id: If4223a35083d279e746dce5a80bcb86b52f64025	8 years ago
Michael Prokop	08f68c829b	MT#22361 Remember file permissions through pre-commit hook + restore-permissions helper script ... Git doesn't track file permissions (except for the executable flag). For sensitive data (like the 'ssl' directory and file 'constants.yml' with passwords included) we've to prevent non-root users from accessing those files. hooks/pre-commit is inspired and based on the implementation as present in etckeeper (and luckily we're license compatible) and takes care of storing the file permissions inside file /etc/ngcp-config/.ngcpcfg_perms. The restore-permissions helper script takes care of restoring the permissions after cloning the ngcpcfg repository via ngcpcfg itself (being actions decrypt, pull (PRO-only) + initialise (PRO-only)). It can be executed manually as well via `usr/share/ngcp-ngcpcfg/helper/restore-permissions /etc/ngcp-config/` (or wherever the according ngcpcfg repository is placed at). Regarding the commit integration: git(1) itself doesn't track file permissions, so we can't detect changes to file permissions using git itself. Our new pre-commit hook records file permissions via the .ngcpcfg_perms file. Now by just invoking it during 'ngcpcfg commit' time we can ensure that even if there have been any file permission changes in the working directory the file .ngcpcfg_perms is then up2date and committed. JFTR: The solution via the git pre-commit hook ensures that no matter whether you're using 'ngcpcfg commit …' or 'git commit …' you always get the file permissions handled via .ngcpcfg_perms. Now if you want to change file permissions in a clean working directory and commit *without* using 'ngcpcfg commit' but directly via git itself then you've to use 'git commit --allow-empty ...' and thanks to the pre-commit hook the file .ngcpcfg_perms will still be up2date. Change-Id: I84d608585c626b52112ff649893e232e441c59d8	9 years ago
Victor Seva	eac494cb42	MT#14229 clean shellcheck warnings ... While at it spread support for testsuite Change-Id: I60c4dae5479827b0d28ffa135105d9dbdf603825	10 years ago
Michael Prokop	3436c08361	Initial checkin	12 years ago