15 Commits (ac22b51ee30008fa324ed62d98ee170fa833d54e)

Author	SHA1	Message	Date
Guillem Jover	02055b8f6e	MT#58014 encrypt: Avoid remove leading / messages from tar ... We are prepending an extra / to the pathnames passed to tar, and calling tar from a directory other than the root directory while not telling it to use absolute names so it complains about these two things with the following messages: ,--- tar: Removing leading `/' from member names tar: Removing leading `/' from hard link targets tar: Removing leading `//' from member names tar: Removing leading `//' from hard link targets `--- which is something the user cannot do much about, and it's rather annoying. Change-Id: I9e9c853f26363e451b8883d3c74c5508ba3049dc	1 year ago
Michael Prokop	a456ee2cec	MT#56190 Adjust scripts for shellcheck v0.9.0 ... Fixing issues reported by new shellcheck v0.9.0: 1) SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). https://www.shellcheck.net/wiki/SC2317 (new feature as of shellcheck v0.9.0) 2) SC2086 (info): Double quote to prevent globbing and word splitting. https://www.shellcheck.net/wiki/SC2086 (behavior change with shellcheck v0.9.0) Change-Id: I73d50157f72b772c381cf1bff497079133bc6d09	2 years ago
Alexander Lutay	cdfb5a8f3d	TT#106202 Update Shell code style for scripts/decrypt ... Change-Id: Iaf5f071919a5e181ac34182fd10bf9668dc10279	4 years ago
Michael Prokop	2088c32977	TT#82051 shellcheck fix for console_output() to expand escape sequences ... We are using console_output() from within log_info(), which is invoking `console_output "$*\n"`, so we need to expand the escape sequences (without interpreting other format specifiers), which is exactly what "%b" provides in bash. This is a fixup for previous commit 0dda93ad97 Change-Id: I16f354eb35e13568331e5107aff0d1c80dafb822	5 years ago
Michael Prokop	0dda93ad97	TT#82051 Shellcheck fixes ... shellcheck v0.7.1 complains about a bunch of issues: SC1083: This { is literal. Check expression (missing ;/\n?) or quote it. SC1083: This } is literal. Check expression (missing ;/\n?) or quote it. SC1090: Can't follow non-constant source. Use a directive to specify location. SC2034: foo appears unused. Verify it or export it. SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2128: Expanding an array without an index only gives the first element. SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2155: Declare and assign separately to avoid masking return values. SC2162: read without -r will mangle backslashes. SC2164: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2237: Use [ -z .. ] instead of ! [ -n .. ]. We're still bound to support shellcheck v0.3.4 and sadly this version fails hard when using the modern "shellcheck source=" directives to address SC1090 and SC1091. It's failing like: | not ok 1 source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009] | not ok 2 source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073] | not ok 3 source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072] So until we can get rid of supporting this ancient shellcheck version, instead of using: | # shellcheck source=etc/ngcp-config/ngcpcfg.cfg | # shellcheck source=functions/init | # shellcheck source=functions/logs | # shellcheck source=functions/main we need to place disable=SC1090 and disable=SC1091 accordingly. Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e	5 years ago
Guillem Jover	4bdc9f57df	TT#81051 Use environment variables instead of absolute pathnames ... We should use the environment variables, so that we can support the configured pathnames. Change-Id: Ifc94e83a74c0edfeaaeac0f2d16c55d3dfca179e	5 years ago
Alexander Lutay	f4e5c0b645	TT#65907 Write ngcpcfg PID into ngcpcfg.log file ... It should simplify debug when two ngcpcfg executed in parallel. Change-Id: I5fa77bfe9419c3cff798eaefbdb02f159b7b63c9	6 years ago
Michael Prokop	a42248419e	TT#22411 Fix spelling mistakes/typos ... s/Syncronizes/Synchronizes/ s/Wheras/Whereas/ s/configuation/configuration/ s/exisiting/existing/ s/explicitely/explicitly/ s/files files/files/ s/has has/has/ s/initialise initialise/initialise/ s/mulitple/multiple/ s/ouput/output/ s/propogates/propagates/ s/successfull/successful/ s/syncronizes/synchronizes/ s/the the/the/ s/uncommited/uncommitted/ Change-Id: Id13ec889c5de620b675e357d99066688cfc97617	8 years ago
Michael Prokop	f7501760c0	MT#22675 decrypt: ignore shared storage on CE systems ... Change-Id: Ia90d022eabc518e60643019fadc84e8570fba5b3	9 years ago
Alexander Lutay	98c94656ae	MT#19043 decrypt: check for glusterfs 'mgmt-share' instead of 'shared_config' ... We need to use some folder on glusterfs to ensure it is reachable. /mnt/glusterfs/mgmt-share is good enough here as /mnt/glusterfs/shared_config is no longer available. Change-Id: I9f604db9604af41405cfd7b088abb332a463fe4d	9 years ago
Michael Prokop	08f68c829b	MT#22361 Remember file permissions through pre-commit hook + restore-permissions helper script ... Git doesn't track file permissions (except for the executable flag). For sensitive data (like the 'ssl' directory and file 'constants.yml' with passwords included) we've to prevent non-root users from accessing those files. hooks/pre-commit is inspired and based on the implementation as present in etckeeper (and luckily we're license compatible) and takes care of storing the file permissions inside file /etc/ngcp-config/.ngcpcfg_perms. The restore-permissions helper script takes care of restoring the permissions after cloning the ngcpcfg repository via ngcpcfg itself (being actions decrypt, pull (PRO-only) + initialise (PRO-only)). It can be executed manually as well via `usr/share/ngcp-ngcpcfg/helper/restore-permissions /etc/ngcp-config/` (or wherever the according ngcpcfg repository is placed at). Regarding the commit integration: git(1) itself doesn't track file permissions, so we can't detect changes to file permissions using git itself. Our new pre-commit hook records file permissions via the .ngcpcfg_perms file. Now by just invoking it during 'ngcpcfg commit' time we can ensure that even if there have been any file permission changes in the working directory the file .ngcpcfg_perms is then up2date and committed. JFTR: The solution via the git pre-commit hook ensures that no matter whether you're using 'ngcpcfg commit …' or 'git commit …' you always get the file permissions handled via .ngcpcfg_perms. Now if you want to change file permissions in a clean working directory and commit *without* using 'ngcpcfg commit' but directly via git itself then you've to use 'git commit --allow-empty ...' and thanks to the pre-commit hook the file .ngcpcfg_perms will still be up2date. Change-Id: I84d608585c626b52112ff649893e232e441c59d8	9 years ago
Michael Prokop	f009806409	MT#22567 Create /etc/ngcp-config-crypted.tgz* files with more restrict file permissions ... The file should be accessible only to user root. Also don't leave the unencrypted file /etc/ngcp-config-crypted.tgz around. Change-Id: I82f7f36d8561d8d5e82435edb70e11170fa6c082	9 years ago
Victor Seva	eac494cb42	MT#14229 clean shellcheck warnings ... While at it spread support for testsuite Change-Id: I60c4dae5479827b0d28ffa135105d9dbdf603825	10 years ago
Michael Prokop	2deea0fb39	MT#9557 Provide timestamps in console output ... Change-Id: I5be915fa876014cbb9c792b03be325d6595daac9	10 years ago
Michael Prokop	3436c08361	Initial checkin	12 years ago