ngcpcfg

Commit Graph

Author	SHA1	Message	Date
Victor Seva	cb2fe7406a	TT#126250 apply: fix error when called with no arguments introduced at commit `eff9d4ae07` > ngcp-service: info: Action restart skipped, service kamailio-proxy is not for this role > 2021-08-17 14:59:18 lb01a: Synchronizing current with expected services state > /usr/share/ngcp-ngcpcfg/scripts//apply: line 56: $1: unbound variable Change-Id: I75a551327ecb42b7ff6a14a5206b85fb35e5f608	4 years ago
Victor Seva	eff9d4ae07	TT#126250 Bypass 'apply' options into 'build' script It is necessary to allow bypassing '--ignore-shared-storage-check': > ngcpcfg apply --ignore-shared-storage-check Previously 'apply' options were not passing to 'build' script. * docs: - add all supported options in apply - move '--force-all-services' description to services and add it in the list of options Change-Id: I091142d1f74b7b9e09ce94b963ff4bf9dfaa8db7	4 years ago
Alexander Lutay	1b339d2717	Revert "TT#126250 Bypass 'apply' options into 'build' script" It brakes trunk, we have to reconsider implementation here. This reverts commit `41c722a183`. Change-Id: I319c9a9568e250d939864a4c2b9c2a3cdec145e7	4 years ago
Alexander Lutay	41c722a183	TT#126250 Bypass 'apply' options into 'build' script It is necessary to allow bypassing '--ignore-shared-storage-check': > ngcpcfg apply --ignore-shared-storage-check Previously 'apply' options were not passing to 'build' script. Change-Id: Ia01558b05920e6aec10c8206a3747c828b237fc9	4 years ago
Michael Prokop	0dda93ad97	TT#82051 Shellcheck fixes shellcheck v0.7.1 complains about a bunch of issues: SC1083: This { is literal. Check expression (missing ;/\n?) or quote it. SC1083: This } is literal. Check expression (missing ;/\n?) or quote it. SC1090: Can't follow non-constant source. Use a directive to specify location. SC2034: foo appears unused. Verify it or export it. SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2128: Expanding an array without an index only gives the first element. SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2155: Declare and assign separately to avoid masking return values. SC2162: read without -r will mangle backslashes. SC2164: Use 'cd ... \|\| exit' or 'cd ... \|\| return' in case cd fails. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2237: Use [ -z .. ] instead of ! [ -n .. ]. We're still bound to support shellcheck v0.3.4 and sadly this version fails hard when using the modern "shellcheck source=" directives to address SC1090 and SC1091. It's failing like: \| not ok 1 source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009] \| not ok 2 source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073] \| not ok 3 source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072] So until we can get rid of supporting this ancient shellcheck version, instead of using: \| # shellcheck source=etc/ngcp-config/ngcpcfg.cfg \| # shellcheck source=functions/init \| # shellcheck source=functions/logs \| # shellcheck source=functions/main we need to place disable=SC1090 and disable=SC1091 accordingly. Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e	5 years ago
Alexander Lutay	9b7ce2abf2	TT#44969 Extract git status check to common function (for further refactoring) 'git status' output has been changed in 2.9 which causes some troubles for us (we didn't change all the places, we missed ngcpcfg-ha.git repo, better to use common code in all the places). Change-Id: Ie664af89ee6d6b31fb3011e763107c41bf4cf00f	7 years ago
Alexander Lutay	bc1095e596	TT#37257 Add option 'ngcpcfg apply --force-all-services' to force all services restart At the end of installer's 'configuration' section we need to restart all services were touched during the installation (otherwise we need to restart the node completely). The option helps us in this case as etckeeper is not reliable enough during the installation. P.S. we pass options from 'apply' to 'services' now, we should remove 'Unsupported option(s) given: $*' check, otherwise it is failing as 'apply' requires commit message, which cause error on 'services' level: 'Unsupported option(s) given' > 2018-09-13 18:08:33: Error: Unsupported option(s) given: my commit message > 2018-09-13 18:08:34: Did you mean '--dry-run'? Change-Id: I5dac44cd87dc1fc90f81e4ac3a14af32c00f825e	7 years ago
Alexander Lutay	6e554b5717	TT#15824 Fix shellcheck warnings Change-Id: I1e35b67b06ef7e628a34d113a328b5aea2758801	8 years ago
Michael Prokop	bd9bf75e4a	TT#11776 Support git v2.9.3 and newer When installing Debian/stretch we fail at this stage: \| ngcpcfg --no-db-sync commit On first glance it looks like a mariadb issue, though actually it's the git status check inside ngcpcfg that's failing. The reason is that starting with git v2.9.3 there's a different output in its "status" output: \| commit 2a0e6cdedab306eccbd297c051035c13d0266343 \| Author: Lars Vogel <lars.vogel@gmail.com> \| Date: Thu Jun 9 20:19:30 2016 +0200 \| \| Use "working tree" instead of "working directory" for git status \| \| Working directory can be easily confused with the current directory. \| In one of my patches I already updated the usage of working directory \| with working tree for the man page but I noticed that git status also \| uses this incorrect term. \| \| Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> \| Signed-off-by: Junio C Hamano <gitster@pobox.com> In Debian/stretch we've 2.11.0-2 and are affected by this change. Adjust the `git status` checks accordingly to support git in all its versions. NOTE: we should consider switching to `git status --porcelain` (see git commit `fc5af3bbb2` for some history about it) once we've the testsuite in place. Change-Id: If4223a35083d279e746dce5a80bcb86b52f64025	8 years ago
Guillem Jover	b789568b73	MT#17219 Use $@ instead of $* when we need to preserve argument grouping Using $* in some of these places implies losing data about what constituted a single argument. Change-Id: Ic072e68320d65ac86392c31d7665529b913232fd	9 years ago
Guillem Jover	d0b12d1bbc	MT#17219 Do not invoke redundant etckeeper from apply action The commit action already takes care of invoking etckeeper, so there's no need to call it from the apply action. In addition calling it after record_commit_id is either pointless or buggy. Change-Id: I8ccd40f962c24f99b2ae26655c083bb976e47ce9	9 years ago
Guillem Jover	daa68ce21e	MT#17219 Move check invocation inside build script Make the relationship internal, instead of external. So that anything that might end up calling the build script will always do the right thing and we will not forget to perform required actions. Change-Id: Iafc3bc7230c59750de7ec8bf825005011b48f403	9 years ago
Michael Prokop	c9b62658a1	MT#15973 Report in 'status' action when build/apply run is needed In a previous implementation using timestamps we ran into timing problems on slower systems. So instead lets record the git commit ID of the latest ngcpcfg commit and check whether we have a match between this commit and an according ngcpcfg build. If the "ngcpcfg build" was executed without an "ngcpcfg commit" before then we mark it as dirty since we don't have an according git commit available for testing against. Since that's a common workflow we don't report it as a real problem though, instead we inform the user using: \| OK: nothing to build (latest build newer than latest commit) As we commit AFTER the build in the apply action we can use a workaround for this situation, so build and commit state match with each other in that case then. Change-Id: I48e32db6f42b53fe97a0b88805e7ddbee8576133	10 years ago
Michael Prokop	0d828d4108	MT#15973 Revert "MT#15973 Report in 'status' action when build/apply run is needed" This reverts commit `db373d3927`. Conflicts: etc/ngcp-config/ngcpcfg.cfg Until we've a working solution for this let's revert the broken change so we avoid this being a release stopper. Change-Id: If03d9b3913de23c698b430d583dc7babfcc4ff04	10 years ago
Michael Prokop	db373d3927	MT#15973 Report in 'status' action when build/apply run is needed If the latest git commit has a newer timestamp than our latest "build" action then a "build" (or apply) run is required, inform the user about it. Change-Id: I83e2ff47ba54da733d368d78b6616d13d31a66d4	10 years ago
Michael Prokop	24aa4a97fa	MT#15943 Prompt for commit message during 'ngcpcfg apply' on outstanding changes Provide "apply" action as separate script. We don't care about changes related to etckeeper, but just about outstanding commits in /etc/ngcp-config. Change-Id: I47411f00a5085d65cacf9e24fc8a468258d57c31	10 years ago

16 Commits (ac22b51ee30008fa324ed62d98ee170fa833d54e)