5 Commits (9b7ce2abf2dbe46f282b6616eb27dddfa1459023)

Author	SHA1	Message	Date
Alexander Lutay	9b7ce2abf2	TT#44969 Extract git status check to common function (for further refactoring) ... 'git status' output has been changed in 2.9 which causes some troubles for us (we didn't change all the places, we missed ngcpcfg-ha.git repo, better to use common code in all the places). Change-Id: Ie664af89ee6d6b31fb3011e763107c41bf4cf00f	8 years ago
Michael Prokop	bd9bf75e4a	TT#11776 Support git v2.9.3 and newer ... When installing Debian/stretch we fail at this stage: | ngcpcfg --no-db-sync commit On first glance it looks like a mariadb issue, though actually it's the git status check inside ngcpcfg that's failing. The reason is that starting with git v2.9.3 there's a different output in its "status" output: | commit 2a0e6cdedab306eccbd297c051035c13d0266343 | Author: Lars Vogel <lars.vogel@gmail.com> | Date: Thu Jun 9 20:19:30 2016 +0200 | | Use "working tree" instead of "working directory" for git status | | Working directory can be easily confused with the current directory. | In one of my patches I already updated the usage of working directory | with working tree for the man page but I noticed that git status also | uses this incorrect term. | | Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> | Signed-off-by: Junio C Hamano <gitster@pobox.com> In Debian/stretch we've 2.11.0-2 and are affected by this change. Adjust the `git status` checks accordingly to support git in all its versions. NOTE: we should consider switching to `git status --porcelain` (see git commit fc5af3bbb2 for some history about it) once we've the testsuite in place. Change-Id: If4223a35083d279e746dce5a80bcb86b52f64025	9 years ago
Michael Prokop	08f68c829b	MT#22361 Remember file permissions through pre-commit hook + restore-permissions helper script ... Git doesn't track file permissions (except for the executable flag). For sensitive data (like the 'ssl' directory and file 'constants.yml' with passwords included) we've to prevent non-root users from accessing those files. hooks/pre-commit is inspired and based on the implementation as present in etckeeper (and luckily we're license compatible) and takes care of storing the file permissions inside file /etc/ngcp-config/.ngcpcfg_perms. The restore-permissions helper script takes care of restoring the permissions after cloning the ngcpcfg repository via ngcpcfg itself (being actions decrypt, pull (PRO-only) + initialise (PRO-only)). It can be executed manually as well via `usr/share/ngcp-ngcpcfg/helper/restore-permissions /etc/ngcp-config/` (or wherever the according ngcpcfg repository is placed at). Regarding the commit integration: git(1) itself doesn't track file permissions, so we can't detect changes to file permissions using git itself. Our new pre-commit hook records file permissions via the .ngcpcfg_perms file. Now by just invoking it during 'ngcpcfg commit' time we can ensure that even if there have been any file permission changes in the working directory the file .ngcpcfg_perms is then up2date and committed. JFTR: The solution via the git pre-commit hook ensures that no matter whether you're using 'ngcpcfg commit …' or 'git commit …' you always get the file permissions handled via .ngcpcfg_perms. Now if you want to change file permissions in a clean working directory and commit *without* using 'ngcpcfg commit' but directly via git itself then you've to use 'git commit --allow-empty ...' and thanks to the pre-commit hook the file .ngcpcfg_perms will still be up2date. Change-Id: I84d608585c626b52112ff649893e232e441c59d8	10 years ago
Victor Seva	eac494cb42	MT#14229 clean shellcheck warnings ... While at it spread support for testsuite Change-Id: I60c4dae5479827b0d28ffa135105d9dbdf603825	11 years ago
Michael Prokop	3436c08361	Initial checkin	13 years ago