14 Commits (8fdb54b8c41c13f6a97aa9eaec00cd3e74c1f458)

Author	SHA1	Message	Date
Michael Prokop	bd9bf75e4a	TT#11776 Support git v2.9.3 and newer ... When installing Debian/stretch we fail at this stage: | ngcpcfg --no-db-sync commit On first glance it looks like a mariadb issue, though actually it's the git status check inside ngcpcfg that's failing. The reason is that starting with git v2.9.3 there's a different output in its "status" output: | commit 2a0e6cdedab306eccbd297c051035c13d0266343 | Author: Lars Vogel <lars.vogel@gmail.com> | Date: Thu Jun 9 20:19:30 2016 +0200 | | Use "working tree" instead of "working directory" for git status | | Working directory can be easily confused with the current directory. | In one of my patches I already updated the usage of working directory | with working tree for the man page but I noticed that git status also | uses this incorrect term. | | Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> | Signed-off-by: Junio C Hamano <gitster@pobox.com> In Debian/stretch we've 2.11.0-2 and are affected by this change. Adjust the `git status` checks accordingly to support git in all its versions. NOTE: we should consider switching to `git status --porcelain` (see git commit fc5af3bbb2 for some history about it) once we've the testsuite in place. Change-Id: If4223a35083d279e746dce5a80bcb86b52f64025	9 years ago
Michael Prokop	44b55fad89	TT#5030 Provide all sync-db output also to syslog ... /var/log/ngcp/ngcpcfg.log might not contain error messages from ngcpcfg's sync-db script. This might be confusing when comparing output from the command line with the logged actions from ngcpcfg.log. As sync-db doesn't log all error messages to stderr anyway and we ignore exit code of the sync-db script as well (on purpose) let's just redirect stderr and stdout to the same file descriptor and then provide output to the console as well as syslog's ngcpcfg tag. Output before this change: | root@sp1:~# ngcpcfg commit "before" | 2016-10-25 22:12:20: Executing sync-db: | DBI connect('database=provisioning;host=localhost;port=3306','sipwise',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /usr/share/ngcp-ngcpcfg/helper//sync-db line 70. | Error: Could not connect to database 'provisioning' at 'localhost:3306' as 'sipwise': Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) | 2016-10-25 22:12:20: OK: nothing to commit. | 2016-10-25 22:12:20: Synchronizing MySQL grants/credentials | Can't connect to MySQL database 'mysql': Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /usr/sbin/ngcp-sync-grants line 66. | root@sp1:~# tail -f /var/log/ngcp/ngcpcfg.log | [...] | Oct 25 22:12:20 sp1 (notice) ngcpcfg: Executing sync-db: | Oct 25 22:12:20 sp1 (notice) ngcpcfg: OK: nothing to commit. | Oct 25 22:12:20 sp1 (notice) ngcpcfg: Checking state of /etc files | Oct 25 22:12:20 sp1 (notice) ngcpcfg: OK: nothing to commit. | Oct 25 22:12:20 sp1 (notice) ngcpcfg: Synchronizing MySQL grants/credentials Output after this change gets applied: | root@sp1:~# ngcpcfg commit "after" | 2016-10-25 22:12:59: Executing sync-db: | DBI connect('database=provisioning;host=localhost;port=3306','sipwise',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /usr/share/ngcp-ngcpcfg/helper//sync-db line 70. | Error: Could not connect to database 'provisioning' at 'localhost:3306' as 'sipwise': Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) | 2016-10-25 22:12:59: OK: nothing to commit. | 2016-10-25 22:12:59: Synchronizing MySQL grants/credentials | Can't connect to MySQL database 'mysql': Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /usr/sbin/ngcp-sync-grants line 66. | root@sp1:~# tail -f /var/log/ngcp/ngcpcfg.log | [...] | Oct 25 22:12:59 sp1 (notice) ngcpcfg: Executing sync-db: | Oct 25 22:12:59 sp1 (notice) ngcpcfg: DBI connect('database=provisioning;host=localhost;port=3306','sipwise',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /usr/share/ngcp-ngcpcfg/helper//sync-db line 70. | Oct 25 22:12:59 sp1 (notice) ngcpcfg: Error: Could not connect to database 'provisioning' at 'localhost:3306' as 'sipwise': Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) | Oct 25 22:12:59 sp1 (notice) ngcpcfg: OK: nothing to commit. | Oct 25 22:12:59 sp1 (notice) ngcpcfg: Checking state of /etc files | Oct 25 22:12:59 sp1 (notice) ngcpcfg: OK: nothing to commit. | Oct 25 22:12:59 sp1 (notice) ngcpcfg: Synchronizing MySQL grants/credentials Change-Id: Iabb0c0ab24e212b79b0dfa85947cb274a161cc00	9 years ago
Michael Prokop	08f68c829b	MT#22361 Remember file permissions through pre-commit hook + restore-permissions helper script ... Git doesn't track file permissions (except for the executable flag). For sensitive data (like the 'ssl' directory and file 'constants.yml' with passwords included) we've to prevent non-root users from accessing those files. hooks/pre-commit is inspired and based on the implementation as present in etckeeper (and luckily we're license compatible) and takes care of storing the file permissions inside file /etc/ngcp-config/.ngcpcfg_perms. The restore-permissions helper script takes care of restoring the permissions after cloning the ngcpcfg repository via ngcpcfg itself (being actions decrypt, pull (PRO-only) + initialise (PRO-only)). It can be executed manually as well via `usr/share/ngcp-ngcpcfg/helper/restore-permissions /etc/ngcp-config/` (or wherever the according ngcpcfg repository is placed at). Regarding the commit integration: git(1) itself doesn't track file permissions, so we can't detect changes to file permissions using git itself. Our new pre-commit hook records file permissions via the .ngcpcfg_perms file. Now by just invoking it during 'ngcpcfg commit' time we can ensure that even if there have been any file permission changes in the working directory the file .ngcpcfg_perms is then up2date and committed. JFTR: The solution via the git pre-commit hook ensures that no matter whether you're using 'ngcpcfg commit …' or 'git commit …' you always get the file permissions handled via .ngcpcfg_perms. Now if you want to change file permissions in a clean working directory and commit *without* using 'ngcpcfg commit' but directly via git itself then you've to use 'git commit --allow-empty ...' and thanks to the pre-commit hook the file .ngcpcfg_perms will still be up2date. Change-Id: I84d608585c626b52112ff649893e232e441c59d8	10 years ago
Kirill Solomko	5a06286c46	MT#19407 add ngcp-sync-grants script ... - ngcp-sync-grants is responsible for ngcp mysql grants sync from a template - it is executed by the 'commit' trigger before ngcp-sync-constants Change-Id: I082256e57b1394a3f056ad1ca56a5443bfb5a745	10 years ago
Víctor Seva	b883a9f2b7	Revert "MT#15293 commit: [PRO] do pull first" ... This reverts commit 76ada0a772. Change-Id: Ibd01e0abfe24dcd3b6f681e66fa696cd7ca6852d	11 years ago
Victor Seva	eac494cb42	MT#14229 clean shellcheck warnings ... While at it spread support for testsuite Change-Id: I60c4dae5479827b0d28ffa135105d9dbdf603825	11 years ago
Victor Seva	76ada0a772	MT#15293 commit: [PRO] do pull first ... Change-Id: I09bd0078f77ef000ff96f3dba38e05d07c698531	11 years ago
Michael Prokop	2deea0fb39	MT#9557 Provide timestamps in console output ... Change-Id: I5be915fa876014cbb9c792b03be325d6595daac9	11 years ago
Alexander Lutay	92536298f7	MT#12513 Check $RTP_INTERFACES_CONFIG availability for sync-db ... Otherwise users notice error during upgrade mr3.7->mr3.8: > ngcpcfg commit 'snapshot during /usr/share/ngcp-upgrade-mr3.8/upgrade-2.8-to-mr3.8 - Mon Apr 13 10:29:24 CEST 2015' > YAML Error: Couldn't open /etc/ngcp-rtpengine-daemon/interfaces.yml for input:\nNo such file or directory > Code: YAML_LOAD_ERR_FILE_INPUT > at /usr/share/perl5/YAML.pm line 71 > OK > Synchronizing data from /etc/ngcp-config/constants.yml Change-Id: I2e4b8780d2ada64854186da93b03b8817eac99bf	11 years ago
Victor Seva	3aa645c003	MT#10059 move /etc/ngcp-config/generated.yml to /etc/ngcp-rtpengine-daemon ... Change-Id: I99d104fd24d9c2d0d8f1f4303f09d04e8aeb68a7	11 years ago
Richard Fuchs	3b030ceb89	MT#10059 support configurable rtp interfaces ... adds get_all_rtp_for_host helper script update sync-db to process rtp_interface preference Squashed commit of the following: commit f2be1ea221cd9da2e4d400bcfcac4baf914563db Author: Richard Fuchs <rfuchs@sipwise.com> Date: Thu Jan 22 11:59:27 2015 -0500 implement db syncing for rtp_interface enum prefs commit 584f52c6b0094c2ca01641cdac898436f3efce86 Author: Richard Fuchs <rfuchs@sipwise.com> Date: Thu Jan 22 10:32:08 2015 -0500 change name of generated.yml commit b980dff6a106256264c81ae1bf74aba20bf32383 Author: Richard Fuchs <rfuchs@sipwise.com> Date: Wed Jan 21 12:46:07 2015 -0500 MT#10059 make sync-db load generated yml commit 92d17d8c1895f4b04663a3e485be80402382522d Author: Richard Fuchs <rfuchs@sipwise.com> Date: Wed Jan 21 12:32:58 2015 -0500 fix comment syntax error commit af8500dc315b6c142250ab0119179cb1adc67e8c Author: Richard Fuchs <rfuchs@sipwise.com> Date: Wed Jan 21 12:04:25 2015 -0500 MT#10059 support undefined hostname commit 84b8a91de59ad8ae8ad944a784850e8ac08d94fe Author: Richard Fuchs <rfuchs@sipwise.com> Date: Wed Jan 21 11:57:16 2015 -0500 MT#10059 support plain list output format commit 2b9ec081c27842dc6839218f4e5c22b761d38550 Author: Richard Fuchs <rfuchs@sipwise.com> Date: Wed Jan 21 11:38:04 2015 -0500 MT#10059 adding get_all_rtp_for_host helper	11 years ago
Kirill Solomko	ec2fa4eb1a	MT#4585 - added "--no-db-sync" option that skips sync-db/sync-constants	12 years ago
Michael Prokop	928cd68cf2	Simplify default configuration code	13 years ago
Michael Prokop	3436c08361	Initial checkin	13 years ago