ngcpcfg

Commit Graph

Author	SHA1	Message	Date
Guillem Jover	ab24d116f6	TT#59403 Do not require some properties on network interface aliases An alias for a vlan interface will not have a raw device, stop requiring it. And an alias for a bond interface might not have miimon, mode or slaves attributes. Change-Id: I4b0f547f1c1d02ee826ad97db1a1f44ab91c0e63	7 years ago
Guillem Jover	cb0ce8c1d4	TT#59403 Move requirement for ip/netmask from vlan interfaces to any alias The point of an interface alias is to have a different IP, so let's make that required for any alias, but not for vlan interfaces themselves, because they might be used for bridging for example. Change-Id: I7b0fdc0d5cb327c774d6e98ccd7a61c4e6c19b8b	7 years ago
Alexander Lutay	4f2fb64879	TT#48194 Remove default/fallback validation for network interfaces Current problem: CE system doesn't pass ngcpcfg validation if interface name is 'ens0', installation is aborted on the final 'ngcpcfg apply'. There were a lot of code changes here and the original logic if fallback validation has been lost. The situation here is very unpleasant as all Jenkins tests reported no issues for us, as interface name is 'eth0' there. We have enabled validation be default in mr6.5, in the same time the validation schema we have is not yet perfect, but we must focus on 'trust' to validation functionality we introduced otherwise it will not be used by users. There is not point to have fallback in validation at this stage. As it can be triggered for random physical and logical interfaces in the system. Keep in mind mr6.5 generates /etc/network/interfaces from network.yml, so all interfaces must be described in network.yml. Change-Id: I1d90c64941bfb7eb8afad51c64c19f72b4ec65d9	8 years ago
Guillem Jover	4894342d59	TT#45728 Stop requiring netmask when we do not require ip In some conditional branches we make the ip key optional, but never change netmask to match. Which can end up being required when it should not, such as on a vlan interface. Change-Id: I9767434901abb2c0f07c10f8b8800987c2e363c5	8 years ago
Guillem Jover	d5d91d3411	TT#44257 Improve reporting on missing interface definitions When we declare an interface in the interfaces key, we should have an interface definition. Change-Id: Idc406ecd9a561c5c522b3b802c922b799c2a12d6	8 years ago
Alexander Lutay	ffedf0a0a2	TT#43055 ngcp-network-validator ignore empty duplicate IP/MAC in network.yml Otherwise we have false alarm here: > root@sp2:~# ngcpcfg --validate check > - [/hosts/<host>/<iface>/ip] Duplicate interface IP (sp1/vlan73 sp2/vlan73) > 2018-08-23 12:49:57: Error: Invalid schema detected for /etc/ngcp-config/network.yml For example, it happens if ipv6 only is defined for vlan, etc: > vlan73: > ip: "" > netmask: "" > shared_v6ip: > - some:valid:ipv6:shared > type: > - web_ext > - rtp_ext > - sip_ext > v6ip: some:valid:ipv6 > vlan_raw_device: eth0 Change-Id: I2db796102a36e7647cda0a9c275abe0e7801f605	8 years ago
Guillem Jover	20091c911e	TT#36755 Disable v6netmask requirement when there is v6ip This should not be a blocker for the upcoming release. We might revisit this for the next one. Change-Id: I4c34e36739d2a90b873535104ae029fed7b68cfe	8 years ago
Guillem Jover	a691a20de0	TT#36755 Check whether shared and advertised contain values We should not just check whether these keys are defined, but whether they contain actual IPs too. Fixes: commit `80f70d88b2` Change-Id: I122de32629164cc46537ab0800612c8654f1ba14	8 years ago
Guillem Jover	80f70d88b2	TT#36755 Add internal consistency check for address families If we are using DHCP we do not need either an IPv4 nor an IPv6. If we have an IPv6 we do not need an IPv4. If we have a netmask, a shared IP, an advertised IP, we should have the matching IP setting. Change-Id: I13f190086a0540495b0314e58ca301aae6db0453	8 years ago
Guillem Jover	b6983c6434	TT#18176 Detect unknown hostname patterns We should be exhaustive here, and any unknown pattern should be caught and reported, as we might miss information about peers and the cluster layout otherwise. Change-Id: I56a9a2b5b6c6f776c0c64fc2f8e01f5f76bb8e10	8 years ago
Guillem Jover	f034e8633b	TT#18176 Replace explicit prints to STDERR with warn Change-Id: I9394d654130324f6325dce78bd28d84b35ad67ed	8 years ago
Guillem Jover	6730c66166	TT#18176 Remove redundant check Change-Id: I6a4183559a936482360329648013ae60a9e85095	8 years ago
Guillem Jover	5775b11527	TT#30355 Ignore duplicate IP for dummy interfaces on network validator Change-Id: I97e14252e48b3f8113dcbb3af867c973f6e4f89e	8 years ago
Guillem Jover	cd6190d809	TT#17643 Make several properties conditionally required - eth* interfaces should have a hwaddr. - anything other than bond, eth should have type. - anything other than bond, eth and idrac* should have ip/netmask. Change-Id: I8c0b4f5eddaaab0c658a5281448735a985ee08f1	9 years ago
Michael Prokop	a42248419e	TT#22411 Fix spelling mistakes/typos s/Syncronizes/Synchronizes/ s/Wheras/Whereas/ s/configuation/configuration/ s/exisiting/existing/ s/explicitely/explicitly/ s/files files/files/ s/has has/has/ s/initialise initialise/initialise/ s/mulitple/multiple/ s/ouput/output/ s/propogates/propagates/ s/successfull/successful/ s/syncronizes/synchronizes/ s/the the/the/ s/uncommited/uncommitted/ Change-Id: Id13ec889c5de620b675e357d99066688cfc97617	9 years ago
Guillem Jover	2ab2a94830	TT#14817 Add new network.yml dynamic validator program This script will validate the network.yml based on a schema constructed from information only available from the network.yml file itself. This way we can do the strictest validation, which we could not do before. Change-Id: I32714e678e901e58d70e4253bcc61a147494c225	9 years ago

16 Commits (7131b2891cbf6afaae51cce4026727991530f0c5)