ngcpcfg

Commit Graph

Author	SHA1	Message	Date
Mykola Malkov	948f940975	MT#56090 Add maintenance.yml Change-Id: I02aca19e3b2afdc6a3982171f1d2578777694680	2 years ago
Mykola Malkov	a0dc08a9ba	MT#55289 Add support for multiple options In ngcp-initial-configuration there are a lot of multiple sequential calls of 'ngcpcfg set' which consume significant amount of time. So add support for setting multiple options to do it at once. Change-Id: I8cacdbec78ecefc4681048a0fb085b4cb705d83e	3 years ago
Mykola Malkov	a2a91ee09b	MT#55289 Add set-value helper Move perl code which actually modifies yml file to separate helper as there is no sense to recreate it every call of 'ngcpcfg set'. Change-Id: I08b10186b1aa127d4a2b81ef36b234dfdd46fc8e	3 years ago
Michael Prokop	e51151ec35	TT#173500 Create tmpfiles with template name We want to be able to track down any left-behind tmp files, so ensure we're creating them with according file names. Change-Id: I1aa0ccdb8834e8aef919f1f028028c1bb14cbd01	3 years ago
Guillem Jover	e875197950	TT#142950 scripts: Fix options parsing Switch all code to use a loop to parse options so that these can parse multiple options (currently some scripts would simply parse one or another but not several), and to make them easier to extend. Change-Id: I5e902f2d7d8db78e66e48db1237924fa7d8fdda1	3 years ago
Guillem Jover	79ed4aa594	TT#142950 ngcpcfg: Use proper file metadata when creating config with set When we are creating a new file with set, for a known config.yml variation, we need to apply the correct owner/group and mode or the next build will modify them and that will change spurious commits that have no relation to the action being taken at the time. Change-Id: I93017cdcdcf22fa1c5ef8e103d215aa7bc110b9a	4 years ago
Michael Prokop	0dda93ad97	TT#82051 Shellcheck fixes shellcheck v0.7.1 complains about a bunch of issues: SC1083: This { is literal. Check expression (missing ;/\n?) or quote it. SC1083: This } is literal. Check expression (missing ;/\n?) or quote it. SC1090: Can't follow non-constant source. Use a directive to specify location. SC2034: foo appears unused. Verify it or export it. SC2059: Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2128: Expanding an array without an index only gives the first element. SC2148: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. SC2155: Declare and assign separately to avoid masking return values. SC2162: read without -r will mangle backslashes. SC2164: Use 'cd ... \|\| exit' or 'cd ... \|\| return' in case cd fails. SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting). SC2237: Use [ -z .. ] instead of ! [ -n .. ]. We're still bound to support shellcheck v0.3.4 and sadly this version fails hard when using the modern "shellcheck source=" directives to address SC1090 and SC1091. It's failing like: \| not ok 1 source/functions/init:8:28: note: The mentioned parser error was in this then clause. [SC1009] \| not ok 2 source/functions/init:10:3: error: Couldn't parse this shellcheck annotation. [SC1073] \| not ok 3 source/functions/init:10:16: error: Unexpected "s". Fix any mentioned problems and try again. [SC1072] So until we can get rid of supporting this ancient shellcheck version, instead of using: \| # shellcheck source=etc/ngcp-config/ngcpcfg.cfg \| # shellcheck source=functions/init \| # shellcheck source=functions/logs \| # shellcheck source=functions/main we need to place disable=SC1090 and disable=SC1091 accordingly. Change-Id: I14da87a00102609bffdb60e932045180c6d13d5e	5 years ago
Alexander Lutay	35f0be2284	TT#78170 Fix option/value parsing for 'ngcpcfg set' in case if value has sign = We have to separate option/value using the first equal sign. Change-Id: I87a6fc11a1edd6beb3ec0ee819828557aa06ea17	5 years ago
Alexander Lutay	8c210c1a6c	TT#51601 Stop printing diff on ngcpcfg set/del by default. It produces security issues when diff is stored in logs (e.g. upgrade logs) and may contain passwords or another secrets. The special option '--diff' is introduced for users who require old behaviour. Change-Id: Ie4fd1ef2ee7fe1a51e87a99e36b5f71f6ecc8084	6 years ago
Alexander Lutay	203cdf9908	TT#44516 Fix quoting logic for script 'set' for values like '10G' It was impossible to set value like '10G' previosuly: >> ngcpcfg set /etc/ngcp-config/config.yml bootenv.netscript.fallbackfssize=10M > Bareword found where operator expected at /tmp/tmp.px3MpkUFZS line 28, near "10M" > (Missing operator before M?) > Bareword found where operator expected at /tmp/tmp.px3MpkUFZS line 30, near "10M" > (Missing operator before M?) > Bareword found where operator expected at /tmp/tmp.px3MpkUFZS line 31, near "10M" > (Missing operator before M?) > Bareword found where operator expected at /tmp/tmp.px3MpkUFZS line 33, near "10M" > (Missing operator before M?) > Bareword found where operator expected at /tmp/tmp.px3MpkUFZS line 34, near "10M" > (Missing operator before M?) > syntax error at /tmp/tmp.px3MpkUFZS line 28, near "10M" > syntax error at /tmp/tmp.px3MpkUFZS line 30, near "10M" > syntax error at /tmp/tmp.px3MpkUFZS line 39, near "}" > Execution of /tmp/tmp.px3MpkUFZS aborted due to compilation errors. The 'case' statement doesn't support regular expresions in Bash, let's rewrite them into linear check. Change-Id: I29ced837fca0abdc3cbe1ea18c614c4c1dd6780c	7 years ago
Richard Fuchs	5eeb478d57	TT#33030 allow overwriting entire subkeys with similar types Change-Id: I70b5b94cd6c5234f2a8b09fd2d4ebca488e5a31f	7 years ago
Richard Fuchs	bd3ca63bb9	TT#33030 enable setting of array elements via 'ngcpcfg set' also includes various sanity checks to avoid overwriting existing structures Change-Id: If97954040a77e84447686eff57a02bde8dfd1446	7 years ago
Guillem Jover	a4dd0365ef	TT#17650 Switch to use YAML::XS instead of YAML::Tiny The latter does not support YAML 1.1, nor many parts of the specification. Use the more compliant implementation, in addition to try to converge to a single one, so that we do not get serialization delta surprises. Change-Id: Ie51f1c79859d40ef0877fc0ab75f86ee72e14ea4	8 years ago
Alexander Lutay	4d207fc4f9	TT#16903 Introduce 'ngcpcfg set' and 'ngcpcfg del' functionality root@spce:~# ngcpcfg set /etc/ngcp-config/config.yml "aaa.bbb=123" @@ -1,4 +1,6 @@ --- +aaa: + bbb: 123 root@spce:~# ngcpcfg set /etc/ngcp-config/config.yml "aaa.bbb={'ccc','123','ddd','567'}" @@ -1,4 +1,8 @@ --- +aaa: + bbb: + ccc: '123' + ddd: '567' root@spce:~# ngcpcfg set /etc/ngcp-config/config.yml "aaa.bbb=['ccc','123','ddd','567']" @@ -1,4 +1,10 @@ --- +aaa: + bbb: + - ccc + - '123' + - ddd + - '567' root@spce:~# ngcpcfg del /etc/ngcp-config/config.yml "aaa.bbb" @@ -1,4 +1,5 @@ --- +aaa: {} apps: malicious_call: no party_call_control: root@spce:~# ngcpcfg del /etc/ngcp-config/config.yml "aaa" root@spce:~# Change-Id: Ife4810ee12c921a3e8ed5b323435802aa821fb60	8 years ago

14 Commits (4371e41f002d46b4f970a9b51d77cc1ecf984218)